Commit Graph

6627 Commits

Author SHA1 Message Date
Jamie Vigliotta
ac6ed5dd01 more more lint fixes 2020-08-14 10:55:01 -07:00
Jamie Vigliotta
6e0c1cc674 more lint fixes 2020-08-14 10:46:56 -07:00
Jamie Vigliotta
33c37ebf19 linting fixes 2020-08-14 10:44:02 -07:00
Jamie Vigliotta
c33c29b6f3 linting fixes 2020-08-14 10:27:56 -07:00
Shefali Joshi
37debefadc
Stop evaluation of conditions when one evaluates to true (#3276)
* Stop evaluation of conditions when one evaluates to true

* Fix broken test

* Fixes broken tests

* Addresses review comments - Rename getResult to updateResult

* Rename condition getResult to updateResult

* Renames condition getResult to updateResult
2020-08-14 10:09:35 -07:00
Shefali Joshi
891fe0a36b
Merge pull request #3154 from nasa/remove-action-tests
Remove action tests
2020-08-13 13:31:08 -07:00
Shefali Joshi
4b6de59b03
Merge branch 'master' into remove-action-tests 2020-08-13 09:52:35 -07:00
Jamie Vigliotta
6a5b902365 copyright stuff 2020-08-11 13:51:08 -07:00
Shefali Joshi
270f07ebd5
Compare the enum value to the input, not the index of the enumeration (#3277) 2020-08-11 13:19:38 -07:00
Jamie Vigliotta
52500f6097 lint fixes 2020-08-11 13:11:08 -07:00
Jamie Vigliotta
2fa8a8d61d Merge branch 'master' into iso-date-format
Merg'n master
2020-08-11 13:07:10 -07:00
Jamie Vigliotta
69a6cd20af linting 2020-08-11 13:01:54 -07:00
Jamie Vigliotta
28eb268af1 Merge branch 'remove-action-tests' of https://github.com/nasa/openmct into remove-action-tests
More merg'n
2020-08-11 12:57:26 -07:00
Jamie Vigliotta
045bb443cb Merge branch 'master' into remove-action-tests
Merg'n master
2020-08-11 12:57:02 -07:00
Joel McKinnon
c6ca912f2b
ESLint one-var, no-var rules (#3239)
* fixed issues for eslint one-var and no-var rules

Co-authored-by: Joshi <simplyrender@gmail.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-08-10 12:13:23 -07:00
Shefali Joshi
78c7484d54
Merge branch 'master' into remove-action-tests 2020-08-10 11:57:06 -07:00
Joel McKinnon
4d560086dd
ESLint upgrade, implement additional rules (#3230)
* upgrade to ESLintv7, added overrides for rules violated
* removed overrides for spec files
* fixed no-prototype-builtins issues
* added rules for default-case-last, default-param-last, grouped-accessor-pairs, no-constructor-return, and added override for one violation

Co-authored-by: Andrew Henry <akhenry@gmail.com>
Co-authored-by: Shefali Joshi <simplyrender@gmail.com>
2020-08-10 11:23:35 -07:00
Joel McKinnon
ef965ebdfd
ESLint rules: array-callback-return, no-invalid-this, func-style (#3151)
* satisfied array-callback-return rule
* satisfying no-invalid-this rule
* fixed invalid-this issues
* changed isNotEqual to arrow function
* added rule func-style
* added return false to satisfy array-callback-return rule

Co-authored-by: Joel McKinnon <jmckinnon@apple.com>
Co-authored-by: Joshi <simplyrender@gmail.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-08-10 10:59:18 -07:00
Joel McKinnon
0b4a843617
ESLint rules: rules requiring minor changes (#3139)
* implemented trivial code changes necessary batch of rules

Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-08-10 10:35:40 -07:00
Andrew Henry
7e7141a5a0
Fixes to enable testing again (#3275)
* Updated library versions
* Use Karma alternative spec loading
* Fixed memory leak in URLTimeSettingsSynchronizer
* Introduce mock DataTransfer object to fix issue with firefox headless
* make resetApplicationState return a promise
* Remove BeforeAll
* Do not throw an error if root returns no children
* Adding missing parameters to ES tests
* Fixed TransactionService bug
* bump test coverage up to 64%
2020-08-10 09:47:04 -07:00
Andrew Henry
b3fd6c9b85
Merge branch 'master' into iso-date-format 2020-08-03 14:34:38 -07:00
Shefali Joshi
deb0511b43
Merge branch 'master' into remove-action-tests 2020-08-03 13:43:40 -07:00
Shefali Joshi
e32f465f7a
Display layout plugin test coverage to 20% or more (#3158)
* Display layout plugin test coverage to 20% or more
Resolves #3157

* Changes address original issue? Yes
* Unit tests included and/or updated with changes? Yes
* Command line build passes? Yes
* Changes have been smoke-tested? Yes
* Testing instructions included? Yes

* Add disable-dev-shm-usage flag to ChromeHeadless launcher config in karma

* Adding disable dev shm usage flag to chromeheadless launcher and setting log level to debug

* Adding np activity timeout to 60000

* Adding no-sandbox flag for headless chrome

* Run tests without headless chrome to see if that fixes the fonts issue

* Fix typo

* Trying chrome headless with increased memory

* Reset karma.conf back to master

* Trying karma chrome launcher 3.1.0

* Revert to master code for package.json and karma.conf.js

* Trying node 12 browsers

* Revert back to node:13 browsers

* Revert to 10.2.1-browsers circle ci node browsers variant image for docker

* Rebuild node-sass for node 10.x

* Upgrading to 13.14.0 node

* Remove node options

* Don't restore cache before npm install

* Comment out tests with setTimeout

* Trying node 8-browsers

* Try firefox headless

* Firefox version typo

* Revert focused tests

* Exclude setTimeout tests

* Increase browser connectivity timeout

* Trying large timeout with Chromeheadless

* Going back to Firefox and setting browser timeout to 1.5 mins

* Fixes linting issues

* Fix broken tests and add some null checks in the code

* Change double quotes to single quotes
2020-08-03 13:41:57 -07:00
David Tsay
abc458cef4
[Time conductor] Better persistence handling for history (#3246) 2020-08-03 11:56:29 -07:00
Joshi
2198a4780b Merge branch 'master' of https://github.com/nasa/openmct into remove-action-tests 2020-08-03 09:47:42 -07:00
Shefali Joshi
b76d4b76cb
Merge pull request #3228 from nasa/telemetry-table-config-updates
Update TelemetryTable config to allow disable multiselect
2020-07-31 14:41:49 -07:00
Shefali Joshi
9ebb013f22
Merge branch 'master' into remove-action-tests 2020-07-31 14:30:14 -07:00
Shefali Joshi
5a4cba0226
Merge branch 'master' into telemetry-table-config-updates 2020-07-31 14:23:12 -07:00
Jamie V
f03bfdebb4
[Telemetry Tables][Plots] Display units where applicable (#3198)
* added unit columns in telemetry tables

* added unit column hiding in telemetry tables, added units to lad tables and sets

* added units to plots and plot legends
2020-07-31 13:13:58 -07:00
Jamie V
7c1550ced7
Merge branch 'master' into remove-action-tests 2020-07-31 12:46:40 -07:00
Andrew Henry
a09da30768
New eslint rules auto fix (#3058)
* no-implicit-coercion and no-unneeded-ternary

* End every line with a semicolon

* Spacing and formatting

* Enabled semi-spacing

* Applies npm run lint:fix to code after master merge

* Fix merge issues

* Switched operator-linebreak to 'before'

Co-authored-by: Joshi <simplyrender@gmail.com>
2020-07-31 12:11:03 -07:00
Jamie Vigliotta
66bb938fc4 renamed methods and variables for clarity 2020-07-31 11:48:23 -07:00
Jamie Vigliotta
0d478d5dfc making hasUnits computed value more clear 2020-07-30 17:48:32 -07:00
Jamie Vigliotta
2a9b431c50 WIP: cleaning up hasUnits computed in sets 2020-07-30 15:55:41 -07:00
Jamie Vigliotta
756e7e5372 making plot series name with unit a dynamic function 2020-07-30 15:38:32 -07:00
Nikhil
573a63d359
[Snapshots] Are holding on to outdated domainObjects when clicking on preview #3078 (#3240)
* [Snapshots] Are holding on to outdated domainObjects when clicking on preview #3078

* #3250 :  [Preview] Preview window should not have any context menu actions

* cleanup: removed redundant code
2020-07-29 16:33:39 -07:00
Jamie Vigliotta
3f2ad2be0c PR updates 2020-07-29 11:05:28 -07:00
Jamie Vigliotta
fd3be63805 classic eslint fix 2020-07-28 13:58:31 -07:00
Jamie Vigliotta
ad8ed419de removing old references in legacy code (accident) and adding tests for new formatter 2020-07-28 13:45:45 -07:00
Jamie Vigliotta
8b4f07c2e0 added ISOTimeFormat plugin and format 2020-07-28 11:23:56 -07:00
Deep Tailor
e667b22b3c
remove modified and persisted keys from duplicates (#3241) 2020-07-28 11:05:55 -07:00
Jamie Vigliotta
9198effafe adding ISO Time Formatter to be used with openmct-yamcs 2020-07-27 10:32:22 -07:00
Jamie V
7d51d9c1eb
parsing datum itself rather than specific key of datum, let telemetry api do the work (#3235) 2020-07-24 13:34:26 -07:00
Jamie Vigliotta
de6eceb98b parsing datum itself rather than specific key of datum, let telemetry api do the work 2020-07-24 11:37:41 -07:00
Jamie Vigliotta
72f7ec1481 removing checkforunits function 2020-07-24 10:51:52 -07:00
Deep Tailor
13ff0c368d
Merge branch 'master' into telemetry-table-config-updates 2020-07-24 10:46:02 -07:00
David Tsay
9124f4f566
allow table row to control object path for context menu actions (#3232)
Need for changes in VISTA
2020-07-24 10:41:36 -07:00
Jamie Vigliotta
5e21f98309 Merge branch 'master' into adding-units
Merg'n master
2020-07-24 10:41:17 -07:00
Jamie Vigliotta
26069dac79 final changes from PR comments 2020-07-24 10:11:46 -07:00
Mandlik, Nikhil K. (ARC-TI)[KBR Wyle Services, LLC]
b7d2402434 Update TelemetryTable config to allow disable multiselect. 2020-07-23 14:11:44 -07:00