Commit Graph

28 Commits

Author SHA1 Message Date
Andrew Henry
41783d8939
Fixed minor issues in Code Guidelines (#3596)
There was a missing semi-colon in a code example (oops!) and incorrect capitalization of the `const` keyword (overzealous word processor).
2020-12-11 15:13:51 -08:00
Andrew Henry
e9cf337aac
Merge branch 'master' into testing-guidelines 2020-06-17 15:38:56 -07:00
Andrew Henry
04a18248c7
Added reference to Angular memory leak best practices 2020-06-17 15:38:17 -07:00
Andrew Henry
d462db60de
Add note on convenience function for test cleanup 2020-06-17 15:31:35 -07:00
Andrew Henry
d9fafd2956
Tweaked code standards for ternaries and return statements (#3082)
* Tweaked code standards for ternaries and return statements

* Tweaked language slightly

Co-authored-by: Deep Tailor <deep.j.tailor@nasa.gov>
2020-06-17 10:52:30 -07:00
Andrew Henry
91a1b3f31d
Fixes a grammatical issue in the wording of the contributor's guide 2020-06-10 10:29:47 -07:00
Andrew Henry
7073b0717f
Merge branch 'master' into code-standards-update 2020-06-02 13:05:32 -07:00
Andrew Henry
d6bb1b2a12
Added note about requiring a single return statement. 2020-06-02 13:05:15 -07:00
Andrew Henry
3876151a4b
Added guidelines to testing documentation
Migrating our testing guidelines into the open source repository in the interests of transparency, and to assist contributors to the project.
2020-05-27 13:57:46 -07:00
Andrew Henry
a40ff07353
Updated guidance on anonymous functions 2020-05-16 16:11:42 -07:00
Andrew Henry
41dc9c794d
Fixed capitalization on CONST 2020-05-16 16:08:43 -07:00
Andrew Henry
f1faf3965d
Changed reference to constructors to classes 2020-05-16 16:07:49 -07:00
Andrew Henry
da2ecbbcad
Fixed formatting issues, removed outdated example code. 2020-05-16 16:06:59 -07:00
Andrew Henry
32c892fe98
Updated code standards 2020-05-16 15:56:30 -07:00
Andrew Henry
eb49ffae02
Update CONTRIBUTING.md 2020-05-13 09:21:00 -07:00
Andrew Henry
5751012872
Update CONTRIBUTING.md 2020-05-13 09:20:03 -07:00
Andrew Henry
aa041e04cf Merge remote-tracking branch 'origin/update-contributing-guidelines' into updated-checklists 2020-05-11 17:13:53 -07:00
Andrew Henry
24e7ea143a
Added more details on the process around pull requests 2020-05-11 17:12:25 -07:00
Andrew Henry
79d5d9c4d0
Update CONTRIBUTING.md 2020-05-11 16:15:17 -07:00
Andrew Henry
b5bfdc4418
Update CONTRIBUTING.md 2020-05-11 15:56:49 -07:00
Andrew Henry
59730c60ec
Update CONTRIBUTING.md 2020-05-11 15:54:25 -07:00
J.D. Sandifer
922ace1719 [Documentation] Edit for style
Edited for consistent period and parentheses usage throughout:
 - Removed periods at the end of each element in a list of nouns.
 - Placed periods outside parenthetical statements that aren't complete sentences themselves.
 - Placed periods at the end of sentences without punctuation.
2017-04-23 08:10:13 -07:00
J.D. Sandifer
8e82a4a66d [Docs] Edit for clarity
Around line 143, gave "constants" its own bullet point. Although it is a form of variable or field, it also forms a separate style element with a different guideline. It's also easier to find when skimming when separated - for new contributors who need to learn the style, and veteran contributors who are just double checking.
2017-04-23 07:48:42 -07:00
Victor Woeltjen
de2703ee48 [Branding] Remove Web from name at top-level
Per #816, change Open MCT Web to Open MCT in all top-level files.
2016-05-04 10:08:55 -07:00
Victor Woeltjen
e0608ddee0 [Documentation] Simplify Author Checklist
...as discussed in https://github.com/nasa/openmctweb/pull/349
2015-12-04 13:25:20 -08:00
Victor Woeltjen
730878938e [Documentation] Document pre-merge testing 2015-11-27 10:39:25 -08:00
Victor Woeltjen
4f0e8ada2f [Process] Loosen commit message standards
Loosen commit message standards, to minimize clutter in GitHub
issues. nasa/openmctweb#145.
2015-09-25 10:47:41 -07:00
Victor Woeltjen
841273edf6 [Code Style] Add CONTRIBUTING.md
Add CONTRIBUTING.md to formalize changes to code style
requirements for WTD-1482.
2015-08-17 15:22:26 -07:00