Deep Tailor
550e7a15e6
[persistence] fix for issue #1593
...
prevent EditorCapability#finish from calling transactionservice#cancel when transactionService was not active - leading to console error everytime user would leave edit mode
Add tests for changes made and also to check for return type in either case (isActive or not)
2017-11-21 12:07:59 -08:00
Victor Woeltjen
77c7bdfdec
[Timers] Follow timers from timelines ( #1694 )
...
* Squashed commit of the following:
commit f1dc1ce152e186da0d10c8e77d920ac0a76c9bc2
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:35:38 2017 -0700
[Timers] Rewrite JSDoc for FollowTimerAction
https://github.com/nasa/openmct/pull/1694/files#r137604769
commit 7ab0693cc983f8a04ac8ee9002f4d776b06a869a
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:27:53 2017 -0700
[Timer] Expect domain objects from FollowIndicator test
commit ff89c0849d16ab451bfd2fddd9202cf36940f599
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:26:28 2017 -0700
[Timer] Add JSDoc for new method
commit 2a0343352eca241dfc28a4aa0b3832e3e6928864
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:24:59 2017 -0700
[Timeline] Update TOI tests
...to account for refactoring out of tick handling.
commit 01cbaafc72870fab4ada5894637ae5721214933d
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:17:25 2017 -0700
[Timeline] Update dependencies for TOI test
commit 6bd5c378566362dce331e7c200dea87f0b08ecc6
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:15:21 2017 -0700
[Timers] Update timerService tests with dependencies
commit b0793865c5131e17a58786ec356d67f2f2bba4c5
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:09:54 2017 -0700
[Timers] Declare vars to satisfy JSHint
commit 9d2a63f7fe61dadf68255d795512ec55f532c533
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 14:07:12 2017 -0700
[Timeline] Handle stopped timer
commit 30871270514730f3f2f12482075e5140bb97fa1f
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 13:59:08 2017 -0700
[Timer] Tweak refactored timer logic
commit 53ad127ba7cf679377dc865301612a1d78399324
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 13:53:36 2017 -0700
[Timer] Convert times from timerService
...to reduce resposibilities for TOI controller.
commit f8341133cf23df383b8f6e4815b88e0066ebd2bc
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 13:03:37 2017 -0700
[Timeline] Factor out timer knowledge
commit aebd9e0ac223971b868b03343dbe4c61c6eb4849
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 12:34:58 2017 -0700
[Timeline] Consistently use this
commit 48ac427a20c5c343aecdbd54b068d8691f7830b6
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 12:33:57 2017 -0700
[Timeline] Remove unused tick binding/call
commit ea62f0a15ba4ab5de53213bbed14599eaf878d70
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 12:10:59 2017 -0700
[Timeline] Retrieve timestamp on demand
commit f53bd04b5e343b22ea52b431785ade891577bb6a
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 12:07:55 2017 -0700
[Timeline] Update clocks on bounds events
https://github.com/nasa/openmct/pull/1694/files#r137603081
commit 51d8e376ee46aafa13cd9a969c6f03885e10dafb
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 11:40:33 2017 -0700
[Timeline] Don't listen for non-existing tick events
commit 5cc40c488cec5e7453c2fe1dea5e5a4fa3509ecd
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 11:39:21 2017 -0700
[Time] Revert Time API changes
https://github.com/nasa/openmct/pull/1694/files#r137603081
commit c55c8bc627bf0a7f3cfd04b604b82d15ff469ab9
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 11:37:40 2017 -0700
[Timeline] Finish testing TOI controller
commit af5cea5f2f172a309568d477dfdf11b8d45e74bb
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 11:06:47 2017 -0700
[Timeline] Test TOI controller
commit ba64db68b132fa431e8ccdb533024bf2850f9712
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 10:06:41 2017 -0700
[Timers] Test timerService
commit 247e663b326ec5b8145b832af9b26086204baea3
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 10:05:24 2017 -0700
[Timers] Remove unused timerService method
commit 8d741ad5744e1b7deb669dbaa0f3d30e4eb5866e
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 09:59:32 2017 -0700
[Timers] Remove unused timerService dependency
commit b59c8917bdef5ec3e54c8857d993d86547cfe177
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 09:58:10 2017 -0700
[Timers] Remove unused timerService event
commit f15dd9827f835a814dc40a6201c90268a60ed64a
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 09:49:09 2017 -0700
[Timers] Test timer-following indicator
commit 2501f11af8c0b2aed9ebf16ffd28c0003b2701c2
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 09:42:54 2017 -0700
[Timer] Complete test coverage for FollowTimerAction
commit aa2be83fc15cd68ee6de4d9f8205dc2fcba8c35b
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 7 09:35:37 2017 -0700
[Timers] Begin testing Follow Timer action
commit d9062e0b0ff351b141dcb646972053ec72292d53
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 16:45:18 2017 -0700
[Timeline] Remove unused variables
commit 79ebe4dd2b2aefc1e83ea8142588ed0715b3c269
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 16:39:22 2017 -0700
[Timeline] JSDoc for TOI controller
commit 330f6b465188555e8e59f4eaf8ce1875b5335846
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 16:30:58 2017 -0700
[Timeline] Use different icon to follow time bounds
commit f0a3b628e6d1d843324085edd563b68997f5a215
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 16:30:46 2017 -0700
[Timeline] Simplify TOI following initialization
commit e76f3d1d525e0d19845b4c5b457995e60c416ad0
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 16:27:07 2017 -0700
[Timeline] Add toggle to follow time bounds
commit 8ec072c0a2a953c074e0c327430dd68f27894ffb
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 16:19:25 2017 -0700
[Timeline] Follow TC bounds based on boolean
commit 206a26734dedc267af6d298a77658aa261ca4fea
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 15:37:12 2017 -0700
[Timeline] Tune bounds following
commit 19563bdf53a036c7bf09c52924425a1902b243bb
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 15:19:19 2017 -0700
[Timeline] Remove unused method
commit 293981ec55ad115d7bd90b92f5bd090df64bd7c2
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 15:18:59 2017 -0700
[Timeline] Only update timestamp on tick
Leave bounds-following to the bounds event
commit 9180e15971d2043f0999a16f0aa8794273bcfc74
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 14:43:01 2017 -0700
[Time] Document tick event
commit c7b163dff0d94aaea86b76647501f21623b353e1
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 14:39:57 2017 -0700
[Timeline] Stop listening on destroy
...from the TOI controller.
commit ca7def3cf98e1eaf6c3aeb16cf9fd79452c86bd0
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 14:32:40 2017 -0700
[Timeline] Remove surplus watches
commit 367e7afa94ae1ed448e39f13be804c62e2bfcf00
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 14:30:14 2017 -0700
[Timeline] Very deltas are valid before panning
commit 7ee94f316e90d046015266a2a9168e349ff73345
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 14:28:10 2017 -0700
[Timeline] Scroll with TOI only while in view
commit 9d7bb431119b7bc6ddc86f0058718e4385478518
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 10:36:46 2017 -0700
[Timeline] Utilize zoomController.bounds
commit f151b9e8adfd235c31e32bef5fddab835efa7c8f
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 10:35:57 2017 -0700
[Timeline] Add methods to set zoom bounds
commit c3d0b9876ab79c18003838ed3315045c5fb2ddbb
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 10:32:08 2017 -0700
[Timelines] Observe bounds changes
...to synchronize zoom with Time Conductor, #1688
commit 58adafc46f231b0fd92827d10c377131166ff39c
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 09:37:07 2017 -0700
[Timers] JSDoc for TimerService
commit a325a8d5085bf1a4c9aa3ab20771308d4789765a
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 09:12:50 2017 -0700
[Timeline] Re-tweak follow scroll calculations
...for visibility.
commit 41e4bf153607b081aaf92253fa2b21300e2f0ea7
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 09:03:45 2017 -0700
[Timeline] Tweak follow scroll calculations
...for visibility.
commit 08a5b9f14ab629a310dc27a3771ca454f1187327
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 08:59:45 2017 -0700
[Timeline] Replace debug output with scroll updates
commit 26585ecd61341b4ee89abd8ee866e705a02bbc9a
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 08:59:07 2017 -0700
[Timeline] Move TOI to scrollable area
commit 654eda027c3c67a3a0ff33136109ca27d14762ba
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 08:56:07 2017 -0700
[Timeline] Begin implementing TOI following
commit 552f67a11ce439be58ab7ca7884c46241a25adee
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Sep 6 08:55:51 2017 -0700
[Timeline] At zoom-to-time method
For use by time-of-interest controller, #1688
commit 37acbfd458740b2c3176875f83d37f0fdf57e727
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Aug 30 12:46:33 2017 -0700
[Timeline] Remove other excess $apply calls
...although this should make us nervy about those callbacks being
invoked in different ways.
commit 0e72847c9ba59f957efa2d412cb77c024afa9e63
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Aug 30 12:44:27 2017 -0700
[Timeline] Remove $apply from $watch callback
...to avoid an infinite digest loop.
commit bade0fd9f60101d5b1b782cd28e608af493c9076
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Aug 30 12:42:18 2017 -0700
[Timeline] Begin adding TOI line to template
commit f94034a3b4136f6b174155397084f8cdb22ce544
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Aug 30 12:11:25 2017 -0700
[Timers] Add missing semicolon, satisfy JSHint
commit cb465b94011e7432cc7e4d9e815641f97dc61d7a
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Aug 30 12:08:45 2017 -0700
[Time] Verify that tick event is emitted
commit 7c84a86a33ceb73ba6a06801374ea3f89793c450
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Aug 30 11:59:06 2017 -0700
[Time] Emit tick events from Time API
https://github.com/nasa/openmct/pull/1694
commit d319a783fcd882c03eb7d9a81fec33898016384e
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Wed Aug 30 11:56:28 2017 -0700
[Timeline] Sketch in TOI controller
...to position/follow time-of-interest, relative to the active timer.
commit 2dbdb2627450039d69dbfd10eed2c100207e061a
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 12:57:47 2017 -0700
[Timers] Use timerService
...to coordinate between action and indicator
commit f94a2358eaf0366bd4da2b44e69ccb62b153c5db
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 12:52:22 2017 -0700
[Timers] Use TimerService from Follow Timer action
commit a720c2ec2cda4a300d26167f4717f0571bedcbfd
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 12:50:31 2017 -0700
[Timers] Expose TimerService through bundle
commit e32bbc3e232d25f7c5dba98674781e4f263c4870
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 12:49:03 2017 -0700
[Timers] Sketch in timer service
...which will keep track of the active timer used to interpret SET
for Timelines.
commit a038c2b1d8fd34c2874fa8fc0421fa7ba53e11ab
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 12:41:05 2017 -0700
[Timers] Register indicator
commit 0e93ae87a1cccc4f3a0636844625b64ccb77a7ae
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 12:39:21 2017 -0700
[Timers] Skeleton for time following indicator
commit e806386891639740e9fe3d8641c2f60ab5a88eac
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 09:37:14 2017 -0700
[Timers] Register the Follow Timer action
commit 008aa95932070459dcc6fa1d918a23dac8df7592
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Tue Aug 29 09:35:08 2017 -0700
[Timers] Skeleton for Follow Timer action
...to synchronize the time conductor with a particular Timer. #1688
* [Timers] Remove unused variable to pass lint checks
* [Timers] Frontend updates for time-of-interest
Squashed commit of the following:
commit 370b910d36Fixes #1688
commit 883d1feb32Fixes #1688
commit cff85fbbdeFixes #1688
commit 563a86b69fFixes #1688
Added line icon, style refinement;
commit fc49e5d023Fixes #1688
Moved TimelineTOIController up 2 levels of markup hierarchy
to allow Follow Lines, one in each split pane;
Follow LInes markup and CSS in progress;
commit 8ec3c42291Fixes #1688
VERY WIP! Initial move of styles into classes;
* [Timeline] Follow up on front-end updates
Fixes #1688
Squashed commit of the following:
commit 817c7f31289b3e7631c3332d2192a68f21f50f9e
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 21 12:47:48 2017 -0700
[Timeline] Initialize lastWidth
...to avoid clamping values before a width has actually been observed.
commit 5f7324c1cdb0cbef6385fbccac31b0404d216f95
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 21 12:21:11 2017 -0700
[Timeline] Clamp right edge of zoom
...to avoid getting stuck in a weird scrolling state for large
timer values.
commit 076aca112392e65835e7a01ac8e28780d24bfff1
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 21 12:02:23 2017 -0700
[Timeline] Don't set scroll.x to negative values
...avoids mispositioning timer-following line,
https://github.com/nasa/openmct/issues/1688#issuecomment-330373625
commit ac9bdb919df69fac65b297487131e2c41204ebeb
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Sep 21 11:32:49 2017 -0700
[Timers] Loosen test expectation
Resolves build failure https://circleci.com/gh/nasa/openmct/4181
by reducing test specificity for indicator display name.
* [Timer] Handle mutations to followed timers
Fixes #1741
Squashed commit of the following:
commit 5fdd156dc9089baac2e975a85373146e0b788731
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Oct 5 12:18:06 2017 -0700
[Timer] Test mutation observation
...to verify resolution of root cause for #1741
commit 348b193fd45fc457d4b56bc1ddb2249aab65afba
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Oct 5 12:15:05 2017 -0700
[Timers] Update expected API usage in Follow Timer test
commit 7a584dd993d68c4c50a99ac66976420b5931893c
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Oct 5 12:12:11 2017 -0700
[Timers] Update spec for timerService
...to account for use of openmct.objects
commit ad396a79f0bad9dfc5382745943dd34ddcee1bef
Author: Victor Woeltjen <victor.woeltjen@nasa.gov>
Date: Thu Oct 5 12:10:25 2017 -0700
[Timer] Observe timer mutations
...such that followed timer remains in sync with timer model,
e.g. during navigation. Fixes #1741
2017-10-20 18:05:35 -07:00
Pete Richards
a2e424203a
Merge pull request #1777 from nasa/iframe-border-1776
...
[Frontend] Review and integrate the death of iframe borders
2017-10-13 20:59:50 -07:00
Charles Hacskaylo
16853644cb
[Frontend] Kill iframe borders dead!
...
Fixes #1776
2017-10-13 17:05:37 -07:00
Pegah Sarram
715219c44d
[Edit] Fix the issue with currentTarget being null and HTML being added on Enter
...
Remove the line break that is added when the return key is pressed.
Check the current target directly.
Use textContent for inline editing instead of innerHTML, which will hoist up some HTML content implicitly created around user input for a contenteditable span.
Note that there is a removeAllRanges in addition to a blur here; see
https://stackoverflow.com/questions/4878713/how-can-i-blur-a-div-where-contenteditable-true
Fix broken tests.
Fixes #1757
2017-10-13 11:50:40 -07:00
Victor Woeltjen
8703f363b8
Merge pull request #1744 from nasa/inspector-issue-1276
...
Inspector issue 1276
2017-10-10 15:33:27 -07:00
Deep Tailor
26210eaa50
make reviewer requested changes
2017-10-10 14:37:25 -07:00
Deep Tailor
a4a1cb5e05
fix tests by adding listen function, and fix lint/checkstyle errors
2017-10-10 13:32:42 -07:00
Pegah Sarram
eb4ded39b3
[Edit] Allow inline-editing the name only if the object is editable
...
Made the contenteditable attribute conditional based on whether the object can be edited or not. If the object is not editable, the attribute is removed.
Add Tests.
Fixes #1746
2017-10-10 12:32:51 -07:00
Deep Tailor
7deb3cd025
add if statement to check is objects are not equal before reassigning metadata
2017-10-03 14:34:01 -07:00
Deep Tailor
06779e6cd9
add mutation listener to Inspector Controller
2017-10-03 13:33:09 -07:00
Charles Hacskaylo
7f43c0bf1a
Add Notebook icon ( #1742 )
...
* Add Notebook icon
Fixes #1739
Added to Style Guide as well
* Add icomoon project file
Fixes #1739
2017-10-02 13:09:58 -07:00
Charles Hacskaylo
138cb199bb
[Front-end] Markup and CSS refinements
...
Fixes #1729
Internal markup and CSS now sets heights
internally - menu height will now not be smaller
than the list of menu items OR the description
area;
2017-09-25 14:59:12 -07:00
Charles Hacskaylo
e9cb5cd639
[Front-end] Scrollbar-related color and padding
...
Fixes #1729
2017-09-25 12:08:59 -07:00
Charles Hacskaylo
bc7d92ee0d
[Front-end] Menu tweaks
...
Fixes #1729
Mini super-menu and related description text
2017-09-25 12:08:04 -07:00
Charles Hacskaylo
78f49784a0
[Front-end] Tweaks
...
Fixes #1729
CSS and markup mods to convert
to flex from abs pos;
2017-09-25 11:10:58 -07:00
Pegah Sarram
1419c75503
Inline edit object names ( #1700 )
...
* Inline edit object name.
Change the title-label span to a conteneditable span to allow editing object names inline. Implement a controller to handle updaing the name. Add tests.
Fixes #1679
[Front-end] Add span contenteditable to input styling
[Front-end] Styling for contenteditable span
styling for span[contenteditable].s-status-editing in _controls.scss;
removed s-filter class;
[Front-end] min-width added to .s-inline-edit
* [Frontend] Style tweaks, cleanup and simplification
Fixes #1679
Style sanding on .s-inline-edit; added
:focus outline:0 to select in _controls.scss;
New .s-input-inline class; removed ng-class from object-header.html,
uses :focus instead; refactoring of input-related mixins;
Bring Time Conductor real-time inputs into parity
Apply .s-input-inline to TC inputs; finesse .s-input-inline selector;
Prevent nested inline inputs from editing
Fixed nested editing prevention selector
* Create an object header template for objects inside a frame.
Fix code review requests.
Fixes 1679
2017-09-21 11:16:04 -07:00
Charles Hacskaylo
68abc15ed5
[Frontend] Fix alignment and font-size issues in tool-bar
...
Fixes #1496
2017-09-14 15:02:22 -07:00
Victor Woeltjen
469820fb0f
Merge pull request #1712 from nasa/link-1710
...
Review and merge fixes for Hyperlinks
2017-09-14 12:15:09 -07:00
Charles Hacskaylo
9fe1923189
[Front-end] Fixes for Hyperlinks
...
Fixes #1710
Converted to span to confine clickable area
to text only;
Link now uses `overflow: hidden` in frame;
Normalized font-size when .s-button;
2017-09-14 11:05:05 -07:00
Charles Hacskaylo
42ddb38629
[Front-end] Cleanups to imagery in frame
...
Fixes #1704
Imagery now lays out better when very small
in a Layout; refactored .left and .right classes;
2017-09-14 10:37:41 -07:00
Charles Hacskaylo
fe60d7abbc
[Front-end] Fix CSS targeting
...
Fixes #1704
Pause/play and New Tab buttons now
display properly;
2017-09-14 10:25:34 -07:00
Deep Tailor
7f75e089e8
remove workaround for Imagery Thumbnail resizing from MCTSplitPane and add box sizing to thumbs wrapper to fix phantom resizing
2017-09-11 16:35:14 -07:00
Charles Hacskaylo
8e8c66280f
Fix for Issue #1676
...
Add history imagery under large imagery view.
Allow users to click on history imagery thumbs to set main image and pause the imagery view.
Allow users to unpause and continue imagery stream.
Users can adjust the height of the imagery panes, and the user selected height is persisted.
2017-09-11 12:51:04 -07:00
Charles Hacskaylo
ce561e1598
[Glyphs] Add import and export icons
...
For #1695
2017-09-11 11:41:19 -07:00
Victor Woeltjen
b6a8078634
Merge pull request #1692 from nasa/timeline-issue-1686
...
update mct-split-pane to use userPreferenceWidth only when alias is p…
2017-08-29 11:56:27 -07:00
Deep Tailor
e53b34ed60
move newPosition check from mctSplitPane to splitter
2017-08-29 11:50:20 -07:00
Deep Tailor
0e3b629d90
update changes requested by victor and update corresponding tests
2017-08-29 11:27:01 -07:00
Charles Hacskaylo
23216e5aee
[Frontend] Restored commented SASS
...
Fixes #1685
2017-08-29 11:24:40 -07:00
Deep Tailor
aa336dfd57
fix gulp checkstyle errors
2017-08-29 10:45:41 -07:00
Deep Tailor
556296096d
fix tests to correspond with changes made to MCTSplitPane
2017-08-29 10:34:44 -07:00
Deep Tailor
e4aaa860a3
update mct-split-pane to use userPreferenceWidth only when alias is provided, otherwise set position as usual (fix for timeline sync issue)
2017-08-29 10:15:29 -07:00
Victor Woeltjen
a4d8e8ff90
Merge pull request #1683 from nasa/limits-1677
...
Review limit and status CSS classes
2017-08-28 12:35:24 -07:00
Pegah Sarram
cecd708dd1
Layout selection and show/hide frame
...
Added ability to show/hide object frames via a toggle button in the
edit toolbar. All objects have frames by default except for ‘hyperlinks’.
Also, implemented object selection in the layout and added tests for new features.
Fixes #1658 .
2017-08-22 16:45:34 -07:00
Charles Hacskaylo
747afa6200
[Frontend] WIP
...
Fixes #1677
Refactor and re-organize alert and status colors;
Rename _limits.scss to _status.scss;
Style Guide additions in progress;
VERY WIP, NEEDS UNIT TESTING FOR REGRESSION.
2017-08-17 16:32:25 -07:00
Pete Richards
f3b519d47b
Merge pull request #1672 from nasa/paneController-Issue#1670
...
Fix for Pane controller issue#1670
2017-08-17 16:10:20 -07:00
Deep Tailor
c472ab044b
Add functionality to allow users to add hideParameters to the url, which will hide tree and/or the inspector
...
New Tab automatically appends hideTree and hideInspector params to hide those panes by default
Add appropriate tests for new functionality and fix broken tests
2017-08-17 15:25:01 -07:00
Charles Hacskaylo
008f1387ed
Merge remote-tracking branch 'origin/master' into limits-1677
2017-08-17 14:56:11 -07:00
Charles Hacskaylo
6ed76708ec
[Frontend] WIP adding status classes
...
Fixes #1677
2017-08-17 11:30:00 -07:00
Charles Hacskaylo
603e990755
[Frontend] Refactoring of limits CSS
...
Fixes #1677
Removed `<tr>` support; modded existing styles to allow
color-only application for red and yellow limits; added
`*-icon` classes for red and yellow limits;
2017-08-17 09:08:12 -07:00
Pete Richards
586901aee7
Merge pull request #1663 from dtailor90/master
...
persist user preference width for MCTSplitPanes issue #1646
2017-08-16 15:31:26 -07:00
Deep Tailor
449923feae
Persist User preference widths for MCTSplitPane
...
Fix to Issue #1646
Persist MCTSplitPane widths to local storage, thus when user reloads, the Panes maintain dimensions
Use persisted widths if available otherwise use default
Add tests for localStorage and fix failing tests
2017-08-16 15:04:33 -07:00
Charles Hacskaylo
0417b7e32d
[Front-end] Hyperlink styling
2017-08-14 12:38:01 -07:00
Charles Hacskaylo
7c9a6bd817
[Front-end] Integrate Hyperlink related changes from #1685 work
...
Fixes #1685
(cherry picked from commit 4dff369
2017-08-14 12:18:19 -07:00
Charles Hacskaylo
43b92647fb
[Frontend] Updated glyphs
...
Updated art for glyphs for
icon-frame-show and -hide;
2017-08-11 14:35:21 -07:00
Charles Hacskaylo
c523480b48
[Glyphs] Updated icomoon 16px project file
2017-08-08 11:47:29 -07:00
Charles Hacskaylo
4dc09975d0
[Style Guide] Glyphs additions and subtractions
...
Removed unused 12px glyphs;
Added 16px crosshair;
Fixed erroneously removed overlay plot glyph;
Updated style guide content
2017-08-08 11:41:55 -07:00
Charles Hacskaylo
2d1ee80322
[Glyphs] Update glyphs
...
Add grid snap and layout show/hide frame
glyphs
2017-08-01 15:50:30 -07:00
Charles Hacskaylo
7555eab1e3
[Glyphs] Bring in updated version of glyphs
...
Add glyphs from summary widgets
2017-08-01 15:43:32 -07:00
Charles Hacskaylo
4923bcbd85
[Glyphs] Bring in updated version of glyphs
...
Add glyphs from summary widgets
2017-08-01 15:40:43 -07:00
Pete Richards
34c3763421
Merge pull request #1635 from nasa/historical-imagery
...
[Historical imagery] [WIP]: Add historical view for image telemetry
2017-07-26 11:36:21 -07:00
Pete Richards
6aed3bb0b5
Merge pull request #1638 from nasa/only-time-change-when-changed-1636
...
[Time API] Only change time when changed
2017-07-13 17:11:59 -07:00
Pete Richards
1ae62cde05
[Browse] Don't klobber params when preventing default
...
When browse controller is hijacking a browser navigation event,
it calls preventDefault on the route change. This has the effect
of preventing all changes in the location (including search changes).
This change checks if other changes were made in the route change and
re-applies them after the navigation has completed.
Fixes a bug where navigating via a link that contained additional
search paramterers would have the effect of navigating but not
keeping the parameters in tact.
Discovered in the course of fixing #1636
2017-07-13 16:48:38 -07:00
Preston Crowe
218ef16160
[Imagery] Implemented historical view for imagery
...
Implemented auto-scrolling historical imagery view in ImageryController. Imagery domain objects now request historical data on each manual bounds change. Added new specs for ensuring that historical data is requested on bounds change and duplicate bounds / datum are ignored.
2017-07-12 12:13:57 -07:00
Pete Richards
89515bb896
verify that eval isn't called after destroy
2017-07-05 16:48:09 -07:00
Pete Richards
d82230dea4
[Resize] don't trigger callback when destroyed
...
Prevent MCTResize from triggering a callback after it is destroyed.
Fixes https://github.com/nasa/openmct/issues/1509
2017-07-04 17:03:25 -07:00
Victor Woeltjen
34ef98e0cd
Merge pull request #1595 from dhrubomoy/timezone_dropdown_feature
...
[CLOCK] Allow clock to set timezone with autocomplete dropdown option.
2017-06-26 16:51:30 -05:00
Preston Crowe
bc616ecdee
Revert "Historical imagery "
2017-06-25 20:46:09 -07:00
Preston Crowe
95e68fce57
Integrated historic and realtime telemetry in imagery timeline view, added sass constast for timeline hover color
2017-06-25 13:02:04 -07:00
Dhrubomoy Das Gupta
7b690d0785
Revert "[Autocomplete] Show warning icon if invalid option was typed"
...
This reverts commit 307320b3ff
2017-06-25 14:58:28 -04:00
Charles Hacskaylo
e7ba13f844
[Frontend] Add number input
...
Fixes #1628
Add template and bundle info for numberfield;
Styling in general and toolbar contexts;
2017-06-23 11:07:24 -07:00
Dhrubomoy Das Gupta
307320b3ff
[Autocomplete] Show warning icon if invalid option was typed
2017-06-21 22:35:32 -04:00
Pete Richards
ba9941891d
Merge pull request #1612 from nasa/no-keyframe-anims
...
Review and merge no-keyframe-anims branch
2017-06-21 11:08:23 -07:00
Luis-Johannes Schubert
e2f0f61862
Implement new folder List view ( #1610 )
...
* refactored code for listView
* minimum viable folder list functionality
* moved listview directory inside of platform/features
* [Folder ListView] First Code Review Fixes
Changes made:
Updated listview icon as the hamburger menu.
Injecting listview template as textfile instead of using the template's url.
Added callback to $scope to listen for $destroy to release resources for the mutation listener and the gesture recognizer.
Refactored ListViewController formatting function to use map instead of foreach.
Added listview plugin to the default registry.
Updated table styling.
* working progress commit. ListViewControllerSpec is implemented and all tests are passing. MCTGestureSpec is not fully implemented. Testing the gestureService release is in progress.
* All tests in MCTGestureSpec and ListViewControllerSpec are passing.
* ListViewControllerSpec and MCTGesture Tests all passing.
* refactored variable names in ListviewController to make more sense.
* [Frontend] Styling of Luis's list view WIP
Fixes #1615
This will have conflicts with Luis's work,
be careful!
* [Folder ListView] Second Code Review Fixes
Changes made:
updated listview to utilize open-mct sorting style.
added license comments to all files.
modified mctgesture interface to use $scope.eval().
* [Frontend] Styling of Luis's list view WIP
Fixes #1615
New list-view glyph added
* [Frontend] Styling of Luis's list view WIP
Fixes #1615
Changed name of "Items" view to "Grid";
* [Frontend] Styling of Luis's list view WIP
Fixes #1615
Updated icomoon project file with new list-view
glyph e1042;
* [Folder ListView] Second Code Review Fixes
Changes made:
updated listview to utilize open-mct sorting style.
added license comments to all files.
modified mctgesture interface to use $scope.eval().
* [Frontend] Styling of Luis's list view WIP
Fixes #1615
Refined cursor CSS;
* [Frontend] Styling of Luis's list view WIP
Fixes #1615
Added logic to refine how sorting occurs:
now, clicking a table header that wasn't
the orderByField always sorts by its default;
2017-06-19 18:35:18 -07:00
Pete Richards
5fbf71264e
Merge pull request #1563 from nasa/open-623
...
[Timers] Add stop button
2017-06-19 18:20:25 -07:00
Charles Hacskaylo
a8a689f69a
[Frontend] WIP remove keyframe anims
...
Fixes #1603
Remove keyframe anims from transition to edit mode
and border-color anim in _messages.scss;
2017-06-09 11:40:58 -07:00
Charles Hacskaylo
c7787aa1f0
[Frontend] WIP remove keyframe anims
...
Fixes #1603
Remove keyframe anims from transition to edit mode
2017-06-06 16:18:22 -07:00
Dhrubomoy Das Gupta
3870266131
[Autocomplete] Clicking the arrow will display the entire list of timezones
...
This change is based on the following code review:
- Display the entire list of timezones, regardless of what's currently entered.
- As soon as the user typed (or deleted chars in the input) then that filtration would take over the list display
2017-06-06 18:55:16 -04:00
Dhrubomoy Das Gupta
893e24ff98
[CLOCK] Issue #1273 : Allow clock to set timezone with autocomplete dropdown option.
2017-05-28 20:21:52 -04:00
Pete Richards
04c2eac9ef
[Layout] Add view large button for zooming
...
Fixes #1437
Markup and CSS for `view large` button in frame context;
Sass formatting cleanups; removed unused styles from
_layout.scss; mods to MCTTriggerModal.js to remove
button label functionality;
Added new "icon-expand" glyph and class;
Fixes #1437
Fixes #1423
New overlay > l-dialog and l-large-view classes;
Fix context-menu z-index to allow context menu
to appear in the overlay;
.object-top-bar refactored and replaced with
.object-browse-bar;
frame > hover now only displays local controls for
proper level, handles nested layout situation;
Fixed font-weight display issues;
MCTTriggerModal.js modified to do the following:
- Remove .frame classes when displaying object in overlay
- Allow click on this overlay .blocker to dismiss overlay
Fixed min-width issue incorrectly targeting .object-browse-bar in frame context;
Added expand anim to large view holder;
Changed close button icon
Significant mobile styling and cleanups;
Markup mods for overlay.html;
Handles dialog on top of large view;
Form validation now displays better in mobile;
Updated /src/api/ui/dialog.html to be in-line
with /platform/commonUI/dialog/res/templates/overlay.html;
Moved border-radius from containerBase to btnBase mixins;
Animate with scale for GPU acceleration
Change desktop animation to use scale, so that it is hardware
accelerated and buttery smooth. Also fixes text anti-aliasing
to improve readability.
Moved mobile/overlay/_overlay.scss styles into
overlay/_overlay.scss; removed mobile/overlay/_overlay.scss;
Cleanups in _overlay.scss; restored max-width/max-height
to dialogs (removed in #1376 for #1298 ) and added
min-width;
[Frontend] Mobile fixes in overlay and related
Fixes #1437
Added mobile-specific styling to _messages.scss;
Fixed button layout and margins in _overlay.scss;
Fixed message.html to not default to major style
buttons;
[Frontend] Timing tweaks
Fixes #1437
Moved large view expand transition duration
into theme _constants files; shortened anim
duration
Fix Style errors
[mctTriggerModal] correct scope for toggle
Correct scope for toggleFunction such that #1503 no longer occurs.
Fixes #1503
[Style] Add copyright header
2017-05-18 18:18:19 -07:00
Vikash Agrawal
57d3965fa6
chore: Remove unsed variables from codebase
2017-05-16 08:55:21 +05:30
Pete Richards
88223f5e6d
[Time] Always include basic formats
...
Always include basic formats; removing them from the utc format
bundle. This way, they can be utilized by third parties without
them having to commit to the utc time system.
Fixes https://github.com/nasa/openmct/issues/1574
2017-05-10 17:41:25 -07:00
Victor Woeltjen
29d65e9cef
Merge pull request #1547 from nasa/no-error-on-root-load
...
[Browse] Handle missing path and nav to root
2017-05-10 14:51:07 -07:00
Victor Woeltjen
906646704e
Merge remote-tracking branch 'origin/master' into open-623
2017-05-03 16:05:03 -07:00
Victor Woeltjen
4e15d8fa1f
Merge pull request #1479 from nasa/open1233a
...
Review and publish Open MCT Style Guide v1
2017-05-02 12:01:25 -07:00
Henry
0793442518
[Time API] Provided 'AddFormat' method for registering new formats
2017-04-30 23:21:13 -07:00
DJ Johnson
8fb9306272
Merge branch 'master' into open-623
2017-04-29 17:10:27 -05:00
Henry
f17417a541
[Time API] Modified public Time API to support registration of time systems and clocks, setting of active clock, simplification of clocks and time systems, setting of offsets(deltas) and other changes as per #1265 and #1474 . Refactoring of UI code to support changes.
2017-04-28 16:03:59 -07:00
Pete Richards
f02f1d47f1
[Browse] Handle missing path and nav to root
...
When no path is specified, don't throw error. Navigate
to default, as expected.
When navigating to root, navigate to the last child
of root instead. This handles cases where DEFAULT_PATH
is not found (e.g. deployments without "mine").
2017-04-27 14:14:35 -07:00
Charles Hacskaylo
5f8a35ecc0
Merge branch 'master' into open1233a
2017-04-26 12:24:47 -07:00
Andrew Henry
ec4fe8efb3
Merge pull request #1518 from nasa/copyright-1517
...
[Licenses] Update copyright year to 2017
2017-04-23 17:22:01 -07:00
Charles Hacskaylo
77ca3e9033
[Frontend] Removed button selector - too broad
...
Fixes #1485
2017-04-07 16:41:01 -07:00
Victor Woeltjen
0cbbeefd62
[Licenses] Update copyright year in About dialog
2017-04-05 15:07:50 -07:00
Victor Woeltjen
185567cf29
[Licenses] Update copyright year to 2017
...
Fixes #1517
2017-04-05 14:52:46 -07:00
Henry
4e457f1cf0
Fixed failing tests, and added new tests
2017-03-27 11:15:27 -07:00
Henry
1cb5dd021f
Modified composition policies to consider object instances instead of types. Fixes #669
2017-03-24 16:59:30 -07:00
Henry
399b745084
[Persistence] Prevent editing of objects that cannot be saved. Fixes #1483
2017-03-24 14:01:39 -07:00
Charles Hacskaylo
16b6a70e22
[Frontend] Cleanups for Inspector
...
Fixes #1266
2017-03-21 10:18:29 -07:00
Charles Hacskaylo
d39ab17db4
[Styleguide] Merge in latest master
...
Fixes #1233
Todo: Need to fix page types
2017-03-15 17:09:52 -07:00
Charles Hacskaylo
6fa5a31217
Merge pull request #1433 from nasa/open1432
...
[Build] Installed sound suppression system for Bourbon deprecation messages.
2017-02-27 11:12:27 -08:00
Andrew Henry
f7ff5af60b
Merge pull request #1448 from nasa/update-composition-policy
...
Update composition policy
2017-02-21 17:18:59 -08:00
Andrew Henry
2088fc52f3
Merge pull request #1446 from nasa/fix-orphan-navigation
...
Orphan check uses capability not model
2017-02-21 17:08:40 -08:00
Andrew Henry
db33ab143e
Merge pull request #1445 from nasa/api-updates
...
Api updates
2017-02-21 17:04:45 -08:00
Pete Richards
2a10a2cae2
Update specs to match composition policies
2017-02-21 15:14:35 -08:00
Pete Richards
65325b90fd
Composition policy takes child instance
...
The composition policy now takes a child instance instead
of the child type, as in all cases we have access to the child
object.
This allows new-style objects to be contained by old-style objects.
Updated all composition policies to use standardized argument names
instead of `context` and `candidate`; this makes it easier to
understand.
Updated AddActionProvider to hardcode the object types supported.
2017-02-21 12:32:49 -08:00
Pete Richards
cfecc36ae6
Orphan check uses capability not model
...
Switch orphan checking to use capability instead of model.
This ensures that new-style composition providers work as intended.
2017-02-21 12:10:17 -08:00
Pete Richards
8e13819e1e
[API] composition providers receive new-style objects
...
Ensure that composition providers get new-style objects (with id
included) so that they can properly check for applicability.
2017-02-21 11:21:08 -08:00
Pete Richards
aaedf5d576
cssclass is now cssClass
...
Make property name consistent with standard camelCase naming.
2017-02-21 11:14:46 -08:00
Charles Hacskaylo
1edd2043dc
[Frontend] WIP Style Guide
...
Fixes #1233
Added new "icon-expand" glyph and class;
(cherry picked from commit adfbfc4
2017-02-16 13:52:59 -08:00
Henry
77d0134e2e
[Build] Added Bourbon deprecation warning suppression system.
2017-02-10 10:03:05 -08:00
