Commit Graph

68 Commits

Author SHA1 Message Date
Victor Woeltjen
b1f8a54dab [Layout] Update specs
Update specs to reflect changes made to the manner in
which a view may persist view configuration changes,
for WTD-535.
2014-12-06 09:45:43 -08:00
Victor Woeltjen
3f41dc716f [Layout] Add commit to scope
Add a commit function to scope from the edit representer;
this avoids issues trying to transparently detect and
persist changes made during edit mode, while still requiring
only minimal action from individual views. WTD-535.
2014-12-06 09:38:36 -08:00
Victor Woeltjen
6de973c11e [Layout] Add JSDoc to new scripts
Add in-line documentation to new scripts introduced to
support the transitioned Layout view, WTD-535.
2014-12-05 18:01:38 -08:00
Victor Woeltjen
ecb4283df0 [Layout] Fill in non-layout specs
Complete specs for scripts introduced in support of
Layout objects/views. WTD-535.
2014-12-05 16:27:32 -08:00
Victor Woeltjen
d3f0505385 [Layout] Fix failing specs
Repair or remove failing specs to reflect changes and
refactoring performed during transition of Layout views,
WTD-535.
2014-12-05 15:48:13 -08:00
Victor Woeltjen
f418491cc4 [Layout] Add empty specs
Add empty specs for new scripts introduced during the
transition of Layout object type and view, WTD-535.
2014-12-05 15:39:07 -08:00
Victor Woeltjen
2ef244edce [Layout] Refer to new scripts from test suites
Add entries for new scripts to test suites, to ensure
tests fail until scripts added to support transition
of Layout object/view (WTD-535) have been completed.
WTD-535.
2014-12-05 15:33:25 -08:00
Victor Woeltjen
a0486495c4 [Layout] Cache reference to body later in mct-drag
Get a reference to the body element at link-time,
instead of instantiation time, from the mct-drag
directive. Failure to do so causes the reference
to fall out of date when switching between Browse
and Edit mode.

Supports position/sizing interactions for Layout
view, WTD-535.
2014-12-05 14:21:10 -08:00
Victor Woeltjen
7080ca585e [Layout] Avoid infinite digest exception
Auto-expand tree nodes on a timeout, instead of immediately.
This is necessary in cases where auto-expansion several
layers deep occurs; if done immediately, each expansion
will trigger a new digest cycle, which at a certain depth
will appear to Angular as unstable.

Done in the context of WTD-535.
2014-12-05 13:31:57 -08:00
Victor Woeltjen
a6de53c118 [Layout] Add auto-save behavior
Add an EditRepresenter which detects changes to domain
object model or view configuration and, when these
occur, triggers mutation and persistence of the domain
object. (Note that in Edit mode, 'persistence' only
flags an object as dirty; actual persistence does not
occur until the user chooses Save.)

This supports editing of position/size in Layout mode,
and the persistence of those changes. WTD-535
2014-12-05 12:48:21 -08:00
Victor Woeltjen
f61eb143e7 [Layout] Restrict Items view to folders
Restrict the Items view to folders, such that it does not
show for Layouts (and, more broadly, for any non-folders.)
WTD-535.
2014-12-05 09:12:35 -08:00
Victor Woeltjen
707641d5b6 [Layout] Trigger digest from mct-drag
Trigger digest using scope. during mct-drag
interactions, to ensure that changes which have
resulted from the drag are applied promptly.
WTD-535.
2014-12-05 08:55:54 -08:00
Victor Woeltjen
b941557b41 [Layout] Fix errors in mct-drag
Properly reset the initial drag position tracked by the
mct-drag position so that multiple drags upon the same
element are correctly offset from an initial position.
Also, preventDefault from events to avoid selection
highlights during drag.

Supports editing Layout objects, for WTD-535.
2014-12-05 08:50:45 -08:00
Victor Woeltjen
479aaa09fb [Layout] Add mct-drag directive
Add an mct-drag directive to support various draggable
things, including frames in a layout. WTD-535.
2014-12-04 14:45:19 -08:00
Victor Woeltjen
7b1c275dee [Layout] Use refactored switcher in Edit
Update templates for Edit mode to reflect
simplifications to the view switcher introduced
to support its use on Layouts, transitioned for
WTD-535.
2014-12-04 12:32:35 -08:00
Victor Woeltjen
2c0574abff [Layout] Update view switcher spec
Update spec for ViewSwitcherController to reflect
refactoring to simplify usage, performed in the
context of transitioning Layouts. WTD-535.
2014-12-04 12:17:43 -08:00
Victor Woeltjen
1b9f9a8db7 [Layout] Move spec for view switcher
Move spec for view switcher from bundle
platform/commonUI/browse to bundle
platform/commonUI/general to reflect refactoring
to simplify usage in other places (including in
Layouts, which are being transitioned for
WTD-535.)
2014-12-04 12:15:22 -08:00
Victor Woeltjen
6cd0cd8e3c [Layout] Refactor view switcher
Refactor view switcher to simplify it; treat it
as a representation of a domain object that modifies
an ng-model. This simplifies reuse, e.g. in frames
within a layout. WTD-535.
2014-12-04 12:12:41 -08:00
Victor Woeltjen
ba14aeabc6 [Forms] Complete specs
Fill in new specs and amend existing specs to ensure
full coverage after integration of forms component,
and associated changes. WTD-593.
2014-12-03 17:59:37 -08:00
Victor Woeltjen
6fb5da1b35 [Forms] Prune obsolete specs
Prune obsolete specs after changes made to support
integration of forms component, WTD-593.
2014-12-03 17:26:02 -08:00
Victor Woeltjen
5aff4e3777 [Forms] Edit Properties specs
Add baseline specs (not yet matched up to current implementation)
for Edit Properties action. WTD-593.
2014-12-03 17:07:01 -08:00
Victor Woeltjen
a8f2de6f5e [Forms] Remove obsolete declaration
Remove obsolete controller declaration (this was triggering
warnings in the console.) WTD-593.
2014-12-03 17:03:06 -08:00
Victor Woeltjen
61cee6d8f8 [Forms] Change CreateWizard method name
Change CreateWizard method name to be consistent
with terms used for form structure elsewhere.
WTD-593.
2014-12-03 17:00:22 -08:00
Victor Woeltjen
bbd0271fc5 [Forms] Add Edit Properties
Add the Edit Properties action, now that Forms are
available to support it. Integration of forms
component, WTD-593.
2014-12-03 16:50:14 -08:00
Victor Woeltjen
3d95c8b744 [Forms] Tie OK button to validation
Enable/disable the confirmation button in overlay dialogs
such that it is only enabled when the included form is
valid. WTD-593.
2014-12-03 14:08:42 -08:00
Victor Woeltjen
1753aa6784 [Forms] Add placeholder spec for Locator
Add placeholder spec for the LocatorController, introduced
to support forms used from the Create menu. Part of ongoing
integration of forms bundle, WTD-593.
2014-12-03 14:04:44 -08:00
Victor Woeltjen
2476941eb2 [Forms] Add Locator control
Add Locator form control, to allow selection of a
destination for newly-created domain objects in a
tree. WTD-593.
2014-12-03 13:51:07 -08:00
Victor Woeltjen
9dd0a54568 [Forms] Initialize model from form value
Correctly initialize domain object model from form
value upon domain object creation. Integration of
forms component, WTD-593.
2014-12-03 13:44:27 -08:00
Victor Woeltjen
e04b9828ea [Forms] Use ng-model for tree state
Use ng-model when communicating state to/from the
tree in browse mode. This will simplify implementation
of the Locator control, which also uses a tree, but
which should not set navigation state. WTD-593.
2014-12-03 13:18:51 -08:00
Victor Woeltjen
80ba6f4da3 [Forms] Reorganize Create templates
Reorganize templates associated with the Create menu in
preparation for adding the Locator control, used to
specify the destination folder for object creation.
WTD-593.
2014-12-03 12:56:53 -08:00
Victor Woeltjen
ccdd1bcd57 [Forms] Adjust Create form formats
Adjust formats used in Create forms to match those used
by the mct-form directive. Integration of forms bundle,
WTD-593.
2014-12-03 12:52:51 -08:00
Victor Woeltjen
d0e29befa6 [Forms] Use forms from DialogService
Use the mct-form when displaying a dialog for user input,
replacing the placeholder textarea used prior to integration
of the forms bundle. WTD-593.
2014-12-03 12:32:00 -08:00
Victor Woeltjen
0bacc03e58 [Common UI] Fix FullscreenActionSpec
Fix FullscreenActionSpec such that it will execute on
command line; the global screenfull dependency behaves
differently during attempts to spy on methods from
the command line build, so replace it entirely.

Concludes work on WTD-574 in preparation to submit for
review.
2014-11-25 23:08:47 -08:00
Victor Woeltjen
b0cb8a8455 [Common UI] Fix Save/Cancel quirk
Fix a defect in the Save/Cancel buttons in Edit mode
that was causing the first click to be missed; this
was due to Angular's inability to detect when a
native promise (as opposed to one from ) had been
resolved.

Since the Editor capability is introduced indirectly
and is a few degrees of separation removed from
the declared extension layer (where we would be able
to get a reference to ), and all we need to do is
make something look Promise-like, a convenience
function to do this is added.

Part of ongoing transition of common user interface
elements, WTD-574.
2014-11-25 22:58:34 -08:00
Victor Woeltjen
52ec1aeb89 [Common UI] Complete remaining specs
Complete remaining specs to achieve full test coverage
for common user interface bundles being transitioned
as part of WTD-574.
2014-11-25 22:48:12 -08:00
Victor Woeltjen
3aa551c4ea [Common UI] Fill in CreationService spec
Fill in specs for CreationService, which supports the
Create action, which, in turn, is included to support
the Create button in Browse mode. Part of the transition
of common user interface elements for WTD-574.
2014-11-25 22:35:30 -08:00
Victor Woeltjen
48ff8c4c03 [Common UI] Continue filling in Browse specs
Continue filling in specs for scripts introduced as part
of bundle platform/commonUI/browse, which is responsible
for browse mode. WTD-574.
2014-11-25 20:26:37 -08:00
Victor Woeltjen
528f6bdf56 [Common UI] Spec for ViewSwitcherController
Fill in spec for the controller which maintains a set of
applicable and selected view options to populate the
view switcher. Part of Browse mode and, in turn, part
of the common user interface elements that are being
transitioned for WTD-574.
2014-11-25 19:46:56 -08:00
Victor Woeltjen
9bc05f27a5 [Common UI] Skeleton specs for Browse
Add skeleton specs for browse mode. WTD-574.
2014-11-25 18:30:30 -08:00
Victor Woeltjen
36fab50825 [Common UI] Add in-line docs for Browse
Add in-line docs for bundle platform/commonUI/browse,
which implements Browse mode, one of the common user
interface bundles being transitioned in WTD-574.
2014-11-25 16:53:22 -08:00
Victor Woeltjen
b97e2d0324 [Common UI] Add JSDoc, remove UUIDService
Add JSDoc to Create-related classes and remove the
UUIDService (replaced by third-party lib) to reduce
amount of code to cover and prepare for code review,
as part of ongoing transition of common user interface
elements, WTD-574.
2014-11-25 16:14:09 -08:00
Victor Woeltjen
242d40fab2 [Common UI] Fill in dialog specs
Fill in specs for bundle platform/commonUI/dialog,
which provides the ability to show dialogs. One
of the common user interface elements being transitioned
for WTD-574.
2014-11-25 15:59:04 -08:00
Victor Woeltjen
f04e02359a [Common UI] Skeleton spec for dialogs
Skeleton specs for bundle platform/commonUI/dialog,
responsible for displaying dialog overlays. Part of
ongoing transition of common user interface elements
for WTD-574.
2014-11-25 14:44:16 -08:00
Victor Woeltjen
0faf4c934e [Common UI] Refactor dialogs
Refactor bundle platform/commonUI/dialog such that
the concerns of showing dialogs (including showing
a single instance thereof) and managing changes to
the DOM are more cleanly separated. This simplifies
testing and satisfies code style guidelines for
this bundle, in preparation for its inclusion among
common user interface bundles to be transitioned
in WTD-574.
2014-11-25 14:39:40 -08:00
Victor Woeltjen
6cce00d601 [Common UI] Add JSDoc to DialogService
Add in-line documentation to the dialog service,
exposed by bundle platform/commonUI/dialog, one
of the common user interface bundles being
transitioned for WTD-574.
2014-11-25 13:31:30 -08:00
Victor Woeltjen
d950fe14e5 [Common UI] Finish JSDoc for edit mode
Complete in-line documentation for bundle
platform/commonUI/edit (Edit Mode), one of the
common user interface bundles being transitioned
for WTD-574.
2014-11-25 12:50:06 -08:00
Victor Woeltjen
4c0e5e963e [Common UI] Add JSDoc for edit actions
Add in-line documentation for actions that are introduced
by the bundle platform/commonUI/edit, which introduces
Edit mode. One of the common user interface bundles being
transitioned for WTD-574.
2014-11-25 11:53:53 -08:00
Victor Woeltjen
c432a4eb1e [Common UI] Complete specs for edit mode
Add specs for remaining capabilities and capability
wrappers employed by Edit mode. Completes coverage
for bundle platform/commonUI/edit, which is being
transitioned along with other commonUI bundles in
WTD-574.
2014-11-25 10:51:23 -08:00
Victor Woeltjen
7ddfcbca9b [Common UI] Fill in spec for RemoveAction
Fill in spec for the Remove action, included as part of
the bundle platform/commonUI/edit. WTD-574.
2014-11-25 10:08:50 -08:00
Victor Woeltjen
19b4dc3fa3 [Common UI] Spec for EditAction
Fill in spec for the Edit action, which enters Edit mode
Part of bundle platform/commonUI/edit, being transitioned
for WTD-574.
2014-11-25 09:48:54 -08:00