Merge pull request #2753 from nasa/remove-ConditionSetView-telemetry

Remove telemetry subscription from conditionSet edit view
This commit is contained in:
David Tsay
2020-03-17 13:49:25 -07:00
committed by GitHub
2 changed files with 5 additions and 9 deletions

View File

@ -121,6 +121,9 @@ export default {
this.conditionCollection = this.domainObject.configuration.conditionCollection; this.conditionCollection = this.domainObject.configuration.conditionCollection;
this.observeForChanges(); this.observeForChanges();
this.conditionManager = new ConditionManager(this.domainObject, this.openmct); this.conditionManager = new ConditionManager(this.domainObject, this.openmct);
this.conditionManager.on('conditionSetResultUpdated', (data) => {
this.$emit('conditionSetResultUpdated', data);
})
}, },
methods: { methods: {
observeForChanges() { observeForChanges() {

View File

@ -34,7 +34,8 @@
</div> </div>
</section> </section>
<TestData :is-editing="isEditing" /> <TestData :is-editing="isEditing" />
<ConditionCollection :is-editing="isEditing" /> <ConditionCollection :is-editing="isEditing"
@conditionSetResultUpdated="updateCurrentOutput" />
</div> </div>
</template> </template>
@ -58,7 +59,6 @@ export default {
}, },
mounted() { mounted() {
this.conditionSetIdentifier = this.openmct.objects.makeKeyString(this.domainObject.identifier); this.conditionSetIdentifier = this.openmct.objects.makeKeyString(this.domainObject.identifier);
this.provideTelemetry();
}, },
beforeDestroy() { beforeDestroy() {
if (this.stopProvidingTelemetry) { if (this.stopProvidingTelemetry) {
@ -68,13 +68,6 @@ export default {
methods: { methods: {
updateCurrentOutput(currentConditionResult) { updateCurrentOutput(currentConditionResult) {
this.currentConditionOutput = currentConditionResult.output; this.currentConditionOutput = currentConditionResult.output;
},
provideTelemetry() {
if (this.stopProvidingTelemetry) {
this.stopProvidingTelemetry();
}
this.stopProvidingTelemetry = this.openmct.telemetry
.subscribe(this.domainObject, output => { this.updateCurrentOutput(output); });
} }
} }
}; };