diff --git a/platform/features/timeline/bundle.js b/platform/features/timeline/bundle.js index 782918e545..ae7a283fc5 100644 --- a/platform/features/timeline/bundle.js +++ b/platform/features/timeline/bundle.js @@ -472,7 +472,6 @@ define([ "implementation": TimelineZoomController, "depends": [ "$scope", - "$timeout", "TIMELINE_ZOOM_CONFIGURATION" ] }, diff --git a/platform/features/timeline/src/controllers/TimelineZoomController.js b/platform/features/timeline/src/controllers/TimelineZoomController.js index 8e1c440ce3..6e97f0bd0e 100644 --- a/platform/features/timeline/src/controllers/TimelineZoomController.js +++ b/platform/features/timeline/src/controllers/TimelineZoomController.js @@ -28,12 +28,11 @@ define( * Controls the pan-zoom state of a timeline view. * @constructor */ - function TimelineZoomController($scope, $timeout, ZOOM_CONFIGURATION) { + function TimelineZoomController($scope, ZOOM_CONFIGURATION) { // Prefer to start with the middle index var zoomLevels = ZOOM_CONFIGURATION.levels || [1000], zoomIndex = Math.floor(zoomLevels.length / 2), tickWidth = ZOOM_CONFIGURATION.width || 200, - width = tickWidth, bounds = { x: 0, width: tickWidth }; // Default duration in view function toMillis(pixels) { @@ -63,12 +62,6 @@ define( zoomIndex += 1; } bounds.x = toPixels(timespan.getStart()); - - // Physical width may be insufficient for scroll; - // if so, try again on a timeout! - if (bounds.x + bounds.width > width) { - $timeout(initializeZoomFromTimespan.bind(null, timespan)); - } } function initializeZoom() { @@ -129,8 +122,7 @@ define( */ width: function (timestamp) { var pixels = Math.ceil(toPixels(timestamp * (1 + PADDING))); - width = Math.max(bounds.width, pixels); - return width; + return Math.max(bounds.width * 2, pixels); } }; } diff --git a/platform/features/timeline/test/controllers/TimelineZoomControllerSpec.js b/platform/features/timeline/test/controllers/TimelineZoomControllerSpec.js index e037c689d4..bf2bc03180 100644 --- a/platform/features/timeline/test/controllers/TimelineZoomControllerSpec.js +++ b/platform/features/timeline/test/controllers/TimelineZoomControllerSpec.js @@ -28,7 +28,6 @@ define( describe("The timeline zoom state controller", function () { var testConfiguration, mockScope, - mockTimeout, controller; beforeEach(function () { @@ -38,10 +37,8 @@ define( }; mockScope = jasmine.createSpyObj("$scope", ['$watch']); mockScope.commit = jasmine.createSpy('commit'); - mockTimeout = jasmine.createSpy('$timeout'); controller = new TimelineZoomController( mockScope, - mockTimeout, testConfiguration ); });