ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-01-19 11:17:04 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

[Representation] Pass ID through dndService

Browse Source 
Pass ID as well as full domain object through dndService,
to support drag-drop behavior like WTD-988.
This commit is contained in:
Victor Woeltjen 2015-03-19 12:39:13 -07:00
parent 818510da14
commit f9290b8e42
3 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
platform/representation/src/gestures/DragGesture.js
View File

@ -45,12 +45,19 @@ define(
domainObject.getId() domainObject.getId()
); );
// Finally, also pass the object instance via the dndService, // Finally, also pass the id object instance via the
// so more than the ID can be retrieved (if desired) // dndService, allowing inspection during drag as well
// as retrieval of the original domain object.
dndService.setData( dndService.setData(
GestureConstants.MCT_DRAG_TYPE, GestureConstants.MCT_EXTENDED_DRAG_TYPE,
domainObject domainObject
); );
dndService.setData(
GestureConstants.MCT_DRAG_TYPE,
domainObject.getId()
);
} catch (err) { } catch (err) {
// Exceptions at this point indicate that the browser // Exceptions at this point indicate that the browser
// do not fully support drag-and-drop (e.g. if // do not fully support drag-and-drop (e.g. if
@ -66,6 +73,7 @@ define(
function endDrag() { function endDrag() {
// Clear the drag data after the drag is complete // Clear the drag data after the drag is complete
dndService.removeData(GestureConstants.MCT_DRAG_TYPE); dndService.removeData(GestureConstants.MCT_DRAG_TYPE);
dndService.removeData(GestureConstants.MCT_EXTENDED_DRAG_TYPE);
} }
// Mark the element as draggable, and handle the dragstart event // Mark the element as draggable, and handle the dragstart event

6
platform/representation/src/gestures/GestureConstants.js
View File

@ -10,6 +10,12 @@ define({
* calls.) * calls.)
*/ */
MCT_DRAG_TYPE: 'mct-domain-object-id', MCT_DRAG_TYPE: 'mct-domain-object-id',
/**
* The string identifier for the data type used for drag-and-drop
* composition of domain objects, by object instance (passed through
* the dndService)
*/
MCT_EXTENDED_DRAG_TYPE: 'mct-domain-object',
/** /**
* An estimate for the dimensions of a context menu, used for * An estimate for the dimensions of a context menu, used for
* positioning. * positioning.

8
platform/representation/test/gestures/DragGestureSpec.js
View File

@ -65,6 +65,10 @@ define(
handlers.dragstart({ dataTransfer: mockDataTransfer }); handlers.dragstart({ dataTransfer: mockDataTransfer });
expect(mockDndService.setData).toHaveBeenCalledWith( expect(mockDndService.setData).toHaveBeenCalledWith(
GestureConstants.MCT_DRAG_TYPE, GestureConstants.MCT_DRAG_TYPE,
TEST_ID
);
expect(mockDndService.setData).toHaveBeenCalledWith(
GestureConstants.MCT_EXTENDED_DRAG_TYPE,
mockDomainObject mockDomainObject
); );
}); });
@ -78,8 +82,12 @@ define(
// End the drag // End the drag
handlers.dragend({ dataTransfer: mockDataTransfer }); handlers.dragend({ dataTransfer: mockDataTransfer });
// Should have removed the data that was attached
expect(mockDndService.removeData) expect(mockDndService.removeData)
.toHaveBeenCalledWith(GestureConstants.MCT_DRAG_TYPE); .toHaveBeenCalledWith(GestureConstants.MCT_DRAG_TYPE);
expect(mockDndService.removeData)
.toHaveBeenCalledWith(GestureConstants.MCT_EXTENDED_DRAG_TYPE);
}); });
it("logs a warning if dataTransfer cannot be set", function () { it("logs a warning if dataTransfer cannot be set", function () {