ESLint rules: array-callback-return, no-invalid-this, func-style (#3151)

* satisfied array-callback-return rule
* satisfying no-invalid-this rule
* fixed invalid-this issues
* changed isNotEqual to arrow function
* added rule func-style
* added return false to satisfy array-callback-return rule

Co-authored-by: Joel McKinnon <jmckinnon@apple.com>
Co-authored-by: Joshi <simplyrender@gmail.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
This commit is contained in:
Joel McKinnon
2020-08-10 10:59:18 -07:00
committed by GitHub
parent 0b4a843617
commit ef965ebdfd
49 changed files with 262 additions and 246 deletions

View File

@ -31,16 +31,16 @@ define(['../../src/input/ObjectSelect'], function (ObjectSelect) {
'getComposition'
]);
mockManager.on.and.callFake(function (event, callback) {
this.callbacks = this.callbacks || {};
this.callbacks[event] = callback;
mockManager.on.and.callFake((event, callback) => {
mockManager.callbacks = mockManager.callbacks || {};
mockManager.callbacks[event] = callback;
});
mockManager.triggerCallback.and.callFake(function (event, newObj) {
mockManager.triggerCallback.and.callFake((event, newObj) => {
if (event === 'add') {
this.callbacks.add(newObj);
mockManager.callbacks.add(newObj);
} else {
this.callbacks[event]();
mockManager.callbacks[event]();
}
});