ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2024-12-19 05:07:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #949 from nasa/info-error-948

Browse Source 
[Mobile] Remove usage of element.scope()
This commit is contained in:
Andrew Henry 2016-05-25 15:15:53 -07:00
commit eefd4c8669
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
platform/commonUI/inspect/src/gestures/InfoButtonGesture.js
View File

@ -38,7 +38,6 @@ define(
function InfoGestureButton($document, agentService, infoService, element, domainObject) { function InfoGestureButton($document, agentService, infoService, element, domainObject) {
var dismissBubble, var dismissBubble,
touchPosition, touchPosition,
scopeOff,
body = $document.find('body'); body = $document.find('body');
function trackPosition(event) { function trackPosition(event) {
@ -94,10 +93,6 @@ define(
element.on('click', showBubble); element.on('click', showBubble);
} }
// Also make sure we dismiss bubble if representation is destroyed
// before the mouse actually leaves it
scopeOff = element.scope().$on('$destroy', hideBubble);
return { return {
/** /**
* Detach any event handlers associated with this gesture. * Detach any event handlers associated with this gesture.
@ -109,7 +104,6 @@ define(
hideBubble(); hideBubble();
// ...and detach listeners // ...and detach listeners
element.off('click', showBubble); element.off('click', showBubble);
scopeOff();
} }
}; };
} }

5
platform/commonUI/inspect/test/gestures/InfoButtonGestureSpec.js
View File

@ -137,6 +137,11 @@ define(
); );
}); });
// https://github.com/nasa/openmct/issues/948
it("does not try to access scope", function () {
expect(mockElement.scope).not.toHaveBeenCalled();
});
}); });
} }
); );