mirror of
https://github.com/nasa/openmct.git
synced 2024-12-18 20:57:53 +00:00
Use the disabled attribute on a valid element - the button. (#7914)
* Use the disabled attribute on a valid tag - the button. * Add e2e test to check for add criteria button being enabled * Improve test * Check for add criteria button to have attribute disabled * Remove focused test
This commit is contained in:
parent
2010f2e377
commit
ea9947cab5
@ -287,6 +287,41 @@ test.describe('Basic Condition Set Use', () => {
|
|||||||
description: 'https://github.com/nasa/openmct/issues/7484'
|
description: 'https://github.com/nasa/openmct/issues/7484'
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('ConditionSet has add criteria button enabled/disabled when composition is and is not available', async ({
|
||||||
|
page
|
||||||
|
}) => {
|
||||||
|
const exampleTelemetry = await createExampleTelemetryObject(page);
|
||||||
|
|
||||||
|
await page.getByLabel('Show selected item in tree').click();
|
||||||
|
await page.goto(conditionSet.url);
|
||||||
|
// Change the object to edit mode
|
||||||
|
await page.getByLabel('Edit Object').click();
|
||||||
|
|
||||||
|
// Create a condition
|
||||||
|
await page.locator('#addCondition').click();
|
||||||
|
await page.locator('#conditionCollection').getByRole('textbox').nth(0).fill('First Condition');
|
||||||
|
|
||||||
|
// Validate that the add criteria button is disabled
|
||||||
|
await expect(page.getByLabel('Add Criteria - Disabled')).toHaveAttribute('disabled');
|
||||||
|
|
||||||
|
// Add Telemetry to ConditionSet
|
||||||
|
const sineWaveGeneratorTreeItem = page
|
||||||
|
.getByRole('tree', {
|
||||||
|
name: 'Main Tree'
|
||||||
|
})
|
||||||
|
.getByRole('treeitem', {
|
||||||
|
name: exampleTelemetry.name
|
||||||
|
});
|
||||||
|
const conditionCollection = page.locator('#conditionCollection');
|
||||||
|
await sineWaveGeneratorTreeItem.dragTo(conditionCollection);
|
||||||
|
|
||||||
|
// Validate that the add criteria button is enabled and adds a new criterion
|
||||||
|
await expect(page.getByLabel('Add Criteria - Enabled')).not.toHaveAttribute('disabled');
|
||||||
|
await page.getByLabel('Add Criteria - Enabled').click();
|
||||||
|
const numOfUnnamedCriteria = await page.getByLabel('Criterion Telemetry Selection').count();
|
||||||
|
expect(numOfUnnamedCriteria).toEqual(2);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
test.describe('Condition Set Composition', () => {
|
test.describe('Condition Set Composition', () => {
|
||||||
|
@ -160,8 +160,10 @@
|
|||||||
</div>
|
</div>
|
||||||
</template>
|
</template>
|
||||||
<div class="c-cdef__separator c-row-separator"></div>
|
<div class="c-cdef__separator c-row-separator"></div>
|
||||||
<div class="c-cdef__controls" :disabled="!telemetry.length">
|
<div class="c-cdef__controls">
|
||||||
<button
|
<button
|
||||||
|
:disabled="!telemetry.length"
|
||||||
|
:aria-label="`Add Criteria - ${!telemetry.length ? 'Disabled' : 'Enabled'}`"
|
||||||
class="c-cdef__add-criteria-button c-button c-button--labeled icon-plus"
|
class="c-cdef__add-criteria-button c-button c-button--labeled icon-plus"
|
||||||
@click="addCriteria"
|
@click="addCriteria"
|
||||||
>
|
>
|
||||||
|
Loading…
Reference in New Issue
Block a user