ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-22 17:08:57 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

[Telemetry Tables] Don't mutate configuration if object is not able to be persisted (#7626)

Browse Source 
* source maps

* do not persist if obj is not persistable

* nope

* prevent mutation of configuration

* static roots are read only by nature

* helps to use functions correctly

* update persistModeChange logic

* remove debug

* remove unnecessary change
This commit is contained in:
Jamie V
2024-04-03 17:38:59 -07:00
committed by GitHub
parent 311ad0b87a
commit de3dad02b5
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/telemetryTable/TelemetryTableConfiguration.js
View File

@ -40,6 +40,8 @@ export default class TelemetryTableConfiguration extends EventEmitter {
'configuration', 'configuration',
this.objectMutated this.objectMutated
); );
this.notPersistable = !this.openmct.objects.isPersistable(this.domainObject.identifier);
} }
getConfiguration() { getConfiguration() {
@ -52,14 +54,19 @@ export default class TelemetryTableConfiguration extends EventEmitter {
// anything that doesn't have a telemetryMode existed before the change and should // anything that doesn't have a telemetryMode existed before the change and should
// take the properties of any passed in defaults or the defaults from the plugin // take the properties of any passed in defaults or the defaults from the plugin
configuration.telemetryMode = configuration.telemetryMode ?? this.defaultOptions.telemetryMode; configuration.telemetryMode = configuration.telemetryMode ?? this.defaultOptions.telemetryMode;
configuration.persistModeChange = configuration.persistModeChange = this.notPersistable
configuration.persistModeChange ?? this.defaultOptions.persistModeChange; ? false
: configuration.persistModeChange ?? this.defaultOptions.persistModeChange;
configuration.rowLimit = configuration.rowLimit ?? this.defaultOptions.rowLimit; configuration.rowLimit = configuration.rowLimit ?? this.defaultOptions.rowLimit;
return configuration; return configuration;
} }
updateConfiguration(configuration) { updateConfiguration(configuration) {
if (this.notPersistable) {
return;
}
this.openmct.objects.mutate(this.domainObject, 'configuration', configuration); this.openmct.objects.mutate(this.domainObject, 'configuration', configuration);
} }