[Build] Remove unused variables from specs

...to satisfy JSHint.

platform/commonUI/browse/test/creation/CreationServiceSpec.js

@@ -147,8 +147,7 @@ define(
             });
 
             it("adds new objects to the parent's composition", function () {
-                var model = { someKey: "some value" },
+                var model = { someKey: "some value" };
-                    parentModel = { composition: ["notAnyUUID"] };
                 creationService.createObject(model, mockParentObject);
 
                 // Verify that a new ID was added
@@ -199,8 +198,7 @@ define(
             it("logs an error when mutaton fails", function () {
                 // If mutation of the parent fails, we've lost the
                 // created object - this is an error.
-                var model = { someKey: "some value" },
+                var model = { someKey: "some value" };
-                    parentModel = { composition: ["notAnyUUID"] };
 
                 mockCompositionCapability.add.andReturn(mockPromise(false));
 

platform/commonUI/browse/test/navigation/NavigateActionSpec.js

@@ -30,7 +30,6 @@ define(
         describe("The navigate action", function () {
             var mockNavigationService,
                 mockQ,
-                actionContext,
                 mockDomainObject,
                 action;
 

platform/commonUI/browse/test/windowing/NewTabActionSpec.js

@@ -28,7 +28,6 @@ define(
             var actionSelected,
                 actionCurrent,
                 mockWindow,
-                mockDomainObject,
                 mockContextCurrent,
                 mockContextSelected,
                 mockUrlService;

platform/commonUI/edit/test/actions/PropertiesDialogSpec.js

@@ -26,7 +26,7 @@ define(
 
         describe("Properties dialog", function () {
 
-            var type, properties, domainObject, model, dialog;
+            var type, properties, model, dialog;
 
             beforeEach(function () {
                 type = {

platform/commonUI/edit/test/controllers/EditControllerSpec.js

@@ -93,8 +93,7 @@ define(
             });
 
             it("exposes a warning message for unload", function () {
-                var obj = mockObject,
+                var errorMessage = "Unsaved changes";
-                    errorMessage = "Unsaved changes";
 
                 // Normally, should be undefined
                 expect(controller.getUnloadWarning()).toBeUndefined();

platform/commonUI/edit/test/objects/EditableDomainObjectCacheSpec.js

@@ -28,7 +28,6 @@ define(
 
             var captured,
                 completionCapability,
-                object,
                 mockQ,
                 mockType,
                 cache;
@@ -45,7 +44,7 @@ define(
                             type: mockType
                         }[key];
                     },
-                    hasCapability: function (key) {
+                    hasCapability: function () {
                         return false;
                     }
                 };

platform/commonUI/edit/test/objects/EditableDomainObjectSpec.js

@@ -25,7 +25,11 @@ define(
     function (EditableDomainObject) {
 
         describe("Editable domain object", function () {
+            var object;
 
+            beforeEach(function () {
+                object = new EditableDomainObject();
+            });
         });
     }
 );

platform/commonUI/edit/test/policies/EditableViewPolicySpec.js

@@ -25,8 +25,7 @@ define(
     function (EditableViewPolicy) {
 
         describe("The editable view policy", function () {
-            var testView,
+            var mockDomainObject,
-                mockDomainObject,
                 testMode,
                 policy;
 

platform/commonUI/edit/test/representers/EditToolbarSpec.js

@@ -147,7 +147,7 @@ define(
             });
 
             it("invokes setters on update", function () {
-                var structure, state;
+                var structure;
 
                 testABC.a = jasmine.createSpy('a');
 

platform/commonUI/formats/test/FormatProviderSpec.js

@@ -28,7 +28,6 @@ define(
 
         describe("The FormatProvider", function () {
             var mockFormats,
-                mockLog,
                 mockFormatInstances,
                 provider;
 

platform/commonUI/general/test/directives/MCTPopupSpec.js

@@ -40,14 +40,6 @@ define(
                 testRect,
                 mctPopup;
 
-            function testEvent(x, y) {
-                return {
-                    pageX: x,
-                    pageY: y,
-                    preventDefault: jasmine.createSpy("preventDefault")
-                };
-            }
-
             beforeEach(function () {
                 mockCompile =
                     jasmine.createSpy("$compile");

platform/commonUI/inspect/test/services/InfoServiceSpec.js

@@ -21,8 +21,8 @@
  *****************************************************************************/
 
 define(
-    ['../../src/services/InfoService', '../../src/InfoConstants'],
+    ['../../src/services/InfoService'],
-    function (InfoService, InfoConstants) {
+    function (InfoService) {
 
         describe("The info service", function () {
             var mockCompile,

platform/commonUI/notification/test/NotificationIndicatorControllerSpec.js

@@ -27,7 +27,8 @@ define(
         describe("The notification indicator controller ", function () {
             var mockNotificationService,
                 mockScope,
-                mockDialogService;
+                mockDialogService,
+                controller;
 
             beforeEach(function(){
                 mockNotificationService = jasmine.createSpy("notificationService");
@@ -36,19 +37,18 @@ define(
                     "dialogService",
                     ["getDialogResponse","dismiss"]
                 );
-            });
-
-            it("exposes the highest notification severity to the template", function() {
                 mockNotificationService.highest = {
                     severity: "error"
                 };
-                var controller = new NotificationIndicatorController(mockScope, mockNotificationService, mockDialogService);
+                controller = new NotificationIndicatorController(mockScope, mockNotificationService, mockDialogService);
+            });
+
+            it("exposes the highest notification severity to the template", function() {
                 expect(mockScope.highest).toBeTruthy();
                 expect(mockScope.highest.severity).toBe("error");
             });
 
             it("invokes the dialog service to show list of messages", function() {
-                var controller = new NotificationIndicatorController(mockScope, mockNotificationService, mockDialogService);
                 expect(mockScope.showNotificationsList).toBeDefined();
                 mockScope.showNotificationsList();
                 expect(mockDialogService.getDialogResponse).toHaveBeenCalled();
@@ -61,7 +61,6 @@ define(
             });
 
             it("provides a means of dismissing the message list", function() {
-                var controller = new NotificationIndicatorController(mockScope, mockNotificationService, mockDialogService);
                 expect(mockScope.showNotificationsList).toBeDefined();
                 mockScope.showNotificationsList();
                 expect(mockDialogService.getDialogResponse).toHaveBeenCalled();

platform/containment/test/CapabilityTableSpec.js

@@ -39,7 +39,7 @@ define(
                     [ 'getCapabilities' ]
                 );
                 // Both types can only contain b, let's say
-                mockTypes = ['a', 'b'].map(function (type, index) {
+                mockTypes = ['a', 'b'].map(function (type) {
                     var mockType = jasmine.createSpyObj(
                         'type-' + type,
                         ['getKey', 'getDefinition', 'getInitialModel']

platform/core/test/capabilities/MutationCapabilitySpec.js

@@ -60,7 +60,7 @@ define(
             });
 
             it("allows setting a model", function () {
-                mutation.invoke(function (m) {
+                mutation.invoke(function () {
                     return { someKey: "some value" };
                 });
                 expect(testModel.number).toBeUndefined();

platform/core/test/capabilities/RelationshipCapabilitySpec.js

@@ -106,8 +106,6 @@ define(
             it("avoids redundant requests", function () {
                 // Lookups can be expensive, so this capability
                 // should have some self-caching
-                var response;
-
                 mockDomainObject.getModel
                     .andReturn({ relationships: { xyz: ['a'] } });
 
@@ -123,7 +121,7 @@ define(
             it("makes new requests on modification", function () {
                 // Lookups can be expensive, so this capability
                 // should have some self-caching
-                var response, testModel;
+                var testModel;
 
                 testModel = { relationships: { xyz: ['a'] } };
 

platform/core/test/identifiers/IdentifierSpec.js

@@ -34,7 +34,7 @@ define(
             });
 
             describe("when space is encoded", function () {
-                var idSpace, idKey, spacedId;
+                var idSpace, idKey;
 
                 beforeEach(function () {
                     idSpace = "a-specific-space";

platform/core/test/objects/DomainObjectProviderSpec.js

@@ -46,12 +46,6 @@ define(
                 };
             }
 
-            function mockAll(mockPromises) {
-                return mockPromise(mockPromises.map(function (p) {
-                    return mockPromise(p).testValue;
-                }));
-            }
-
             beforeEach(function () {
                 mockModelService = jasmine.createSpyObj(
                     "modelService",

platform/core/test/services/InstantiateSpec.js

@@ -30,8 +30,6 @@ define(
                 mockIdentifierService,
                 mockCapabilityConstructor,
                 mockCapabilityInstance,
-                mockCapabilities,
-                mockIdentifier,
                 idCounter,
                 testModel,
                 instantiate,

platform/core/test/types/TypeProviderSpec.js

@@ -26,13 +26,7 @@ define(
 
         describe("Type provider", function () {
 
-            var captured = {},
+            var testTypeDefinitions = [
-                capture = function (name) {
-                    return function (value) {
-                        captured[name] = value;
-                    };
-                },
-                testTypeDefinitions = [
                     {
                         key: 'basic',
                         glyph: "X",

platform/core/test/views/ViewProviderSpec.js

@@ -133,8 +133,7 @@ define(
             });
 
             it("enforces view restrictions from types", function () {
-                var testType = "testType",
+                var testView = { key: "x" },
-                    testView = { key: "x" },
                     provider = new ViewProvider([testView], mockLog);
 
                 // Include a "type" capability

platform/entanglement/test/actions/SetPrimaryLocationActionSpec.js

@@ -32,8 +32,7 @@ define(
             var testContext,
                 testModel,
                 testId,
-                mockLocationCapability,
+                mockLocationCapability;
-                mockContextCapability;
 
             beforeEach(function () {
                 testId = "some-id";

platform/entanglement/test/services/CopyServiceSpec.js

@@ -124,10 +124,8 @@ define(
 
                 var mockQ,
                     mockDeferred,
-                    creationService,
                     createObjectPromise,
                     copyService,
-                    mockNow,
                     object,
                     newParent,
                     copyResult,
@@ -172,7 +170,7 @@ define(
                         'mockDeferred',
                         ['notify', 'resolve', 'reject']
                     );
-                    mockDeferred.notify.andCallFake(function(notification){});
+                    mockDeferred.notify.andCallFake(function(){});
                     mockDeferred.resolve.andCallFake(function(value){resolvedValue = value;});
                     mockDeferred.promise = {
                         then: function(callback){
@@ -271,8 +269,7 @@ define(
                 });
 
                 describe("on domainObject with composition", function () {
-                    var newObject,
+                    var childObject,
-                        childObject,
                         objectClone,
                         childObjectClone,
                         compositionPromise;

platform/entanglement/test/services/CopyTaskSpec.js

@@ -187,8 +187,7 @@ define(
 
             describe("copies object trees with multiple references to the" +
                 " same object", function () {
-                var model,
+                var mockDomainObjectB,
-                    mockDomainObjectB,
                     mockComposingObject,
                     composingObjectModel,
                     domainObjectClone,
@@ -252,9 +251,7 @@ define(
                 it(" and correctly updates child identifiers in object" +
                     " arrays within models ", function () {
                     var childA_ID = task.clones[0].getId(),
-                        childB_ID = task.clones[1].getId(),
+                        childB_ID = task.clones[1].getId();
-                        childC_ID = task.clones[3].getId(),
-                        childD_ID = task.clones[4].getId();
 
                     expect(domainObjectClone.model.objArr[0].id).not.toBe(ID_A);
                     expect(domainObjectClone.model.objArr[0].id).toBe(childA_ID);

platform/features/clock/test/controllers/ClockControllerSpec.js

@@ -31,7 +31,6 @@ define(
             var mockScope,
                 mockTicker,
                 mockUnticker,
-                mockDomainObject,
                 controller;
 
             beforeEach(function () {

platform/features/clock/test/controllers/TimerFormatterSpec.js

@@ -45,10 +45,6 @@ define(
                 ].reduce(sum, 0);
             }
 
-            function twoDigits(n) {
-                return n < 10 ? ('0' + n) : n;
-            }
-
             it("formats short-form values (no days)", function () {
                 expect(formatter.short(toDuration(0, 123, 2, 3) + 123))
                     .toEqual("123:02:03");

platform/features/conductor/test/ConductorTelemetryDecoratorSpec.js

@@ -33,16 +33,6 @@ define(
                 mockSeries,
                 decorator;
 
-            function seriesIsInWindow(series) {
-                var i, v, inWindow = true;
-                for (i = 0; i < series.getPointCount(); i += 1) {
-                    v = series.getDomainValue(i);
-                    inWindow = inWindow && (v >= mockConductor.displayStart());
-                    inWindow = inWindow && (v <= mockConductor.displayEnd());
-                }
-                return inWindow;
-            }
-
             beforeEach(function () {
                 mockTelemetryService = jasmine.createSpyObj(
                     'telemetryService',

platform/features/events/test/policies/MessagesViewPolicySpec.js

@@ -30,7 +30,6 @@ define(
         describe("The messages view policy", function () {
             var mockDomainObject,
                 mockTelemetry,
-                telemetryType,
                 testType,
                 testView,
                 testMetadata,
@@ -50,7 +49,7 @@ define(
                     ['getMetadata']
                 );
                 
-                mockDomainObject.getModel.andCallFake(function (c) {
+                mockDomainObject.getModel.andCallFake(function () {
                     return {type: testType};
                 });
                 mockDomainObject.getCapability.andCallFake(function (c) {

platform/features/layout/test/LayoutControllerSpec.js

@@ -235,7 +235,7 @@ define(
             });
 
             it("ensures a minimum frame size", function () {
-                var styleB, styleC;
+                var styleB;
 
                 // Start with a very small frame size
                 testModel.layoutGrid = [ 1, 1 ];

platform/features/plot/test/PlotOptionsControllerSpec.js

@@ -32,7 +32,6 @@ define(
                 mockCompositionCapability,
                 mockComposition,
                 mockUnlisten,
-                mockFormUnlisten,
                 mockChildOne,
                 mockChildTwo,
                 model,

platform/features/plot/test/PlotOptionsFormSpec.js

@@ -25,8 +25,7 @@ define(
     function (PlotOptionsForm) {
 
         describe("The Plot Options form", function () {
-            var plotOptionsForm,
+            var plotOptionsForm;
-                listener;
 
             beforeEach(function () {
 

platform/features/plot/test/elements/PlotLimitTrackerSpec.js

@@ -29,7 +29,6 @@ define(
                 testRange,
                 mockTelemetryObjects,
                 testData,
-                mockLimitCapabilities,
                 tracker;
 
             beforeEach(function () {

platform/features/plot/test/elements/PlotPreparerSpec.js

@@ -61,6 +61,8 @@ define(
                 var datas = [makeMockData(1)],
                     preparer = new PlotPreparer(datas, "testDomain", "testRange");
 
+                expect(preparer).toBeDefined();
+
                 expect(datas[0].getDomainValue).toHaveBeenCalledWith(
                     jasmine.any(Number),
                     "testDomain"

platform/features/plot/test/modes/PlotOverlayModeSpec.js

@@ -30,20 +30,11 @@ define(
         describe("Overlaid plot mode", function () {
             var mockDomainObject,
                 mockSubPlotFactory,
-                mockSubPlot,
                 mockPrepared,
                 testBuffers,
                 testDrawingObjects,
                 mode;
 
-            function mockElement(x, y, w, h) {
-                return {
-                    getBoundingClientRect: function () {
-                        return { left: x, top: y, width: w, height: h };
-                    }
-                };
-            }
-
             function createMockSubPlot() {
                 var mockSubPlot = jasmine.createSpyObj(
                         "subPlot",
@@ -127,7 +118,7 @@ define(
                 mode.plotTelemetry(mockPrepared);
 
                 // Should have one sub-plot with three lines
-                testDrawingObjects.forEach(function (testDrawingObject, i) {
+                testDrawingObjects.forEach(function (testDrawingObject) {
                     // Either empty list or undefined is fine;
                     // just want to make sure there are no lines.
                     expect(testDrawingObject.lines.length)
@@ -178,7 +169,7 @@ define(
                 });
 
                 // Step back the same number of zoom changes
-                mockSubPlotFactory.createSubPlot.calls.forEach(function (c) {
+                mockSubPlotFactory.createSubPlot.calls.forEach(function () {
                     // Should still be zoomed at start of each iteration
                     expect(mode.isZoomed()).toBeTruthy();
                     // Step back one of the zoom changes.

platform/features/plot/test/modes/PlotStackModeSpec.js

@@ -30,20 +30,11 @@ define(
         describe("Stacked plot mode", function () {
             var mockDomainObject,
                 mockSubPlotFactory,
-                mockSubPlot,
                 mockPrepared,
                 testBuffers,
                 testDrawingObjects,
                 mode;
 
-            function mockElement(x, y, w, h) {
-                return {
-                    getBoundingClientRect: function () {
-                        return { left: x, top: y, width: w, height: h };
-                    }
-                };
-            }
-
             function createMockSubPlot() {
                 var mockSubPlot = jasmine.createSpyObj(
                         "subPlot",
@@ -172,7 +163,7 @@ define(
                 });
 
                 // Step back the same number of zoom changes
-                mockSubPlotFactory.createSubPlot.calls.forEach(function (c) {
+                mockSubPlotFactory.createSubPlot.calls.forEach(function () {
                     // Should still be zoomed at start of each iteration
                     expect(mode.isZoomed()).toBeTruthy();
                     // Step back

platform/features/table/test/controllers/MCTTableControllerSpec.js

@@ -34,14 +34,6 @@ define(
                 mockTimeout,
                 mockElement;
 
-            function promise(value) {
-                return {
-                    then: function (callback){
-                        return promise(callback(value));
-                    }
-                };
-            }
-
             beforeEach(function() {
                 watches = {};
 

platform/features/table/test/controllers/TableOptionsControllerSpec.js

@@ -32,14 +32,6 @@ define(
                 controller,
                 mockScope;
 
-            function promise(value) {
-                return {
-                    then: function (callback){
-                        return promise(callback(value));
-                    }
-                };
-            }
-
             beforeEach(function() {
                 mockCapability = jasmine.createSpyObj('mutationCapability', [
                     'listen'

platform/features/table/test/controllers/TelemetryTableControllerSpec.js

@@ -130,8 +130,6 @@ define(
 
                 it('to create column configuration, which is written to the' +
                     ' object model', function() {
-                    var mockModel = {};
-
                     controller.setup();
                     expect(mockTable.getColumnConfiguration).toHaveBeenCalled();
                     expect(mockTable.saveColumnConfiguration).toHaveBeenCalled();

platform/features/timeline/test/directives/MCTSwimlaneDropSpec.js

@@ -33,7 +33,6 @@ define(
                 mockElement,
                 testAttrs,
                 mockSwimlane,
-                mockRealElement,
                 testEvent,
                 handlers,
                 directive;

platform/forms/test/MCTFormSpec.js

@@ -29,8 +29,7 @@ define(
                 mctForm;
 
             function installController() {
-                var controllerProperty = mctForm.controller,
+                var Controller = mctForm.controller[1];
-                    Controller = mctForm.controller[1];
                 return new Controller(mockScope);
             }
 

platform/identity/test/IdentityAggregatorSpec.js

@@ -28,7 +28,6 @@ define(
             var mockProviders,
                 mockQ,
                 resolves,
-                mockPromise,
                 mockCallback,
                 testUsers,
                 aggregator;

platform/persistence/queue/test/PersistenceFailureHandlerSpec.js

@@ -104,7 +104,7 @@ define(
                 // User chooses overwrite
                 mockPromise.then.mostRecentCall.args[0](false);
                 // Should refresh, but not remutate, and requeue all objects
-                mockFailures.forEach(function (mockFailure, i) {
+                mockFailures.forEach(function (mockFailure) {
                     expect(mockFailure.persistence.refresh).toHaveBeenCalled();
                     expect(mockFailure.requeue).not.toHaveBeenCalled();
                     expect(mockFailure.domainObject.useCapability).not.toHaveBeenCalled();

platform/policy/test/PolicyActionDecoratorSpec.js

@@ -86,7 +86,7 @@ define(
 
             it("filters out policy-disallowed actions", function () {
                 // Disallow the second action
-                mockPolicyService.allow.andCallFake(function (cat, candidate, ctxt) {
+                mockPolicyService.allow.andCallFake(function (cat, candidate) {
                     return candidate.someKey !== 'b';
                 });
                 expect(decorator.getActions(testContext))

platform/policy/test/PolicyViewDecoratorSpec.js

@@ -90,7 +90,7 @@ define(
 
             it("filters out policy-disallowed views", function () {
                 // Disallow the second action
-                mockPolicyService.allow.andCallFake(function (cat, candidate, ctxt) {
+                mockPolicyService.allow.andCallFake(function (cat, candidate) {
                     return candidate.someKey !== 'b';
                 });
                 expect(decorator.getViews(mockDomainObject))

platform/representation/test/actions/ContextMenuActionSpec.js

@@ -25,12 +25,11 @@
  * Module defining ContextMenuActionSpec. Created by shale on 07/02/2015.
  */
 define(
-    ["../../src/actions/ContextMenuAction", "../../src/gestures/GestureConstants"],
+    ["../../src/actions/ContextMenuAction"],
-    function (ContextMenuAction, GestureConstants) {
+    function (ContextMenuAction) {
 
         var JQLITE_FUNCTIONS = [ "on", "off", "find", "append", "remove" ],
-            DOMAIN_OBJECT_METHODS = [ "getId", "getModel", "getCapability", "hasCapability", "useCapability" ],
+            DOMAIN_OBJECT_METHODS = [ "getId", "getModel", "getCapability", "hasCapability", "useCapability" ];
-            MENU_DIMENSIONS = GestureConstants.MCT_MENU_DIMENSIONS;
 
 
         describe("The 'context menu' action", function () {

platform/representation/test/gestures/GestureRepresenterSpec.js

@@ -27,7 +27,6 @@ define(
         describe("A gesture representer", function () {
             var mockGestureService,
                 mockGestureHandle,
-                mockScope,
                 mockElement,
                 representer;
 

platform/search/test/controllers/SearchMenuControllerSpec.js

@@ -29,7 +29,6 @@ define(
 
         describe("The search menu controller", function () {
             var mockScope,
-                mockPromise,
                 mockTypes,
                 controller;
             

platform/telemetry/test/TelemetryDelegatorSpec.js

@@ -25,7 +25,11 @@ define(
     function (TelemetryDelegator) {
 
         describe("The telemetry delegator", function () {
+            var delegator;
 
+            beforeEach(function () {
+                delegator = new TelemetryDelegator();
+            });
         });
     }
 );