[Telemetry] Add JSDoc

Add in-line documentation to scripts and methods that
were changed/introduced to support telemetry subscriptions,
which in turn were introduced to support autoflow
tabular views, WTD-614.

platform/telemetry/src/TelemetryAggregator.js

@@ -65,6 +65,21 @@ define(
                  *          availability) satisfy the requests
                  */
                 requestTelemetry: requestTelemetry,
+                /**
+                 * Subscribe to streaming updates to telemetry data.
+                 * The provided callback will be invoked as new
+                 * telemetry becomes available; as an argument, it
+                 * will receive an object of key-value pairs, where
+                 * keys are source identifiers and values are objects
+                 * of key-value pairs, where keys are point identifiers
+                 * and values are TelemetrySeries objects containing
+                 * the latest streaming telemetry.
+                 * @param {Function} callback the callback to invoke
+                 * @param {TelemetryRequest[]} requests an array of
+                 *        requests to be subscribed upon
+                 * @returns {Function} a function which can be called
+                 *        to unsubscribe
+                 */
                 subscribe: subscribe
             };
         }

platform/telemetry/src/TelemetrySubscriber.js

@@ -5,8 +5,39 @@ define(
     function (TelemetrySubscription) {
         "use strict";
 
+        /**
+         * The TelemetrySubscriber is a service which allows
+         * subscriptions to be made for new data associated with
+         * domain objects. It is exposed as a service named
+         * `telemetrySubscriber`.
+         *
+         * Subscriptions may also be made directly using the
+         * `telemetry` capability of a domain objcet; the subscriber
+         * uses this as well, but additionally handles delegation
+         * (e.g. for telemetry panels) as well as latest-value
+         * extraction.
+         *
+         * @constructor
+         * @param $q Angular's $q
+         * @param $timeout Angular's $timeout
+         */
         function TelemetrySubscriber($q, $timeout) {
             return {
+                /**
+                 * Subscribe to streaming telemetry updates
+                 * associated with this domain object (either
+                 * directly or via capability delegation.)
+                 *
+                 * @param {DomainObject} domainObject the object whose
+                 *        associated telemetry data is of interest
+                 * @param {Function} callback a function to invoke
+                 *        when new data has become available.
+                 * @returns {TelemetrySubscription} the subscription,
+                 *        which will provide access to latest values.
+                 *
+                 * @method
+                 * @memberof TelemetrySubscriber
+                 */
                 subscribe: function (domainObject, callback) {
                     return new TelemetrySubscription(
                         $q,

platform/telemetry/src/TelemetrySubscription.js

@@ -5,6 +5,27 @@ define(
     function () {
         "use strict";
 
+
+        /**
+         * A TelemetrySubscription tracks latest values for streaming
+         * telemetry data and handles notifying interested observers.
+         * It implements the interesting behavior behind the
+         * `telemetrySubscriber` service.
+         *
+         * Subscriptions may also be made directly using the
+         * `telemetry` capability of a domain objcet; the subscriber
+         * uses this as well, but additionally handles delegation
+         * (e.g. for telemetry panels) as well as latest-value
+         * extraction.
+         *
+         * @constructor
+         * @param $q Angular's $q
+         * @param $timeout Angular's $timeout
+         * @param {DomainObject} domainObject the object whose
+         *        associated telemetry data is of interest
+         * @param {Function} callback a function to invoke
+         *        when new data has become available.
+         */
         function TelemetrySubscription($q, $timeout, domainObject, callback) {
             var unsubscribePromise,
                 latestValues = {},
@@ -34,19 +55,29 @@ define(
                 });
             }
 
-            function fireCallback(values) {
+            // Invoke the observer callback to notify that new streaming
-                callback(values);
+            // data has become available.
+            function fireCallback() {
+                callback();
+                // Clear the pending flag so that future updates will
+                // schedule this callback.
                 updatePending = false;
             }
 
+            // Update the latest telemetry data for a specific
+            // domain object. This will notify listeners.
             function update(domainObject, telemetry) {
                 var count = telemetry && telemetry.getPointCount();
 
+                // Only schedule notification if there isn't already
+                // a notification pending (and if we actually have
+                // data)
                 if (!updatePending && count) {
                     updatePending = true;
                     $timeout(fireCallback, 0);
                 }
 
+                // Update the latest-value table
                 if (count > 0) {
                     latestValues[domainObject.getId()] = {
                         domain: telemetry.getDomainValue(count - 1),
@@ -55,6 +86,8 @@ define(
                 }
             }
 
+            // Prepare a subscription to a specific telemetry-providing
+            // domain object.
             function subscribe(domainObject) {
                 var telemetryCapability =
                     domainObject.getCapability("telemetry");
@@ -63,23 +96,39 @@ define(
                 });
             }
 
+            // Prepare subscriptions to all relevant telemetry-providing
+            // domain objects.
             function subscribeAll(domainObjects) {
                 return domainObjects.map(subscribe);
             }
 
+            // Cache a reference to all relevant telemetry-providing
+            // domain objects. This will be called during the
+            // initial subscription chain; this allows `getTelemetryObjects()`
+            // to return a non-Promise to simplify usage elsewhere.
             function cacheObjectReferences(objects) {
                 telemetryObjects = objects;
                 return objects;
             }
 
             // Get a reference to relevant objects (those with telemetry
-            // capabilities)
+            // capabilities) and subscribe to their telemetry updates.
+            // Keep a reference to their promised return values, as these
+            // will be unsubscribe functions. (This must be a promise
+            // because delegation is supported, and retrieving delegate
+            // telemetry-capable objects may be an asynchronous operation.)
             unsubscribePromise =
                 promiseRelevantObjects(domainObject)
                     .then(cacheObjectReferences)
                     .then(subscribeAll);
 
             return {
+                /**
+                 * Terminate all underlying subscriptions associated
+                 * with this object.
+                 * @method
+                 * @memberof TelemetrySubscription
+                 */
                 unsubscribe: function () {
                     return unsubscribePromise.then(function (unsubscribes) {
                         return $q.all(unsubscribes.map(function (unsubscribe) {
@@ -87,14 +136,57 @@ define(
                         }));
                     });
                 },
+                /**
+                 * Get the most recent domain value that has been observed
+                 * for the specified domain object. This will typically be
+                 * a timestamp.
+                 *
+                 * The domain object passed here should be one that is
+                 * subscribed-to here; that is, it should be one of the
+                 * domain objects returned by `getTelemetryObjects()`.
+                 *
+                 * @param {DomainObject} domainObject the object of interest
+                 * @returns the most recent domain value observed
+                 * @method
+                 * @memberof TelemetrySubscription
+                 */
                 getDomainValue: function (domainObject) {
                     var id = domainObject.getId();
                     return (latestValues[id] || {}).domain;
                 },
+                /**
+                 * Get the most recent range value that has been observed
+                 * for the specified domain object. This will typically
+                 * be a numeric measurement.
+                 *
+                 * The domain object passed here should be one that is
+                 * subscribed-to here; that is, it should be one of the
+                 * domain objects returned by `getTelemetryObjects()`.
+                 *
+                 * @param {DomainObject} domainObject the object of interest
+                 * @returns the most recent range value observed
+                 * @method
+                 * @memberof TelemetrySubscription
+                 */
                 getRangeValue: function (domainObject) {
                     var id = domainObject.getId();
                     return (latestValues[id] || {}).range;
                 },
+                /**
+                 * Get all telemetry-providing domain objects which are
+                 * being observed as part of this subscription.
+                 *
+                 * Capability delegation will be taken into account (so, if
+                 * a Telemetry Panel was passed in the constructor, this will
+                 * return its contents.) Capability delegation is resolved
+                 * asynchronously so the return value here may change over
+                 * time; while this resolution is pending, this method will
+                 * return an empty array.
+                 *
+                 * @returns {DomainObject[]} all subscribed-to domain objects
+                 * @method
+                 * @memberof TelemetrySubscription
+                 */
                 getTelemetryObjects: function () {
                     return telemetryObjects;
                 }