ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2024-12-29 17:38:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Plots] Fix Plots breaking on exceptionally large values (#7120)

Browse Source
This commit is contained in:
Jamie V 2023-10-13 11:50:24 -07:00 committed by GitHub
parent d65821ca81
commit cbf52eb7d5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/plot/configuration/PlotSeries.js
View File

@ -63,6 +63,10 @@ import { symlog } from '../mathUtils';
* *
* @extends {Model<PlotSeriesModelType, PlotSeriesModelOptions>} * @extends {Model<PlotSeriesModelType, PlotSeriesModelOptions>}
*/ */
const FLOAT32_MAX = 3.4e38;
const FLOAT32_MIN = -3.4e38;
export default class PlotSeries extends Model { export default class PlotSeries extends Model {
logMode = false; logMode = false;
@ -357,7 +361,7 @@ export default class PlotSeries extends Model {
let stats = this.get('stats'); let stats = this.get('stats');
let changed = false; let changed = false;
if (!stats) { if (!stats) {
if ([Infinity, -Infinity].includes(value)) { if ([Infinity, -Infinity].includes(value) || !this.isValidFloat32(value)) {
return; return;
} }
@ -369,13 +373,13 @@ export default class PlotSeries extends Model {
}; };
changed = true; changed = true;
} else { } else {
if (stats.maxValue < value && value !== Infinity) { if (stats.maxValue < value && value !== Infinity && this.isValidFloat32(value)) {
stats.maxValue = value; stats.maxValue = value;
stats.maxPoint = point; stats.maxPoint = point;
changed = true; changed = true;
} }
if (stats.minValue > value && value !== -Infinity) { if (stats.minValue > value && value !== -Infinity && this.isValidFloat32(value)) {
stats.minValue = value; stats.minValue = value;
stats.minPoint = point; stats.minPoint = point;
changed = true; changed = true;
@ -411,7 +415,7 @@ export default class PlotSeries extends Model {
const lastYVal = this.getYVal(data[insertIndex - 1]); const lastYVal = this.getYVal(data[insertIndex - 1]);
if (this.isValueInvalid(currentYVal) && this.isValueInvalid(lastYVal)) { if (this.isValueInvalid(currentYVal) && this.isValueInvalid(lastYVal)) {
console.warn('[Plot] Invalid Y Values detected'); console.warn(`[Plot] Invalid Y Values detected: ${currentYVal} ${lastYVal}`);
return; return;
} }
@ -439,7 +443,15 @@ export default class PlotSeries extends Model {
* @private * @private
*/ */
isValueInvalid(val) { isValueInvalid(val) {
return Number.isNaN(val) || this.unPlottableValues.includes(val); return Number.isNaN(val) || this.unPlottableValues.includes(val) || !this.isValidFloat32(val);
}
/**
*
* @private
*/
isValidFloat32(val) {
return val < FLOAT32_MAX && val > FLOAT32_MIN;
} }
/** /**