ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-05-04 09:42:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Windowing] Tabbing Rename

Browse Source 
Renamed all instances of NewWindow to be
NewTab instead. WTD-16.
This commit is contained in:
Shivam Dave 2015-06-22 15:35:08 -07:00
parent dc4436e890
commit c7154447e2
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
platform/commonUI/browse/bundle.json
View File

@ -92,8 +92,8 @@
}, },
{ {
"key": "window", "key": "window",
"implementation": "windowing/NewWindowAction.js", "implementation": "windowing/NewTabAction.js",
"description": "Open this object in a new window", "description": "Open this object in a new tab",
"category": "view-control", "category": "view-control",
"depends": [ "$window" ], "depends": [ "$window" ],
"group": "windowing", "group": "windowing",

4
platform/commonUI/browse/src/windowing/NewWindowAction.js → platform/commonUI/browse/src/windowing/NewTabAction.js
View File

@ -36,7 +36,7 @@ define(
* the user interface.) * the user interface.)
* @constructor * @constructor
*/ */
function NewWindowAction($window) { function NewTabAction($window) {
return { return {
/** /**
* Open the object in a new window * Open the object in a new window
@ -49,6 +49,6 @@ define(
}; };
} }
return NewWindowAction; return NewTabAction;
} }
); );

2
platform/commonUI/browse/test/suite.json
View File

@ -10,6 +10,6 @@
"navigation/NavigateAction", "navigation/NavigateAction",
"navigation/NavigationService", "navigation/NavigationService",
"windowing/FullscreenAction", "windowing/FullscreenAction",
"windowing/NewWindowAction", "windowing/NewTabAction",
"windowing/WindowTitler" "windowing/WindowTitler"
] ]

6
platform/commonUI/browse/test/windowing/NewWindowActionSpec.js → platform/commonUI/browse/test/windowing/NewTabActionSpec.js
View File

@ -26,7 +26,7 @@ define(
function (NewWindowAction) { function (NewWindowAction) {
"use strict"; "use strict";
describe("The new window action", function () { describe("The new tab action", function () {
var action, var action,
mockWindow, mockWindow,
mockCurrentUrl; mockCurrentUrl;
@ -37,11 +37,11 @@ define(
// to a mock Url // to a mock Url
mockWindow = jasmine.createSpyObj("$window", ["open", "location"]); mockWindow = jasmine.createSpyObj("$window", ["open", "location"]);
mockWindow.location.href = "http://www.mockUrl.com"; mockWindow.location.href = "http://www.mockUrl.com";
action = new NewWindowAction(mockWindow); action = new NewTabAction(mockWindow);
}); });
it("New window is opened", function () { it("New tab with current url is opened", function () {
// The expection is that the mockWindow // The expection is that the mockWindow
// will be called with it's location.href // will be called with it's location.href
action.perform(); action.perform();