ESLint one-var, no-var rules (#3239)

* fixed issues for eslint one-var and no-var rules

Co-authored-by: Joshi <simplyrender@gmail.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
This commit is contained in:
Joel McKinnon
2020-08-10 12:13:23 -07:00
committed by GitHub
parent 4d560086dd
commit c6ca912f2b
193 changed files with 1601 additions and 1541 deletions

View File

@ -205,7 +205,7 @@ define([
* @private
*/
TelemetryAPI.prototype.findSubscriptionProvider = function () {
var args = Array.prototype.slice.apply(arguments);
const args = Array.prototype.slice.apply(arguments);
function supportsDomainObject(provider) {
return provider.supportsSubscribe.apply(provider, args);
}
@ -217,7 +217,7 @@ define([
* @private
*/
TelemetryAPI.prototype.findRequestProvider = function (domainObject) {
var args = Array.prototype.slice.apply(arguments);
const args = Array.prototype.slice.apply(arguments);
function supportsDomainObject(provider) {
return provider.supportsRequest.apply(provider, args);
}
@ -282,7 +282,7 @@ define([
}
this.standardizeRequestOptions(arguments[1]);
var provider = this.findRequestProvider.apply(this, arguments);
const provider = this.findRequestProvider.apply(this, arguments);
if (!provider) {
return Promise.reject('No provider found');
}
@ -310,14 +310,14 @@ define([
* the subscription
*/
TelemetryAPI.prototype.subscribe = function (domainObject, callback, options) {
var provider = this.findSubscriptionProvider(domainObject);
const provider = this.findSubscriptionProvider(domainObject);
if (!this.subscribeCache) {
this.subscribeCache = {};
}
var keyString = objectUtils.makeKeyString(domainObject.identifier);
var subscriber = this.subscribeCache[keyString];
const keyString = objectUtils.makeKeyString(domainObject.identifier);
let subscriber = this.subscribeCache[keyString];
if (!subscriber) {
subscriber = this.subscribeCache[keyString] = {
@ -357,12 +357,12 @@ define([
*/
TelemetryAPI.prototype.getMetadata = function (domainObject) {
if (!this.metadataCache.has(domainObject)) {
var metadataProvider = this.findMetadataProvider(domainObject);
const metadataProvider = this.findMetadataProvider(domainObject);
if (!metadataProvider) {
return;
}
var metadata = metadataProvider.getMetadata(domainObject);
const metadata = metadataProvider.getMetadata(domainObject);
this.metadataCache.set(
domainObject,
@ -379,12 +379,12 @@ define([
*
*/
TelemetryAPI.prototype.commonValuesForHints = function (metadatas, hints) {
var options = metadatas.map(function (metadata) {
var values = metadata.valuesForHints(hints);
const options = metadatas.map(function (metadata) {
const values = metadata.valuesForHints(hints);
return _.keyBy(values, 'key');
}).reduce(function (a, b) {
var results = {};
const results = {};
Object.keys(a).forEach(function (key) {
if (Object.prototype.hasOwnProperty.call(b, key)) {
results[key] = a[key];
@ -393,7 +393,7 @@ define([
return results;
});
var sortKeys = hints.map(function (h) {
const sortKeys = hints.map(function (h) {
return 'hints.' + h;
});
@ -428,7 +428,7 @@ define([
*/
TelemetryAPI.prototype.getFormatMap = function (metadata) {
if (!this.formatMapCache.has(metadata)) {
var formatMap = metadata.values().reduce(function (map, valueMetadata) {
const formatMap = metadata.values().reduce(function (map, valueMetadata) {
map[valueMetadata.key] = this.getValueFormatter(valueMetadata);
return map;
@ -489,7 +489,7 @@ define([
* @memberof module:openmct.TelemetryAPI~TelemetryProvider#
*/
TelemetryAPI.prototype.getLimitEvaluator = function (domainObject) {
var provider = this.findLimitEvaluator(domainObject);
const provider = this.findLimitEvaluator(domainObject);
if (!provider) {
return {
evaluate: function () {}