Hide vue plots from showing up in the view-switcher and in the preview window (#3725)

* Hide vue plots from showing up in the view-switcher and in the preview window.
This commit is contained in:
Shefali Joshi
2021-03-03 11:33:31 -08:00
committed by GitHub
parent b68f79f427
commit b8ded0a16e
21 changed files with 101 additions and 47 deletions

View File

@ -32,12 +32,12 @@ export default function OverlayPlotViewProvider(openmct) {
key: 'plot-overlay',
name: 'Overlay Plot',
cssClass: 'icon-telemetry',
canView(domainObject) {
return domainObject.type === 'telemetry.plot.overlay';
canView(domainObject, objectPath) {
return isCompactView(objectPath) && domainObject.type === 'telemetry.plot.overlay';
},
canEdit(domainObject) {
return domainObject.type === 'telemetry.plot.overlay';
canEdit(domainObject, objectPath) {
return isCompactView(objectPath) && domainObject.type === 'telemetry.plot.overlay';
},
view: function (domainObject, objectPath) {

View File

@ -47,8 +47,8 @@ export default function PlotViewProvider(openmct) {
key: 'plot-simple',
name: 'Plot',
cssClass: 'icon-telemetry',
canView(domainObject) {
return hasTelemetry(domainObject, openmct);
canView(domainObject, objectPath) {
return isCompactView(objectPath) && hasTelemetry(domainObject, openmct);
},
view: function (domainObject, objectPath) {

View File

@ -33,8 +33,27 @@ describe("the plugin", function () {
let openmct;
let telemetryPromise;
let cleanupFirst;
let mockObjectPath;
beforeEach((done) => {
mockObjectPath = [
{
name: 'mock folder',
type: 'fake-folder',
identifier: {
key: 'mock-folder',
namespace: ''
}
},
{
name: 'mock parent folder',
type: 'time-strip',
identifier: {
key: 'mock-parent-folder',
namespace: ''
}
}
];
const testTelemetry = [
{
'utc': 1,
@ -134,7 +153,7 @@ describe("the plugin", function () {
}
};
const applicableViews = openmct.objectViews.get(testTelemetryObject);
const applicableViews = openmct.objectViews.get(testTelemetryObject, mockObjectPath);
let plotView = applicableViews.find((viewProvider) => viewProvider.key === "plot-simple");
expect(plotView).toBeDefined();
});
@ -150,7 +169,7 @@ describe("the plugin", function () {
}
};
const applicableViews = openmct.objectViews.get(testTelemetryObject);
const applicableViews = openmct.objectViews.get(testTelemetryObject, mockObjectPath);
let plotView = applicableViews.find((viewProvider) => viewProvider.key === "plot-overlay");
expect(plotView).toBeDefined();
});
@ -166,7 +185,7 @@ describe("the plugin", function () {
}
};
const applicableViews = openmct.objectViews.get(testTelemetryObject);
const applicableViews = openmct.objectViews.get(testTelemetryObject, mockObjectPath);
let plotView = applicableViews.find((viewProvider) => viewProvider.key === "plot-stacked");
expect(plotView).toBeDefined();
});
@ -218,7 +237,7 @@ describe("the plugin", function () {
}
};
applicableViews = openmct.objectViews.get(testTelemetryObject);
applicableViews = openmct.objectViews.get(testTelemetryObject, mockObjectPath);
plotViewProvider = applicableViews.find((viewProvider) => viewProvider.key === "plot-simple");
plotView = plotViewProvider.view(testTelemetryObject, [testTelemetryObject]);
plotView.show(child, true);

View File

@ -32,12 +32,12 @@ export default function StackedPlotViewProvider(openmct) {
key: 'plot-stacked',
name: 'Stacked Plot',
cssClass: 'icon-telemetry',
canView(domainObject) {
return domainObject.type === 'telemetry.plot.stacked';
canView(domainObject, objectPath) {
return isCompactView(objectPath) && domainObject.type === 'telemetry.plot.stacked';
},
canEdit(domainObject) {
return domainObject.type === 'telemetry.plot.stacked';
canEdit(domainObject, objectPath) {
return isCompactView(objectPath) && domainObject.type === 'telemetry.plot.stacked';
},
view: function (domainObject, objectPath) {