From d13d7dc8f30a1ac02ec941314b9562961248eb63 Mon Sep 17 00:00:00 2001 From: Shefali Joshi Date: Wed, 8 Jun 2022 09:41:25 -0700 Subject: [PATCH 1/9] Allows drag and dropping plans into timelist (#5300) * Bump d3-selection from 1.3.2 to 3.0.0 Bumps [d3-selection](https://github.com/d3/d3-selection) from 1.3.2 to 3.0.0. - [Release notes](https://github.com/d3/d3-selection/releases) - [Commits](https://github.com/d3/d3-selection/compare/v1.3.2...v3.0.0) --- updated-dependencies: - dependency-name: d3-selection dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] * Don't require a plan file for timelist Allow dropping a plan to timelist * Rename methods and remove unused code * Fix typo * Boost test coverage to get over 52% * Adds tests for webPage plugin * Adds more tests for filtering * Adds more filtering tests * Removes one test Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- src/plugins/plan/util.js | 4 +- src/plugins/timeline/TimelineObjectView.vue | 19 +- src/plugins/timeline/TimelineViewLayout.vue | 13 +- src/plugins/timeline/pluginSpec.js | 106 ++++++++- src/plugins/timelist/Timelist.vue | 77 ++++++- .../timelist/TimelistCompositionPolicy.js | 34 +++ src/plugins/timelist/TimelistViewProvider.js | 3 +- src/plugins/timelist/plugin.js | 4 +- src/plugins/timelist/pluginSpec.js | 216 +++++++++++++++++- src/plugins/webPage/pluginSpec.js | 106 +++++++++ 10 files changed, 548 insertions(+), 34 deletions(-) create mode 100644 src/plugins/timelist/TimelistCompositionPolicy.js create mode 100644 src/plugins/webPage/pluginSpec.js diff --git a/src/plugins/plan/util.js b/src/plugins/plan/util.js index c5e3cc6b83..4854f11b46 100644 --- a/src/plugins/plan/util.js +++ b/src/plugins/plan/util.js @@ -22,7 +22,7 @@ export function getValidatedData(domainObject) { let sourceMap = domainObject.sourceMap; - let body = domainObject.selectFile.body; + let body = domainObject.selectFile?.body; let json = {}; if (typeof body === 'string') { try { @@ -30,7 +30,7 @@ export function getValidatedData(domainObject) { } catch (e) { return json; } - } else { + } else if (body !== undefined) { json = body; } diff --git a/src/plugins/timeline/TimelineObjectView.vue b/src/plugins/timeline/TimelineObjectView.vue index 24bd529679..516d5650fc 100644 --- a/src/plugins/timeline/TimelineObjectView.vue +++ b/src/plugins/timeline/TimelineObjectView.vue @@ -27,17 +27,18 @@ :show-ucontents="item.domainObject.type === 'plan'" :span-rows-count="item.rowCount" > - diff --git a/src/plugins/timeline/TimelineViewLayout.vue b/src/plugins/timeline/TimelineViewLayout.vue index cc327b22a8..c92e4ab739 100644 --- a/src/plugins/timeline/TimelineViewLayout.vue +++ b/src/plugins/timeline/TimelineViewLayout.vue @@ -29,10 +29,10 @@ v-for="timeSystemItem in timeSystems" :key="timeSystemItem.timeSystem.key" > -