ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-05-31 22:50:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Folder] List view load fix (#2069)

Browse Source 
* [Folder] List view load fix

-List view data takes long time to display, has to do with Angular not triggering its digestive cycle when switching views
-Resolved issue by explicitly triggering the digestive cycle
-Fixes issue #2067

* Added comment to clarify code addition

fix #2069
This commit is contained in:
Julie Wang 2018-06-21 10:52:27 -07:00 committed by Pete Richards
parent 45a152df86
commit b187762d55
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
platform/features/listview/src/controllers/ListViewController.js
View File

@ -32,6 +32,11 @@ define(function () {
this.utc = formatService.getFormat('utc'); this.utc = formatService.getFormat('utc');
//Trigger digestive cycle with $apply to update list view
setTimeout(function () {
$scope.$apply();
});
$scope.$on('$destroy', function () { $scope.$on('$destroy', function () {
unlisten(); unlisten();
}); });

3
platform/features/listview/test/controllers/ListViewControllerSpec.js
View File

@ -104,7 +104,7 @@ define(
scope = jasmine.createSpyObj( scope = jasmine.createSpyObj(
"$scope", "$scope",
["$on"] ["$on", "$apply"]
); );
scope.domainObject = domainObject; scope.domainObject = domainObject;
@ -146,6 +146,7 @@ define(
runs(function () { runs(function () {
expect(scope.children.length).toEqual(0); expect(scope.children.length).toEqual(0);
}); });
expect(scope.$apply).toHaveBeenCalled();
}); });
it("releases listeners on $destroy", function () { it("releases listeners on $destroy", function () {
expect(scope.$on).toHaveBeenCalledWith('$destroy', jasmine.any(Function)); expect(scope.$on).toHaveBeenCalledWith('$destroy', jasmine.any(Function));