ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-05 00:50:49 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[Search] Empty search resets results

Browse Source 
When there is no input into the search bar
no results are displayed/displayed results
are removed. This is because the search
providers were changed to return empty
arrays for empty search strings.
This commit is contained in:
shale 2015-07-22 16:09:14 -07:00
parent b16af5fe3e
commit b0e7dca985
5 changed files with 39 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
platform/commonUI/general/res/css/tree.css
View File

@ -272,9 +272,9 @@ ul.tree {
* at runtime from the About dialog for additional information. * at runtime from the About dialog for additional information.
*****************************************************************************/ *****************************************************************************/
/* line 27, ../sass/search/_search.scss */ /* line 27, ../sass/search/_search.scss */
.search .searchbar { .search .search-input {
width: 100%; width: 100%;
margin-top: 20px; } margin-top: 10px; }
/* line 32, ../sass/search/_search.scss */ /* line 32, ../sass/search/_search.scss */
.search .results { .search .results {
margin-top: 10px; } margin-top: 10px; }

4
platform/commonUI/general/res/sass/search/_search.scss
View File

@ -24,9 +24,9 @@
$iconWidth: 20px; $iconWidth: 20px;
$leftMargin: 6px; $leftMargin: 6px;
.searchbar { .search-input {
width: 100%; width: 100%;
margin-top: 20px; margin-top: 10px;
} }
.results { .results {

2
platform/features/search/res/templates/search.html
View File

@ -23,7 +23,7 @@
ng-controller="SearchController as controller"> ng-controller="SearchController as controller">
<!-- Search bar input --> <!-- Search bar input -->
<div> <div>
<input class="searchbar" <input class="search-input"
id="searchbarinput" id="searchbarinput"
type="text" type="text"
value="" value=""

7
platform/features/search/src/providers/ElasticsearchSearchProvider.js
View File

@ -159,6 +159,8 @@ define(
// Get the user input // Get the user input
searchTerm = document.getElementById(inputID).value; searchTerm = document.getElementById(inputID).value;
// If the user input is empty, we want to have no search results.
if (searchTerm !== '') {
// Process search term // Process search term
searchTerm = processSearchTerm(searchTerm); searchTerm = processSearchTerm(searchTerm);
@ -177,6 +179,11 @@ define(
// ...then process the data // ...then process the data
return processResults(rawResults, timestamp); return processResults(rawResults, timestamp);
}); });
} else {
latestResults = [];
lastSearchTimestamp = timestamp;
return latestResults;
}
} }
return { return {

4
platform/features/search/src/workers/GenericSearchWorker.js
View File

@ -135,6 +135,9 @@
terms = convertToTerms(input), terms = convertToTerms(input),
timesToLoop = Math.min(indexedItems.length, data.maxNumber); timesToLoop = Math.min(indexedItems.length, data.maxNumber);
// If the user input is empty, we want to have no search results.
if (input !== '') {
for (var i = 0; i < timesToLoop; i++) { for (var i = 0; i < timesToLoop; i++) {
var score = scoreItem(indexedItems[i], input, terms); var score = scoreItem(indexedItems[i], input, terms);
if (score > 0) { if (score > 0) {
@ -143,6 +146,7 @@
}; };
} }
} }
}
var message = { var message = {
request: 'search', request: 'search',