addressed review comments

This commit is contained in:
Joel McKinnon
2020-02-18 11:14:50 -08:00
parent 03a6de55d6
commit ad7d029ce8
2 changed files with 10 additions and 10 deletions

View File

@ -43,11 +43,11 @@
<ConditionEdit :condition-identifier="conditionIdentifier" <ConditionEdit :condition-identifier="conditionIdentifier"
:current-condition-identifier="currentConditionIdentifier" :current-condition-identifier="currentConditionIdentifier"
:condition-index="index" :condition-index="index"
@update-current-condition="updateCurrentCondition" @updateCurrentCondition="updateCurrentCondition"
@remove-condition="removeCondition" @removeCondition="removeCondition"
@clone-condition="cloneCondition" @cloneCondition="cloneCondition"
@condition-result-updated="handleConditionResult" @conditionResultUpdated="handleConditionResult"
@set-move-index="setMoveIndex" @setMoveIndex="setMoveIndex"
/> />
</div> </div>
<div v-else> <div v-else>

View File

@ -216,19 +216,19 @@ export default {
}, },
methods: { methods: {
dragStart(e) { dragStart(e) {
this.$emit('set-move-index', Number(e.target.getAttribute('data-condition-index'))); this.$emit('setMoveIndex', Number(e.target.getAttribute('data-condition-index')));
}, },
handleConditionResult(args) { handleConditionResult(args) {
this.$emit('condition-result-updated', { this.$emit('conditionResultUpdated', {
id: this.conditionIdentifier, id: this.conditionIdentifier,
result: args.data.result result: args.data.result
}) })
}, },
removeCondition(ev) { removeCondition(ev) {
this.$emit('remove-condition', this.conditionIdentifier); this.$emit('removeCondition', this.conditionIdentifier);
}, },
cloneCondition(ev) { cloneCondition(ev) {
this.$emit('clone-condition', { this.$emit('cloneCondition', {
identifier: this.conditionIdentifier, identifier: this.conditionIdentifier,
index: Number(ev.target.closest('.widget-condition').getAttribute('data-condition-index')) index: Number(ev.target.closest('.widget-condition').getAttribute('data-condition-index'))
}); });
@ -294,7 +294,7 @@ export default {
//find the criterion being updated and set the input property //find the criterion being updated and set the input property
}, },
updateCurrentCondition() { updateCurrentCondition() {
this.$emit('update-current-condition', this.conditionIdentifier); this.$emit('updateCurrentCondition', this.conditionIdentifier);
} }
} }
} }