ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-19 23:53:49 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix(#7215)[Fault Management]: Fix shelving and acknowledging faults with single and bulk actions (#7559)

Browse Source 
* refactor: merge FaultManagementListView into FaultManagementView

* refactor: make `selectedFaults` a computed property

* refactor: use named exports

* fix: reset fault map AFTER selectedFaults have been acknowledged

* a11y: add aria labels for fault management toolbar buttons

* refactor: use named import/exports

* a11y: add label

* a11y: add aria label for checkboxes

* fix: acknowledging or shelving single fault from context menu should only apply to selected fault

* refactor: use change event instead of input event for checkbox

* test: fix e2e tests, remove expect.softs

* test: stabilize fault management e2e tests
This commit is contained in:
Jesse Mazzella
2024-03-06 15:28:38 -08:00
committed by GitHub
parent df969722d1
commit ab49f3f3a1
10 changed files with 512 additions and 514 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
e2e/tests/visual-a11y/faultManagement.visual.spec.js
View File

@ -21,12 +21,20 @@
*****************************************************************************/
import percySnapshot from '@percy/playwright';
import * as utils from '../../helper/faultUtils.js';
import {
acknowledgeFault,
changeViewTo,
navigateToFaultManagementWithoutExample,
navigateToFaultManagementWithStaticExample,
openFaultRowMenu,
selectFaultItem,
shelveFault
} from '../../helper/faultUtils.js';
import { expect, test } from '../../pluginFixtures.js';
test.describe('Fault Management Visual Tests - without example', () => {
test.beforeEach(async ({ page }) => {
await utils.navigateToFaultManagementWithoutExample(page);
await navigateToFaultManagementWithoutExample(page);
await page.getByLabel('Collapse Inspect Pane').click();
await page.getByLabel('Click to collapse items').click();
});
@ -55,7 +63,7 @@ test.describe('Fault Management Visual Tests - without example', () => {
test.describe('Fault Management Visual Tests', () => {
test.beforeEach(async ({ page }) => {
await utils.navigateToFaultManagementWithStaticExample(page);
await navigateToFaultManagementWithStaticExample(page);
await page.getByLabel('Collapse Inspect Pane').click();
await page.getByLabel('Click to collapse items').click();
});
@ -63,8 +71,8 @@ test.describe('Fault Management Visual Tests', () => {
test('fault list and acknowledged faults', async ({ page, theme }) => {
await percySnapshot(page, `Shows a list of faults in the standard view (theme: '${theme}')`);
await utils.acknowledgeFault(page, 1);
await utils.changeViewTo(page, 'acknowledged');
await acknowledgeFault(page, 1);
await changeViewTo(page, 'acknowledged');
await percySnapshot(
page,
@ -73,12 +81,12 @@ test.describe('Fault Management Visual Tests', () => {
});
test('shelved faults', async ({ page, theme }) => {
await utils.shelveFault(page, 1);
await utils.changeViewTo(page, 'shelved');
await shelveFault(page, 1);
await changeViewTo(page, 'shelved');
await percySnapshot(page, `Shelved faults appear in the shelved view (theme: '${theme}')`);
await utils.openFaultRowMenu(page, 1);
await openFaultRowMenu(page, 1);
await percySnapshot(
page,
@ -87,7 +95,7 @@ test.describe('Fault Management Visual Tests', () => {
});
test('3-dot menu for fault', async ({ page, theme }) => {
await utils.openFaultRowMenu(page, 1);
await openFaultRowMenu(page, 1);
await percySnapshot(
page,
@ -96,7 +104,7 @@ test.describe('Fault Management Visual Tests', () => {
});
test('ability to acknowledge or shelve', async ({ page, theme }) => {
await utils.selectFaultItem(page, 1);
await selectFaultItem(page, 1);
await percySnapshot(
page,