ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-20 08:03:49 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #317 from nasa/open316

Browse Source 
[bug] TypeImpl.getInitialmodel should always return a fresh (ie. cloned) model.
This commit is contained in:
Victor Woeltjen
2015-11-18 12:21:23 -08:00
parent 4de7b7dfb5 5ced8e655d
commit a7f277b0d2
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
platform/core/src/types/TypeImpl.js
View File

@ -156,8 +156,15 @@ define(
}); });
}; };
/**
* Returns the default model for an object of this type. Note that
* this method returns a clone of the original model, so if using this
* method heavily, consider caching the result to optimize performance.
*
* @return {object} The default model for an object of this type.
*/
TypeImpl.prototype.getInitialModel = function () { TypeImpl.prototype.getInitialModel = function () {
return this.typeDef.model || {}; return JSON.parse(JSON.stringify(this.typeDef.model || {}));
}; };
TypeImpl.prototype.getDefinition = function () { TypeImpl.prototype.getDefinition = function () {

6
platform/core/test/types/TypeImplSpec.js
View File

@ -101,6 +101,12 @@ define(
expect(type.getInitialModel().someKey).toEqual("some value"); expect(type.getInitialModel().someKey).toEqual("some value");
}); });
it("provides a fresh initial model each time", function () {
var model = type.getInitialModel();
model.someKey = "some other value";
expect(type.getInitialModel().someKey).toEqual("some value");
});
it("provides type properties", function () { it("provides type properties", function () {
expect(type.getProperties().length).toEqual(1); expect(type.getProperties().length).toEqual(1);
}); });