For the setTimeConductorMode, use the close time popup button rather than the submit button to dismiss time popup (#7613)

Use the close time popup button rather than the submit button as the submit button triggers network requests.
This commit is contained in:
Shefali Joshi 2024-03-18 16:48:33 -07:00 committed by GitHub
parent b7b9ccbe65
commit a01f21017f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 3 deletions

View File

@ -392,7 +392,8 @@ async function setTimeConductorMode(page, isFixedTimespan = true) {
await page.getByRole('menuitem', { name: /Real-Time/ }).click(); await page.getByRole('menuitem', { name: /Real-Time/ }).click();
await page.waitForURL(/tc\.mode=local/); await page.waitForURL(/tc\.mode=local/);
} }
await page.getByLabel('Submit time offsets').or(page.getByLabel('Submit time bounds')).click(); //dismiss the time conductor popup
await page.getByLabel('Discard changes and close time popup').click();
} }
/** /**

View File

@ -87,7 +87,7 @@
></button> ></button>
<button <button
class="c-button icon-x" class="c-button icon-x"
aria-label="Discard time bounds" aria-label="Discard changes and close time popup"
@click.prevent="hide" @click.prevent="hide"
></button> ></button>
</div> </div>

View File

@ -132,7 +132,7 @@
></button> ></button>
<button <button
class="c-button icon-x" class="c-button icon-x"
aria-label="Discard time offsets" aria-label="Discard changes and close time popup"
@click.prevent="hide" @click.prevent="hide"
></button> ></button>
</div> </div>