From ddef16795cdc7e18f1030ee85c123a23c10088a4 Mon Sep 17 00:00:00 2001 From: Charles Hacskaylo Date: Wed, 8 Apr 2020 09:36:23 -0700 Subject: [PATCH 1/2] Conditionals and Notebook UI fixes (#2868) - Significant fixes for Safari-compatible Flex layout in Condition Set view; - Changed visual approach to current-value section; - Firefox scrollbar coloring - Fix layout issues in Firefox; - Consolidate Conditionals styles into single scss file; - Fix test datum elements layout, better wrapping; - Better approach to presence/absence of URL property in Condition Widget; - Fixes #2853; - Fix errors in URL property handling in Condition Widget; - Fixes #2853; - Fixes #2867 - hide the View Switcher when an object is being edited; - Refined titling on View Switcher and Notebook menu button; - Cleaned up styles in l-browse-bar and moved into ui/layout/layout.scss; - Removed styles/_layout.scss; - Hide the main view Edit button when in mobile --- .../components/ConditionCollection.vue | 1 - .../condition/components/ConditionSet.vue | 45 ++--- src/plugins/condition/components/TestData.vue | 3 +- .../condition/components/condition-set.scss | 116 ------------- .../{condition.scss => conditionals.scss} | 155 +++++++++++++++++- .../components/ConditionWidget.vue | 12 +- .../components/condition-widget.scss | 10 +- .../components/notebook-menu-switcher.vue | 4 +- src/plugins/themes/espresso-theme.scss | 1 - src/plugins/themes/maelstrom-theme.scss | 1 - src/plugins/themes/snow-theme.scss | 1 - src/styles/_controls.scss | 10 +- src/styles/_global.scss | 6 + src/styles/_layout.scss | 87 ---------- src/styles/vue-styles.scss | 3 +- src/ui/layout/BrowseBar.vue | 1 + src/ui/layout/ViewSwitcher.vue | 2 +- src/ui/layout/layout.scss | 98 ++++++++++- 18 files changed, 299 insertions(+), 257 deletions(-) delete mode 100644 src/plugins/condition/components/condition-set.scss rename src/plugins/condition/components/{condition.scss => conditionals.scss} (51%) delete mode 100644 src/styles/_layout.scss diff --git a/src/plugins/condition/components/ConditionCollection.vue b/src/plugins/condition/components/ConditionCollection.vue index e96621f3d3..f3c290c7b6 100644 --- a/src/plugins/condition/components/ConditionCollection.vue +++ b/src/plugins/condition/components/ConditionCollection.vue @@ -22,7 +22,6 @@