ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-01-19 11:17:04 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

[Plots] y-axis width fix (#3112)

Browse Source 
* remove lodash

native implementation of lodash max

* remove unused lodash imports

* add 'missing' semi-colon

Co-authored-by: Deep Tailor <deep.j.tailor@nasa.gov>
This commit is contained in:
David Tsay 2020-06-24 11:44:40 -07:00 committed by GitHub
parent f0dc928230
commit 9e5eddec9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/plot/src/chart/MCTChartController.js
View File

@ -30,8 +30,7 @@ define([
'./MCTChartPointSet',
'./MCTChartAlarmPointSet',
'../draw/DrawLoader',
'../lib/eventHelpers',
'lodash'
'../lib/eventHelpers'
],
function (
MCTChartLineLinear,
@ -39,8 +38,7 @@ function (
MCTChartPointSet,
MCTChartAlarmPointSet,
DrawLoader,
eventHelpers,
_
eventHelpers
) {
var MARKER_SIZE = 6.0,

2
src/plugins/plot/src/configuration/Collection.js
View File

@ -22,13 +22,11 @@
/*global define*/
define([
'lodash',
'EventEmitter',
'./Model',
'../lib/extend',
'../lib/eventHelpers'
], function (
_,
EventEmitter,
Model,
extend,

2
src/plugins/plot/src/draw/Draw2D.js
View File

@ -22,11 +22,9 @@
define([
'lodash',
'EventEmitter',
'../lib/eventHelpers'
], function (
_,
EventEmitter,
eventHelpers
) {

2
src/plugins/plot/src/draw/DrawWebGL.js
View File

@ -22,11 +22,9 @@
define([
'lodash',
'EventEmitter',
'../lib/eventHelpers'
], function (
_,
EventEmitter,
eventHelpers
) {

6
src/plugins/plot/src/inspector/PlotOptionsController.js
View File

@ -23,13 +23,11 @@
define([
'../configuration/configStore',
'../lib/eventHelpers',
'objectUtils',
'lodash'
'objectUtils'
], function (
configStore,
eventHelpers,
objectUtils,
_
objectUtils
) {
function PlotOptionsController($scope, openmct, $timeout) {

6
src/plugins/plot/src/inspector/PlotYAxisFormController.js
View File

@ -21,11 +21,9 @@
*****************************************************************************/
define([
'./PlotModelFormController',
'lodash'
'./PlotModelFormController'
], function (
PlotModelFormController,
_
PlotModelFormController
) {
var PlotYAxisFormController = PlotModelFormController.extend({

12
src/plugins/plot/src/telemetry/StackedPlotController.js
View File

@ -20,12 +20,7 @@
* at runtime from the About dialog for additional information.
*****************************************************************************/
define([
'lodash'
], function (
_
) {
define([], function () {
function StackedPlotController($scope, openmct, objectService, $element, exportImageService) {
var tickWidth = 0,
composition,
@ -125,12 +120,13 @@ define([
$scope.$watch('domainObject.getModel().composition', onCompositionChange);
$scope.$on('plot:tickWidth', function ($e, width) {
var plotId = $e.targetScope.domainObject.getId();
const plotId = $e.targetScope.domainObject.getId();
if (!tickWidthMap.hasOwnProperty(plotId)) {
return;
}
tickWidthMap[plotId] = Math.max(width, tickWidthMap[plotId]);
var newTickWidth = _.max(tickWidthMap);
const newTickWidth = Math.max(...Object.values(tickWidthMap));
if (newTickWidth !== tickWidth || width !== tickWidth) {
tickWidth = newTickWidth;
$scope.$broadcast('plot:tickWidth', tickWidth);