ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-02-02 01:08:13 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

[Common UI] Reduce digest count

Browse Source 
Reduce number of digest cycles triggered by mct-resize;
only trigger a new digest cycle when size actually
changes. #19.
This commit is contained in:
Victor Woeltjen 2015-06-29 09:48:32 -07:00
parent 12b34b5d58
commit 933927cda1
2 changed files with 36 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
platform/commonUI/general/src/directives/MCTResize.js
View File

@ -73,6 +73,7 @@ define(
lastBounds.width !== bounds.width ||
lastBounds.height !== bounds.height) {
scope.$eval(attrs.mctResize, { bounds: bounds });
scope.$apply(); // Trigger a digest
lastBounds = bounds;
}
}
@ -85,7 +86,7 @@ define(
height: element[0].offsetHeight
});
if (active) {
$timeout(onInterval, currentInterval());
$timeout(onInterval, currentInterval(), false);
}
}
@ -111,4 +112,4 @@ define(
return MCTResize;
}
);
);

36
platform/commonUI/general/test/directives/MCTResizeSpec.js
View File

@ -35,7 +35,7 @@ define(
beforeEach(function () {
mockTimeout = jasmine.createSpy("$timeout");
mockScope = jasmine.createSpyObj("$scope", ["$eval", "$on"]);
mockScope = jasmine.createSpyObj("$scope", ["$eval", "$on", "$apply"]);
testElement = { offsetWidth: 100, offsetHeight: 200 };
testAttrs = { mctResize: "some-expr" };
@ -52,7 +52,8 @@ define(
mctResize.link(mockScope, [testElement], testAttrs);
expect(mockTimeout).toHaveBeenCalledWith(
jasmine.any(Function),
jasmine.any(Number)
jasmine.any(Number),
false
);
expect(mockScope.$eval).toHaveBeenCalledWith(
testAttrs.mctResize,
@ -110,6 +111,35 @@ define(
expect(mockTimeout.calls.length).toEqual(2);
});
it("triggers a digest cycle when size changes", function () {
var applyCount;
mctResize.link(mockScope, [testElement], testAttrs);
applyCount = mockScope.$apply.calls.length;
// Change the element's apparent size
testElement.offsetWidth = 300;
testElement.offsetHeight = 350;
// Fire the timeout
mockTimeout.mostRecentCall.args[0]();
// No more apply calls
expect(mockScope.$apply.calls.length)
.toBeGreaterThan(applyCount);
});
it("does not trigger a digest cycle when size does not change", function () {
var applyCount;
mctResize.link(mockScope, [testElement], testAttrs);
applyCount = mockScope.$apply.calls.length;
// Fire the timeout
mockTimeout.mostRecentCall.args[0]();
// No more apply calls
expect(mockScope.$apply.calls.length).toEqual(applyCount);
});
});
}
);
);