From 8e7bfd080dd6def1be2712752a9dea1f6f2e4815 Mon Sep 17 00:00:00 2001
From: Scott Bell <scott@traclabs.com>
Date: Wed, 9 Oct 2024 12:04:28 +0200
Subject: [PATCH] ensure number for sample size

---
 src/plugins/comps/CompsMathWorker.js       | 3 +--
 src/plugins/comps/components/CompsView.vue | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/plugins/comps/CompsMathWorker.js b/src/plugins/comps/CompsMathWorker.js
index bb7c2ffe6f..4831c606a6 100644
--- a/src/plugins/comps/CompsMathWorker.js
+++ b/src/plugins/comps/CompsMathWorker.js
@@ -1,4 +1,3 @@
-import { sampleSize } from 'lodash';
 import { evaluate } from 'mathjs';
 
 // eslint-disable-next-line no-undef
@@ -84,7 +83,7 @@ function calculate(dataFrame, parameters, expression) {
       accumulatedData[referenceParameter.name].push(referenceValue);
       referenceValue = accumulatedData[referenceParameter.name];
     }
-    if (referenceParameter.sampleSize && sampleSize > 0) {
+    if (referenceParameter.sampleSize && referenceParameter.sampleSize > 0) {
       // enforce sample size by ensuring referenceValue has the latest n elements
       // if we don't have at least the sample size, skip this iteration
       if (referenceValue.length < referenceParameter.sampleSize) {
diff --git a/src/plugins/comps/components/CompsView.vue b/src/plugins/comps/components/CompsView.vue
index 3f9ccf19b3..3acf6a4269 100644
--- a/src/plugins/comps/components/CompsView.vue
+++ b/src/plugins/comps/components/CompsView.vue
@@ -121,7 +121,7 @@
                 v-if="isEditing && parameter.accumulateValues"
                 v-model="parameter.sampleSize"
                 :aria-label="`Sample Size for ${parameter.name}`"
-                type="text"
+                type="number"
                 class="c-input--md"
                 @change="updateParameters"
               />