Merge pull request #3154 from nasa/remove-action-tests

Remove action tests

src/plugins/remove/pluginSpec.js

@@ -0,0 +1,121 @@
+/*****************************************************************************
+ * Open MCT, Copyright (c) 2014-2018, United States Government
+ * as represented by the Administrator of the National Aeronautics and Space
+ * Administration. All rights reserved.
+ *
+ * Open MCT is licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ * Open MCT includes source code licensed under additional open source
+ * licenses. See the Open Source Licenses file (LICENSES.md) included with
+ * this source code distribution or the Licensing information page available
+ * at runtime from the About dialog for additional information.
+ *****************************************************************************/
+import RemoveActionPlugin from './plugin.js';
+import RemoveAction from './RemoveAction.js';
+import {
+    createOpenMct,
+    resetApplicationState,
+    getMockObjects
+} from 'utils/testing';
+
+describe("The Remove Action plugin", () => {
+
+    let openmct;
+    let removeAction;
+    let childObject;
+    let parentObject;
+
+    // this setups up the app
+    beforeEach((done) => {
+        const appHolder = document.createElement('div');
+        appHolder.style.width = '640px';
+        appHolder.style.height = '480px';
+
+        openmct = createOpenMct();
+
+        childObject = getMockObjects({
+            objectKeyStrings: ['folder'],
+            overwrite: {
+                folder: {
+                    name: "Child Folder",
+                    identifier: {
+                        namespace: "",
+                        key: "child-folder-object"
+                    }
+                }
+            }
+        }).folder;
+        parentObject = getMockObjects({
+            objectKeyStrings: ['folder'],
+            overwrite: {
+                folder: {
+                    name: "Parent Folder",
+                    composition: [childObject.identifier]
+                }
+            }
+        }).folder;
+
+        // already installed by default, but never hurts, just adds to context menu
+        openmct.install(RemoveActionPlugin());
+
+        openmct.on('start', done);
+        openmct.startHeadless(appHolder);
+    });
+
+    afterEach(() => {
+        resetApplicationState(openmct);
+    });
+
+    it("should be defined", () => {
+        expect(RemoveActionPlugin).toBeDefined();
+    });
+
+    describe("when removing an object from a parent composition", () => {
+
+        beforeEach(() => {
+            removeAction = new RemoveAction(openmct);
+            spyOn(removeAction, 'removeFromComposition').and.callThrough();
+            spyOn(removeAction, 'inNavigationPath').and.returnValue(false);
+            spyOn(openmct.objects, 'mutate').and.callThrough();
+            removeAction.removeFromComposition(parentObject, childObject);
+        });
+
+        it("removeFromComposition should be called with the parent and child", () => {
+            expect(removeAction.removeFromComposition).toHaveBeenCalled();
+            expect(removeAction.removeFromComposition).toHaveBeenCalledWith(parentObject, childObject);
+        });
+
+        it("it should mutate the parent object", () => {
+            expect(openmct.objects.mutate).toHaveBeenCalled();
+            expect(openmct.objects.mutate.calls.argsFor(0)[0]).toEqual(parentObject);
+        });
+    });
+
+    describe("when determining the object is applicable", () => {
+
+        beforeEach(() => {
+            removeAction = new RemoveAction(openmct);
+            spyOn(removeAction, 'appliesTo').and.callThrough();
+        });
+
+        it("should be true when the parent is creatable and has composition", () => {
+            let applies = removeAction.appliesTo([childObject, parentObject]);
+            expect(applies).toBe(true);
+        });
+
+        it("should be false when the child is locked", () => {
+            childObject.locked = true;
+            let applies = removeAction.appliesTo([childObject, parentObject]);
+            expect(applies).toBe(false);
+        });
+    });
+});

src/utils/testing.js

@@ -193,11 +193,7 @@ export function getMockObjects(opts = {}) {
     if (opts.overwrite) {
         for (let mock in requestedMocks) {
             if (opts.overwrite[mock]) {
-                for (let key in opts.overwrite[mock]) {
+                requestedMocks[mock] = Object.assign(requestedMocks[mock], opts.overwrite[mock]);
-                    if (Object.prototype.hasOwnProperty.call(opts.overwrite[mock], key)) {
-                        requestedMocks[mock][key] = opts.overwrite[mock][key];
-                    }
-                }
             }
         }
     }
@@ -254,6 +250,16 @@ function copyObj(obj) {
 function setMockObjects() {
     return {
         default: {
+            folder: {
+                identifier: {
+                    namespace: "",
+                    key: "folder-object"
+                },
+                name: "Test Folder Object",
+                type: "folder",
+                composition: [],
+                location: "mine"
+            },
             ladTable: {
                 identifier: {
                     namespace: "",