[Entanglement] Log a warning on cycle detection

nasa/openmctweb#84
2024-12-20 05:37:53 +00:00 · 2015-09-17 13:42:08 -07:00 · 2015-09-17 13:42:08 -07:00 · 88b8528aaf
commit 88b8528aaf
parent d1c0d81120
1 changed files with 12 additions and 3 deletions
--- a/platform/entanglement/src/services/LocatingObjectDecorator.js
+++ b/platform/entanglement/src/services/LocatingObjectDecorator.js
@ -69,9 +69,18 @@ define(
                }

                return objectService.getObjects([id]).then(function (objects) {
-                    return exclude[id] ?
-                            objects[id] : // Don't loop indefinitely.
-                            attachContextForLocation(objects[id]);
+                    if (exclude[id]) {
+                        $log.warn([
+                            "LocatingObjectDecorator detected a cycle",
+                            "while attempted to define a context for",
+                            id + ";",
+                            "no context will be added and unexpected behavior",
+                            "may follow."
+                        ].join(" "));
+                        return objects[id];
+                    }
+
+                    return attachContextForLocation(objects[id]);
                });
            }