[Edit Mode] #629 Rewrote obsolete DomainColumn tests

This commit is contained in:
Henry 2016-05-26 11:55:13 -07:00
parent 165e158f37
commit 7fc2fcfa07

View File

@ -30,23 +30,21 @@ define(
var TEST_DOMAIN_VALUE = "some formatted domain value"; var TEST_DOMAIN_VALUE = "some formatted domain value";
describe("A domain column", function () { describe("A domain column", function () {
var mockDataSet, var mockDatum,
testMetadata, testMetadata,
mockFormatter, mockFormatter,
column; column;
beforeEach(function () { beforeEach(function () {
mockDataSet = jasmine.createSpyObj(
"data",
["getDomainValue"]
);
mockFormatter = jasmine.createSpyObj( mockFormatter = jasmine.createSpyObj(
"formatter", "formatter",
["formatDomainValue", "formatRangeValue"] ["formatDomainValue", "formatRangeValue"]
); );
testMetadata = { testMetadata = {
key: "testKey", key: "testKey",
name: "Test Name" name: "Test Name",
format: "Test Format"
}; };
mockFormatter.formatDomainValue.andReturn(TEST_DOMAIN_VALUE); mockFormatter.formatDomainValue.andReturn(TEST_DOMAIN_VALUE);
@ -57,24 +55,24 @@ define(
expect(column.getTitle()).toEqual("Test Name"); expect(column.getTitle()).toEqual("Test Name");
}); });
xit("looks up data from a data set", function () { describe("when given a datum", function () {
column.getValue(undefined, mockDataSet, 42); beforeEach(function () {
expect(mockDataSet.getDomainValue) mockDatum = {
.toHaveBeenCalledWith(42, "testKey"); testKey: "testKeyValue"
}); };
});
xit("formats domain values as time", function () { it("looks up data from the given datum", function () {
mockDataSet.getDomainValue.andReturn(402513731000); expect(column.getValue(undefined, mockDatum))
.toEqual({ text: TEST_DOMAIN_VALUE });
});
// Should have just given the value the formatter gave it("uses formatter to format domain values as requested", function () {
expect(column.getValue(undefined, mockDataSet, 42).text) column.getValue(undefined, mockDatum);
.toEqual(TEST_DOMAIN_VALUE); expect(mockFormatter.formatDomainValue)
.toHaveBeenCalledWith("testKeyValue", "Test Format");
});
// Make sure that service interactions were as expected
expect(mockFormatter.formatDomainValue)
.toHaveBeenCalledWith(402513731000);
expect(mockFormatter.formatRangeValue)
.not.toHaveBeenCalled();
}); });
}); });