ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-03 08:00:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed bug which prevented historical images from loading. (#5271)

Browse Source 
* Fixed bug which prevented historical images from loading.

imageLoadDelay variable would be initialized as a string when it's supposed to be initialized as an integer.

* Updated image load delay in E2E test.

* Implemented suggested tweak for parsing image delay.

Co-authored-by: John Hill <john.c.hill@nasa.gov>
This commit is contained in:
Michael Pingleton 2022-06-09 17:25:33 -04:00 committed by GitHub
parent f08fd58486
commit 78002f0a24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js
View File

@ -249,10 +249,8 @@ test('Example Imagery in Display layout', async ({ page }) => {
await page.click('text=Example Imagery'); await page.click('text=Example Imagery');
// Clear and set Image load delay to minimum value // Clear and set Image load delay to minimum value
// FIXME: Update the value to 5000 ms when this bug is fixed.
// See: https://github.com/nasa/openmct/issues/5265
await page.locator('input[type="number"]').fill(''); await page.locator('input[type="number"]').fill('');
await page.locator('input[type="number"]').fill('0'); await page.locator('input[type="number"]').fill('5000');
// Click text=OK // Click text=OK
await Promise.all([ await Promise.all([

2
example/imagery/plugin.js
View File

@ -168,7 +168,7 @@ function getImageUrlListFromConfig(configuration) {
} }
function getImageLoadDelay(domainObject) { function getImageLoadDelay(domainObject) {
const imageLoadDelay = domainObject.configuration.imageLoadDelayInMilliSeconds; const imageLoadDelay = Math.trunc(Number(domainObject.configuration.imageLoadDelayInMilliSeconds));
if (!imageLoadDelay) { if (!imageLoadDelay) {
openmctInstance.objects.mutate(domainObject, 'configuration.imageLoadDelayInMilliSeconds', DEFAULT_IMAGE_LOAD_DELAY_IN_MILISECONDS); openmctInstance.objects.mutate(domainObject, 'configuration.imageLoadDelayInMilliSeconds', DEFAULT_IMAGE_LOAD_DELAY_IN_MILISECONDS);