Rename all configuration inspector tabs to Config (#7140)

This commit is contained in:
David Tsay 2023-10-12 13:48:13 -07:00 committed by GitHub
parent 26d3bd1e69
commit 76889cf60d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 10 additions and 11 deletions

View File

@ -40,7 +40,7 @@ test.describe('The Fault Management Plugin using example faults', () => {
}) => { }) => {
await utils.selectFaultItem(page, 1); await utils.selectFaultItem(page, 1);
await page.getByRole('tab', { name: 'Fault Management Configuration' }).click(); await page.getByRole('tab', { name: 'Config' }).click();
const selectedFaultName = await page const selectedFaultName = await page
.locator('.c-fault-mgmt__list.is-selected .c-fault-mgmt__list-faultname') .locator('.c-fault-mgmt__list.is-selected .c-fault-mgmt__list-faultname')
.textContent(); .textContent();
@ -65,7 +65,7 @@ test.describe('The Fault Management Plugin using example faults', () => {
); );
expect.soft(await selectedRows.count()).toEqual(2); expect.soft(await selectedRows.count()).toEqual(2);
await page.getByRole('tab', { name: 'Fault Management Configuration' }).click(); await page.getByRole('tab', { name: 'Config' }).click();
const firstSelectedFaultName = await selectedRows.nth(0).textContent(); const firstSelectedFaultName = await selectedRows.nth(0).textContent();
const secondSelectedFaultName = await selectedRows.nth(1).textContent(); const secondSelectedFaultName = await selectedRows.nth(1).textContent();
const firstNameInInspectorCount = await page const firstNameInInspectorCount = await page

View File

@ -6,7 +6,7 @@ import BarGraphOptions from './BarGraphOptions.vue';
export default function BarGraphInspectorViewProvider(openmct) { export default function BarGraphInspectorViewProvider(openmct) {
return { return {
key: BAR_GRAPH_INSPECTOR_KEY, key: BAR_GRAPH_INSPECTOR_KEY,
name: 'Bar Graph Configuration', name: 'Config',
canView: function (selection) { canView: function (selection) {
if (selection.length === 0 || selection[0].length === 0) { if (selection.length === 0 || selection[0].length === 0) {
return false; return false;

View File

@ -25,7 +25,7 @@ import EventEmitter from 'EventEmitter';
import { createOpenMct, resetApplicationState } from 'utils/testing'; import { createOpenMct, resetApplicationState } from 'utils/testing';
import Vue from 'vue'; import Vue from 'vue';
import { BAR_GRAPH_KEY, BAR_GRAPH_VIEW } from './BarGraphConstants'; import { BAR_GRAPH_INSPECTOR_KEY, BAR_GRAPH_KEY, BAR_GRAPH_VIEW } from './BarGraphConstants';
import BarGraphPlugin from './plugin'; import BarGraphPlugin from './plugin';
describe('the plugin', function () { describe('the plugin', function () {
@ -578,9 +578,7 @@ describe('the plugin', function () {
child.append(viewContainer); child.append(viewContainer);
const applicableViews = openmct.inspectorViews.get(selection); const applicableViews = openmct.inspectorViews.get(selection);
plotInspectorView = applicableViews.filter( plotInspectorView = applicableViews.filter((view) => view.key === BAR_GRAPH_INSPECTOR_KEY)[0];
(view) => view.name === 'Bar Graph Configuration'
)[0];
plotInspectorView.show(viewContainer); plotInspectorView.show(viewContainer);
await Vue.nextTick(); await Vue.nextTick();

View File

@ -29,7 +29,7 @@ export default function FaultManagementInspectorViewProvider(openmct) {
return { return {
openmct: openmct, openmct: openmct,
key: FAULT_MANAGEMENT_INSPECTOR, key: FAULT_MANAGEMENT_INSPECTOR,
name: 'Fault Management Configuration', name: 'Config',
canView: (selection) => { canView: (selection) => {
if (selection.length !== 1 || selection[0].length === 0) { if (selection.length !== 1 || selection[0].length === 0) {
return false; return false;

View File

@ -22,6 +22,7 @@
import { createOpenMct, resetApplicationState } from '../../utils/testing'; import { createOpenMct, resetApplicationState } from '../../utils/testing';
import { import {
FAULT_MANAGEMENT_INSPECTOR,
FAULT_MANAGEMENT_NAMESPACE, FAULT_MANAGEMENT_NAMESPACE,
FAULT_MANAGEMENT_TYPE, FAULT_MANAGEMENT_TYPE,
FAULT_MANAGEMENT_VIEW FAULT_MANAGEMENT_VIEW
@ -86,7 +87,7 @@ describe('The Fault Management Plugin', () => {
]; ];
const applicableInspectorViews = openmct.inspectorViews.get(faultDomainObjectSelection); const applicableInspectorViews = openmct.inspectorViews.get(faultDomainObjectSelection);
const faultManagementInspectorView = applicableInspectorViews.filter( const faultManagementInspectorView = applicableInspectorViews.filter(
(view) => view.name === 'Fault Management Configuration' (view) => view.key === FAULT_MANAGEMENT_INSPECTOR
); );
expect(faultManagementInspectorView.length).toEqual(1); expect(faultManagementInspectorView.length).toEqual(1);

View File

@ -296,7 +296,7 @@ describe('the plugin', function () {
]; ];
const applicableInspectorViews = openmct.inspectorViews.get(selection); const applicableInspectorViews = openmct.inspectorViews.get(selection);
const plotInspectorView = applicableInspectorViews.find( const plotInspectorView = applicableInspectorViews.find(
(view) => (view.name = 'Plots Configuration') (view) => view.key === 'plots-inspector'
); );
expect(plotInspectorView).toBeDefined(); expect(plotInspectorView).toBeDefined();

View File

@ -28,7 +28,7 @@ import TelemetryTableConfiguration from './TelemetryTableConfiguration';
export default function TableConfigurationViewProvider(openmct) { export default function TableConfigurationViewProvider(openmct) {
return { return {
key: 'table-configuration', key: 'table-configuration',
name: 'Configuration', name: 'Config',
canView: function (selection) { canView: function (selection) {
if (selection.length !== 1 || selection[0].length === 0) { if (selection.length !== 1 || selection[0].length === 0) {
return false; return false;