ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-06-01 07:00:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Addressed issues from code review

Browse Source
This commit is contained in:
Henry 2016-02-29 18:42:48 -08:00
parent 5292b27e7d
commit 747a98d130
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
platform/commonUI/notification/src/NotificationService.js
View File

@ -67,7 +67,7 @@ define(
* be automatically minimized or dismissed (depending on severity). * be automatically minimized or dismissed (depending on severity).
* Additionally, if the provided value is a number, it will be used * Additionally, if the provided value is a number, it will be used
* as the delay period before being dismissed. * as the delay period before being dismissed.
* @property {boolean} [dismissable=true] If truthy, notification will * @property {boolean} [dismissable=true] If true, notification will
* include an option to dismiss it completely. * include an option to dismiss it completely.
* @property {NotificationOption} [primaryOption] the default user * @property {NotificationOption} [primaryOption] the default user
* response to * response to

7
platform/core/src/capabilities/PersistenceCapability.js
View File

@ -104,15 +104,14 @@ define(
* persistence. * persistence.
*/ */
function notifyOnError(error, domainObject, notificationService, $q){ function notifyOnError(error, domainObject, notificationService, $q){
var errorMessage = "Unable to persist " + domainObject.getModel().name, var errorMessage = "Unable to persist " + domainObject.getModel().name;
notification;
if (error) { if (error) {
errorMessage += ": " + formatError(error); errorMessage += ": " + formatError(error);
} }
notification = notificationService.error({ notificationService.error({
title: "Error persisting " + domainObject.getModel().name, title: "Error persisting " + domainObject.getModel().name,
hint: errorMessage || "Unknown error", hint: errorMessage,
dismissable: true dismissable: true
}); });