Addressed issues from code review

This commit is contained in:
Henry 2016-02-29 18:42:48 -08:00
parent 5292b27e7d
commit 747a98d130
2 changed files with 4 additions and 5 deletions

View File

@ -67,7 +67,7 @@ define(
* be automatically minimized or dismissed (depending on severity).
* Additionally, if the provided value is a number, it will be used
* as the delay period before being dismissed.
* @property {boolean} [dismissable=true] If truthy, notification will
* @property {boolean} [dismissable=true] If true, notification will
* include an option to dismiss it completely.
* @property {NotificationOption} [primaryOption] the default user
* response to

View File

@ -104,15 +104,14 @@ define(
* persistence.
*/
function notifyOnError(error, domainObject, notificationService, $q){
var errorMessage = "Unable to persist " + domainObject.getModel().name,
notification;
var errorMessage = "Unable to persist " + domainObject.getModel().name;
if (error) {
errorMessage += ": " + formatError(error);
}
notification = notificationService.error({
notificationService.error({
title: "Error persisting " + domainObject.getModel().name,
hint: errorMessage || "Unknown error",
hint: errorMessage,
dismissable: true
});