ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-01-19 03:06:54 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

[Tree] Don't assume context capability is present

Browse Source 
Addresses #753 (newly-created objects may not have context,
causing errors when these are encountered by TreeNodeView)
This commit is contained in:
Victor Woeltjen 2016-03-16 14:04:03 -07:00
parent d30532a8bc
commit 73b7365ae2
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
platform/commonUI/general/src/ui/TreeNodeView.js
View File

@ -81,13 +81,13 @@ define([
};
function getIdPath(domainObject) {
var context = domainObject && domainObject.getCapability('context');
function getId(domainObject) {
return domainObject.getId();
}
return domainObject ?
domainObject.getCapability('context').getPath().map(getId) :
[];
return context ? context.getPath().map(getId) : [];
}
TreeNodeView.prototype.value = function (domainObject) {

15
platform/commonUI/general/test/ui/TreeViewSpec.js
View File

@ -200,6 +200,21 @@ define([
});
});
describe("when a context-less object is selected", function () {
beforeEach(function () {
var testCapabilities = makeGenericCapabilities(),
mockDomainObject =
makeMockDomainObject('xyz', {}, testCapabilities);
delete testCapabilities.context;
treeView.value(mockDomainObject);
});
it("clears all selection state", function () {
var selected = $(treeView.elements()[0]).find('.selected');
expect(selected.length).toEqual(0);
});
});
describe("when children contain children", function () {
beforeEach(function () {
var newCapabilities = makeGenericCapabilities(),