From 71c43dee65f8867cc4f1fba25d06105fde7be42c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 26 Jul 2022 11:33:42 -0700 Subject: [PATCH] Bump eslint-plugin-playwright from 0.9.0 to 0.10.0 (#5559) * Bump eslint-plugin-playwright from 0.9.0 to 0.10.0 Bumps [eslint-plugin-playwright](https://github.com/playwright-community/eslint-plugin-playwright) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/playwright-community/eslint-plugin-playwright/releases) - [Commits](https://github.com/playwright-community/eslint-plugin-playwright/compare/v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: eslint-plugin-playwright dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] * Fix new lint warning Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jesse Mazzella Co-authored-by: Jesse Mazzella --- e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js | 7 ++----- package.json | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js b/e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js index 4ef561d010..48242975bf 100644 --- a/e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js +++ b/e2e/tests/plugins/imagery/exampleImagery.e2e.spec.js @@ -31,6 +31,8 @@ const { expect } = require('@playwright/test'); const { waitForAnimations } = require('../../../commonActions.js'); const backgroundImageSelector = '.c-imagery__main-image__background-image'; +const panHotkey = process.platform === 'linux' ? ['Control', 'Alt'] : ['Alt']; +const expectedAltText = process.platform === 'linux' ? 'Ctrl+Alt drag to pan' : 'Alt drag to pan'; //The following block of tests verifies the basic functionality of example imagery and serves as a template for Imagery objects embedded in other objects. test.describe('Example Imagery Object', () => { @@ -96,7 +98,6 @@ test.describe('Example Imagery Object', () => { test('Can use alt+drag to move around image once zoomed in', async ({ page }) => { const deltaYStep = 100; //equivalent to 1x zoom - const panHotkey = process.platform === 'linux' ? ['Control', 'Alt'] : ['Alt']; await page.locator(backgroundImageSelector).hover({trial: true}); @@ -116,7 +117,6 @@ test.describe('Example Imagery Object', () => { const getUA = await page.evaluate(() => navigator.userAgent); console.log('navigator.userAgent ' + getUA); // Pan Imagery Hints - const expectedAltText = process.platform === 'linux' ? 'Ctrl+Alt drag to pan' : 'Alt drag to pan'; const imageryHintsText = await page.locator('.c-imagery__hints').innerText(); expect(expectedAltText).toEqual(imageryHintsText); @@ -289,7 +289,6 @@ test('Example Imagery in Display layout', async ({ page, browserName }) => { await page.mouse.move(imageCenterX, imageCenterY); // Pan Imagery Hints - const expectedAltText = process.platform === 'linux' ? 'Ctrl+Alt drag to pan' : 'Alt drag to pan'; const imageryHintsText = await page.locator('.c-imagery__hints').innerText(); expect(expectedAltText).toEqual(imageryHintsText); @@ -680,8 +679,6 @@ async function assertBackgroundImageUrlFromBackgroundCss(page) { * @param {import('@playwright/test').Page} page */ async function panZoomAndAssertImageProperties(page) { - const panHotkey = process.platform === 'linux' ? ['Control', 'Alt'] : ['Alt']; - const expectedAltText = process.platform === 'linux' ? 'Ctrl+Alt drag to pan' : 'Alt drag to pan'; const imageryHintsText = await page.locator('.c-imagery__hints').innerText(); expect(expectedAltText).toEqual(imageryHintsText); const zoomedBoundingBox = await page.locator(backgroundImageSelector).boundingBox(); diff --git a/package.json b/package.json index b1035136bf..d20f5fe1fa 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,7 @@ "d3-selection": "3.0.0", "eslint": "8.18.0", "eslint-plugin-compat": "4.0.2", - "eslint-plugin-playwright": "0.9.0", + "eslint-plugin-playwright": "0.10.0", "eslint-plugin-vue": "9.1.1", "eslint-plugin-you-dont-need-lodash-underscore": "6.12.0", "eventemitter3": "1.2.0",