From 6ce340cebd423b19e35595258c7981a644a80278 Mon Sep 17 00:00:00 2001 From: John Hill Date: Thu, 11 Jan 2024 14:47:00 -0800 Subject: [PATCH] [e2e] Update remaining tests and add missing comparison coverage (#7363) --- .cspell.json | 1 - .github/workflows/e2e-couchdb.yml | 3 +- .gitignore | 3 + TESTING.md | 5 +- e2e/playwright-ci.config.js | 3 +- e2e/playwright-watch.config.js | 13 +- .../display_layout_with_child_layouts.json | 4 +- .../flexible_layout_with_child_layouts.json | 4 +- e2e/test-data/overlay_plot_storage.json | 4 +- .../overlay_plot_with_delay_storage.json | 2 +- e2e/test-data/recycled_local_storage.json | 4 +- e2e/tests/framework/appActions.e2e.spec.js | 2 +- .../generateLocalStorageData.e2e.spec.js | 23 ++- e2e/tests/functional/branding.e2e.spec.js | 30 ++- .../functional/clearDataAction.e2e.spec.js | 15 +- .../sineWaveLimitProvider.e2e.spec.js | 2 +- e2e/tests/functional/forms.e2e.spec.js | 10 +- e2e/tests/functional/notification.e2e.spec.js | 2 +- .../planning/ganttChart.e2e.spec.js | 2 +- .../plugins/clocks/clock.e2e.spec.js | 2 +- .../conditionSet/conditionSet.e2e.spec.js | 11 +- .../displayLayout/displayLayout.e2e.spec.js | 16 +- .../flexibleLayout/flexibleLayout.e2e.spec.js | 14 +- .../plugins/gauge/gauge.e2e.spec.js | 12 +- .../imagery/exampleImagery.e2e.spec.js | 12 +- .../functional/plugins/lad/lad.e2e.spec.js | 16 +- .../notebook/notebookSnapshots.e2e.spec.js | 15 +- .../plugins/notebook/tags.e2e.spec.js | 2 +- .../plugins/plot/autoscale.e2e.spec.js | 2 +- .../plugins/plot/logPlot.e2e.spec.js | 2 +- .../plugins/plot/overlayPlot.e2e.spec.js | 8 +- .../plugins/plot/scatterPlot.e2e.spec.js | 11 +- .../plugins/plot/stackedPlot.e2e.spec.js | 14 +- .../styling/flexLayoutStyling.e2e.spec.js | 14 +- .../styling/stackedPlotStyling.e2e.spec.js | 4 +- .../styling/styleInspectorOptions.e2e.spec.js | 2 +- .../telemetryTable/telemetryTable.e2e.spec.js | 5 +- .../functional/recentObjects.e2e.spec.js | 6 +- e2e/tests/functional/search.e2e.spec.js | 2 +- e2e/tests/functional/smoke.e2e.spec.js | 2 +- e2e/tests/functional/tooltips.e2e.spec.js | 12 +- .../components/about.visual.spec.js | 24 ++- .../components/header.visual.spec.js | 56 ++++++ .../components/inspector.visual.spec.js | 7 +- .../components/tree.visual.spec.js | 3 + .../controlledClock.visual.spec.js | 13 +- .../visual-a11y/defaultPlugins.visual.spec.js | 19 +- .../visual-a11y/displayLayout.visual.spec.js | 173 ++++++------------ e2e/tests/visual-a11y/ladTable.visual.spec.js | 13 +- .../visual-a11y/notification.visual.spec.js | 71 ++++--- e2e/tests/visual-a11y/search.visual.spec.js | 2 +- e2e/tests/visual-a11y/styling.visual.spec.js | 4 +- .../visual-a11y/telemetryViews.visual.spec.js | 78 ++++++++ package.json | 1 - src/api/menu/components/MenuComponent.vue | 2 + src/api/menu/components/SuperMenu.vue | 1 + src/plugins/autoflow/autoflow-tabular.html | 3 +- .../components/TelemetryView.vue | 7 +- .../FaultManagementListItem.vue | 1 + .../folderView/components/GridItem.vue | 14 +- .../folderView/components/GridView.vue | 3 +- .../folderView/components/ListItem.vue | 6 +- .../gauge/components/GaugeComponent.vue | 1 + .../imagery/components/ImageControls.vue | 14 +- .../imagery/components/ImageThumbnail.vue | 1 + .../components/ImageryViewMenuSwitcher.vue | 1 + .../styles/SavedStyleSelector.vue | 7 +- .../components/NotebookMenuSwitcher.vue | 1 + .../pollQuestion/PollQuestion.vue | 1 + src/plugins/plot/MctTicks.vue | 2 + src/plugins/plot/chart/MctChart.vue | 6 +- src/plugins/tabs/components/TabsComponent.vue | 6 +- .../telemetryTable/components/TableCell.vue | 1 + .../components/TableComponent.vue | 12 +- .../components/TableFooterIndicator.vue | 3 + .../timeConductor/ConductorInputsRealtime.vue | 3 + .../timeConductor/ConductorTimeSystem.vue | 1 + src/ui/color/ColorSwatch.vue | 4 +- src/ui/components/List/ListItem.vue | 1 + src/ui/components/List/ListView.vue | 1 + src/ui/components/ObjectFrame.vue | 7 +- src/ui/components/ObjectLabel.vue | 6 +- src/ui/components/swim-lane/SwimLane.vue | 7 +- src/ui/inspector/ObjectName.vue | 6 +- src/ui/layout/AboutDialog.vue | 17 +- src/ui/layout/AppLayout.vue | 2 + src/ui/layout/AppLogo.vue | 8 +- src/ui/layout/BrowseBar.vue | 7 +- 88 files changed, 561 insertions(+), 382 deletions(-) create mode 100644 e2e/tests/visual-a11y/components/header.visual.spec.js create mode 100644 e2e/tests/visual-a11y/telemetryViews.visual.spec.js diff --git a/.cspell.json b/.cspell.json index 1baa99e4ad..c0cdccee06 100644 --- a/.cspell.json +++ b/.cspell.json @@ -43,7 +43,6 @@ "sharded", "perfromance", "MMOC", - "deploysentinel", "codegen", "Unfortuantely", "viewports", diff --git a/.github/workflows/e2e-couchdb.yml b/.github/workflows/e2e-couchdb.yml index 07b62013b4..5333ee82f1 100644 --- a/.github/workflows/e2e-couchdb.yml +++ b/.github/workflows/e2e-couchdb.yml @@ -47,9 +47,8 @@ jobs: bash src/plugins/persistence/couch/setup-couchdb.sh bash src/plugins/persistence/couch/replace-localstorage-with-couchdb-indexhtml.sh - - name: Run CouchDB Tests and publish to deploysentinel + - name: Run CouchDB Tests env: - DEPLOYSENTINEL_API_KEY: ${{ secrets.DEPLOYSENTINEL_API_KEY }} COMMIT_INFO_SHA: ${{github.event.pull_request.head.sha }} run: npm run test:e2e:couchdb diff --git a/.gitignore b/.gitignore index a865c26db3..e3185bee0b 100644 --- a/.gitignore +++ b/.gitignore @@ -15,6 +15,9 @@ *.idea *.iml +# VSCode +.vscode/settings.json + # Build output target dist diff --git a/TESTING.md b/TESTING.md index e5c6e04da4..68e4e3ad1f 100644 --- a/TESTING.md +++ b/TESTING.md @@ -85,9 +85,8 @@ There are a few reasons that your GitHub PR could be failing beyond simple faile * Not all required checks are run per commit. You may need to manually trigger addition GitHub checks with a `pr: