ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-01-30 08:04:03 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

[Table] Retain rows in scope (#1813)

Browse Source 
* [Table] Push rows in as they are added

...such that sorting does not cause real-time table rows to be lost.
Fixes #1738

* [Table] Test adding rows

* [Table] Fix code style in test

https://github.com/nasa/openmct/pull/1813#pullrequestreview-78277635
This commit is contained in:
Victor Woeltjen 2017-11-22 11:05:03 -08:00 committed by Pete Richards
parent 06e93ff520
commit 6bbdfcdfbe
2 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
platform/features/table/src/controllers/TelemetryTableController.js
View File

@ -170,6 +170,9 @@ define(
* @param rows * @param rows
*/ */
TelemetryTableController.prototype.addRowsToTable = function (rows) { TelemetryTableController.prototype.addRowsToTable = function (rows) {
rows.forEach(function (row) {
this.$scope.rows.push(row);
}, this);
this.$scope.$broadcast('add:rows', rows); this.$scope.$broadcast('add:rows', rows);
}; };

23
platform/features/table/test/controllers/TelemetryTableControllerSpec.js
View File

@ -436,5 +436,28 @@ define(
expect(mockScope.$broadcast).toHaveBeenCalledWith("remove:rows", discardedRows); expect(mockScope.$broadcast).toHaveBeenCalledWith("remove:rows", discardedRows);
}); });
describe('when telemetry is added', function () {
var testRows;
var expectedRows;
beforeEach(function () {
testRows = [{ a: 0 }, { a: 1 }, { a: 2 }];
mockScope.rows = [{ a: -1 }];
expectedRows = mockScope.rows.concat(testRows);
spyOn(controller.telemetry, "on").andCallThrough();
controller.registerChangeListeners();
controller.telemetry.on.calls.forEach(function (call) {
if (call.args[0] === 'added') {
call.args[1](testRows);
}
});
});
it("adds it to rows in scope", function () {
expect(mockScope.rows).toEqual(expectedRows);
});
});
}); });
}); });