[Style] check if there is an element to style before applying style (#3950)

* check if there is an element to style

* add mmgis (external plugin) type to style exclusion list

* revert b919cf9 to be fixed properly

* reduce code
This commit is contained in:
David Tsay 2021-06-15 16:03:23 -07:00 committed by GitHub
parent 6483fe2402
commit 64e7c62d98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -118,10 +118,11 @@ export default {
this.openmct.objectViews.off('clearData', this.clearData);
},
getStyleReceiver() {
let styleReceiver = this.$el.querySelector('.js-style-receiver');
let styleReceiver = this.$el.querySelector('.js-style-receiver')
|| this.$el.querySelector(':first-child');
if (!styleReceiver) {
styleReceiver = this.$el.querySelector(':first-child');
if (styleReceiver === null) {
styleReceiver = undefined;
}
return styleReceiver;
@ -142,12 +143,13 @@ export default {
this.updateView(true);
},
updateStyle(styleObj) {
if (!styleObj) {
let elemToStyle = this.getStyleReceiver();
if (!styleObj || elemToStyle === undefined) {
return;
}
let keys = Object.keys(styleObj);
let elemToStyle = this.getStyleReceiver();
keys.forEach(key => {
if (elemToStyle) {
@ -373,11 +375,17 @@ export default {
},
setFontSize(newSize) {
let elemToStyle = this.getStyleReceiver();
elemToStyle.dataset.fontSize = newSize;
if (elemToStyle !== undefined) {
elemToStyle.dataset.fontSize = newSize;
}
},
setFont(newFont) {
let elemToStyle = this.getStyleReceiver();
elemToStyle.dataset.font = newFont;
if (elemToStyle !== undefined) {
elemToStyle.dataset.font = newFont;
}
}
}
};