[Plots] #638 Addressing feedback from code review

[Plots] #638 Fixing failing tests

[Plot] Changed PlotOptionsController to prototype form

Fixed spacing

Fixed jslint issue
This commit is contained in:
Henry
2016-02-08 23:05:48 -08:00
parent be031285b9
commit 645bd5743f
15 changed files with 188 additions and 357 deletions

View File

@ -36,7 +36,7 @@ define(
* @constructor
*/
function InspectorRegion() {
Region.call(this);
Region.call(this, {'name': 'Inspector'});
this.buildRegion();
}
@ -48,9 +48,9 @@ define(
* @private
*/
InspectorRegion.prototype.buildRegion = function() {
var metadataPart = {
name: 'properties-location',
title: 'Properties and Location',
var metadataRegion = {
name: 'metadata',
title: 'Metadata Region',
// Which modes should the region part be visible in? If
// nothing provided here, then assumed that part is visible
// in both. The visibility or otherwise of a region part
@ -61,7 +61,7 @@ define(
key: 'object-properties'
}
};
this.addPart(metadataPart, 0);
this.addRegion(new Region(metadataRegion), 0);
};
return InspectorRegion;