[Plot] Fix wiring on plot updater

Fix usages of the plot updater, introduced to track real-time
telemetry to remove the need to cache values elsewhere. This
allows memory usage to be decreased for WTD-751.

platform/features/plot/bundle.json

@@ -21,7 +21,7 @@
             {
                 "key": "PlotController",
                 "implementation": "PlotController.js",
-                "depends": [ "$scope", "telemetryFormatter" ]
+                "depends": [ "$scope", "telemetryFormatter", "telemetrySubscriber" ]
             }
         ]
     }

platform/features/plot/res/templates/plot.html

@@ -113,7 +113,7 @@
 
                 </div>
 
-                <span class="t-wait-spinner loading" ng-show="plot.isRequestPending">
+                <span class="t-wait-spinner loading" ng-show="plot.isRequestPending()">
                 </span>
             </div>
             <div ng-if="$last" class="gl-plot-axis-area gl-plot-x">

platform/features/plot/src/PlotController.js

@@ -78,7 +78,10 @@ define(
             }
 
             function updateValues() {
-                modeOptions.getModeHandler().plotTelemetry(updater);
+                if (updater) {
+                    updater.update();
+                    modeOptions.getModeHandler().plotTelemetry(updater);
+                }
                 update();
             }
 
@@ -92,8 +95,10 @@ define(
                     domainObject,
                     updateValues
                 );
-                setupAxes(subscription.getMetadata());
+                if (subscription) {
-                recreateUpdater();
+                    setupAxes(subscription.getMetadata());
+                    recreateUpdater();
+                }
             }
 
             $scope.$watch('domainObject', subscribe);

platform/features/plot/src/modes/PlotOverlayMode.js

@@ -38,7 +38,7 @@ define(
                     return {
                         buffer: buf,
                         color: PlotPalette.getFloatColor(i),
-                        points: buf.length / 2
+                        points: prepared.getLength(i)
                     };
                 });
 

platform/features/plot/src/modes/PlotStackMode.js

@@ -35,7 +35,7 @@ define(
                 subplot.getDrawingObject().lines = [{
                     buffer: buffer,
                     color: PlotPalette.getFloatColor(0),
-                    points: buffer.length / 2
+                    points: prepared.getLength(index)
                 }];
 
                 subplot.update();