Addressed PR review comments.

This commit is contained in:
Rukmini Bose 2022-10-08 17:21:50 -07:00
parent a742c35ff9
commit 54f06d36a5
5 changed files with 31 additions and 14 deletions

View File

@ -127,15 +127,15 @@ export default {
id: 'navigateToItem',
cssClass: this.embed.cssClass,
name: 'Navigate to Item',
description: 'Navigate to the item with the default time settings.',
description: 'Navigate to the item with the current time settings.',
onItemClicked: () => this.navigateToItem()
};
const navigateToItemInTime = {
id: 'navigateToItemInTime',
cssClass: 'icon-telemetry',
cssClass: this.embed.cssClass,
name: 'Navigate to Item in Time',
description: 'Navigate to the item with the given time context.',
description: 'Navigate to the item in its time frame when captured.',
onItemClicked: () => this.navigateToItemInTime()
};

View File

@ -31,14 +31,16 @@
>
<div class="c-ne__time-and-content">
<div class="c-ne__time-and-creator-and-delete">
<span class="c-ne__created-date">{{ createdOnDate }}</span>
<span class="c-ne__created-time">{{ createdOnTime }}</span>
<span
v-if="entry.createdBy"
class="c-ne__creator"
>
<span class="icon-person"></span> {{ entry.createdBy }}
</span>
<div class="c-ne__time-and-creator">
<span class="c-ne__created-date">{{ createdOnDate }}</span>
<span class="c-ne__created-time">{{ createdOnTime }}</span>
<span
v-if="entry.createdBy"
class="c-ne__creator"
>
<span class="icon-person"></span> {{ entry.createdBy }}
</span>
</div>
<span
v-if="!readOnly && !isLocked"
class="c-ne__local-controls--hidden"

View File

@ -31,7 +31,7 @@
// Class for overflow embeds (possibly for text entry overflow in future)
margin-top: $interiorMargin;
background: $scrollContainer;
box-shadow: inset 0 3px 4px rgb(0 0 0 / 40%);
box-shadow: $shdwInputFoc;
border-radius: $controlCr;
}
@ -307,6 +307,16 @@
&__input {
padding: $p;
}
&__time-and-creator-and-delete{
display: flex;
align-items: center;
> * + *{
float: right;
margin-left: auto;
}
}
&__creator [class*='icon'] {
font-size: 0.95em;
@ -315,7 +325,7 @@
&__time-and-content {
display: block;
flex: 1 1 auto;
overflow: auto;
overflow: visible;
> * + * {
margin-top: $interiorMarginSm;
@ -456,6 +466,7 @@
}
&__link {
flex: 1 1 auto;
&:before {
display: block;
font-size: 1em;

View File

@ -37,7 +37,7 @@
title="Add new tag"
@click="addTag"
>
<div class="c-icon-button__label">Add Tag</div>
<div class="c-icon-button__label c-tag-btn__label">Add Tag</div>
</button>
</div>
</template>

View File

@ -54,6 +54,10 @@
}
}
.c-tag-btn__label {
overflow: visible!important;
}
/******************************* HOVERS */
.has-tag-applier {
// Apply this class to all components that should trigger tag removal btn on hover