From 318df9878dca993689a05dbd5f08d4d9f75363d9 Mon Sep 17 00:00:00 2001 From: Charles Hacskaylo Date: Wed, 9 Mar 2016 17:22:41 -0800 Subject: [PATCH 1/7] [Frontend] Cleanups to Inspector config elements open #729 In-progress! Markup and CSS modified to cleanup control layout and styling in Plot and Table config options; gulpfile.js modified to include SASS source line numbers in rendered CSS; --- gulpfile.js | 3 +- .../commonUI/general/res/sass/_inspector.scss | 18 +++++- .../general/res/sass/forms/_elems.scss | 24 ++++---- .../res/templates/plot-options-browse.html | 58 ++++++++++--------- .../res/templates/table-options-edit.html | 2 +- 5 files changed, 61 insertions(+), 44 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index fa832d1aa6..0df0aa2ae6 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -60,7 +60,8 @@ var gulp = require('gulp'), singleRun: true }, sass: { - includePaths: bourbon.includePaths + includePaths: bourbon.includePaths, + sourceComments: true }, replace: { variables: { diff --git a/platform/commonUI/general/res/sass/_inspector.scss b/platform/commonUI/general/res/sass/_inspector.scss index 7ee9cadf27..b371dd65d1 100644 --- a/platform/commonUI/general/res/sass/_inspector.scss +++ b/platform/commonUI/general/res/sass/_inspector.scss @@ -61,9 +61,23 @@ .l-inspector-part { box-sizing: border-box; padding-right: $interiorMargin; - .form { + .tree .form { margin-left: $treeVCW + $interiorMarginLg; - margin-bottom: $interiorMarginLg; + } + .section-header { + background: none; + color: $colorInspectorPropName; + border-radius: unset; + font-size: inherit; + padding: $interiorMarginSm 0; + } + + mct-form:not(:last-child) .form { + border-bottom: 1px solid $colorInspectorSectionHeaderBg; + } + + .form { + margin-bottom: $interiorMargin; .form-section { margin-bottom: 0; &:not(.first) { diff --git a/platform/commonUI/general/res/sass/forms/_elems.scss b/platform/commonUI/general/res/sass/forms/_elems.scss index 4c5cbc5c3a..a48a8cfda4 100644 --- a/platform/commonUI/general/res/sass/forms/_elems.scss +++ b/platform/commonUI/general/res/sass/forms/_elems.scss @@ -19,16 +19,6 @@ * this source code distribution or the Licensing information page available * at runtime from the About dialog for additional information. *****************************************************************************/ -.section-header { - border-radius: $basicCr; - background: $colorFormSectionHeader; - $c: lighten($colorBodyFg, 20%); - color: $c; - font-size: 0.8em; - padding: $formTBPad $formLRPad; - text-transform: uppercase; -} - .form { color: $colorFormText; width: 100%; @@ -37,6 +27,16 @@ margin-bottom: $interiorMarginLg * 2; } + .section-header { + border-radius: $basicCr; + background: $colorFormSectionHeader; + $c: lighten($colorBodyFg, 20%); + color: $c; + font-size: 0.8em; + padding: $formTBPad $formLRPad; + text-transform: uppercase; + } + .form-row { $m: $interiorMargin; box-sizing: border-box; @@ -52,9 +52,9 @@ >.label, >.controls { box-sizing: border-box; - @include clearfix; + //@include clearfix; font-size: 0.8rem; - line-height: $formInputH; + //line-height: $formInputH; min-height: $formInputH; } diff --git a/platform/features/plot/res/templates/plot-options-browse.html b/platform/features/plot/res/templates/plot-options-browse.html index 8def5cdc9c..123ed43194 100644 --- a/platform/features/plot/res/templates/plot-options-browse.html +++ b/platform/features/plot/res/templates/plot-options-browse.html @@ -41,36 +41,38 @@ name="yAxisFormState" class="flex-elem l-flex-row no-validate no-margin reduced-min-width"> -
- Plot Series -
-