Addressing feedback

This commit is contained in:
Khalid Adil 2024-09-30 18:53:08 -05:00
parent 7896f36748
commit 4b39ea232a
4 changed files with 7 additions and 25 deletions

View File

@ -24,7 +24,7 @@ import { EventEmitter } from 'eventemitter3';
import { v4 as uuid } from 'uuid';
import Condition from './Condition.js';
import HistoricalTelemetryProvider from './historicalTelemetryProvider.js';
import HistoricalTelemetryProvider from './HistoricalTelemetryProvider.js';
import { getLatestTimestamp } from './utils/time.js';
export default class ConditionManager extends EventEmitter {

View File

@ -352,18 +352,12 @@ export default {
methods: {
setOutputSelection() {
let conditionOutput = this.condition.configuration.output;
if (conditionOutput) {
if (
conditionOutput !== 'false' &&
conditionOutput !== 'true' &&
conditionOutput !== 'telemetry value'
) {
this.selectedOutputSelection = 'string';
} else {
this.selectedOutputSelection = conditionOutput;
}
} else if (conditionOutput === undefined) {
if (conditionOutput === undefined) {
this.selectedOutputSelection = 'none';
} else if (['false', 'true', 'telemetry value'].includes(conditionOutput)) {
this.selectedOutputSelection = conditionOutput;
} else {
this.selectedOutputSelection = 'string';
}
},
setOutputValue() {

View File

@ -63,7 +63,7 @@
:key="index"
:value="telemetryOption.identifier"
>
{{ telemetryPaths[index] || telemetryOption.name }}
{{ telemetryOption.path || telemetryOption.name }}
</option>
</select>
</span>
@ -201,10 +201,6 @@ export default {
this.telemetryMetadataOptions[id] = [];
}
});
this.telemetry.forEach(async (telemetryOption, index) => {
const telemetryPath = await this.getFullTelemetryPath(telemetryOption);
this.telemetryPaths[index] = telemetryPath;
});
},
addTestInput(testInput) {
this.testInputs.push(

View File

@ -15,14 +15,6 @@ export default class HistoricalTelemetryProvider {
this.bounds = bounds;
}
refreshAllHistoricalTelemetries() {
const refreshPromises = [];
for (const [, value] of Object.entries(this.telemetryObjects)) {
refreshPromises.push(this.refreshHistoricalTelemetry(value));
}
return Promise.all(refreshPromises);
}
async refreshHistoricalTelemetry(domainObject, identifier) {
console.log('refreshHistoricalTelemetry');
if (!domainObject && identifier) {