Build columns from union of telemetry value metadata. (#2075)

* Build columns from union of telemetry value metadata. Do not manually clean up scope. Fixes #2027. Fixes #1884. Fixes #1817.

* Fixed tests that are failing on circle-ci

* Inlined getMetadataValues function
This commit is contained in:
Andrew Henry
2018-06-21 10:50:43 -07:00
committed by Pete Richards
parent a3e78bbf91
commit 45a152df86
4 changed files with 22 additions and 17 deletions

View File

@ -116,7 +116,11 @@ define(
formatter.parse.andCallFake(getter);
return formatter;
});
mockTelemetryAPI.getMetadata.andReturn({
values: function () {
return [];
}
});
mockTelemetryAPI.isTelemetryObject.andReturn(false);
mockTimeout = jasmine.createSpy("timeout");
@ -363,7 +367,11 @@ define(
mockTelemetryAPI.commonValuesForHints.andCallFake(function (metadata, hints) {
if (_.eq(hints, ["domain"])) {
return domainMetadata;
} else if (_.eq(hints, [])) {
}
});
mockTelemetryAPI.getMetadata.andReturn({
values: function () {
return allMetadata;
}
});