Merge pull request #803 from nasa/drag-drop-688

[Firefox] Invoke preventDefault on drop
This commit is contained in:
Victor Woeltjen 2016-03-31 11:02:26 -07:00
commit 4441e88769
4 changed files with 13 additions and 1 deletions

View File

@ -91,6 +91,7 @@ define(
if (id) { if (id) {
event.stopPropagation(); event.stopPropagation();
e.preventDefault();
// Delegate the drop to the swimlane itself // Delegate the drop to the swimlane itself
swimlane.drop(id, droppedObject); swimlane.drop(id, droppedObject);
} }

View File

@ -162,6 +162,11 @@ define(
expect(mockScope.$apply).toHaveBeenCalled(); expect(mockScope.$apply).toHaveBeenCalled();
}); });
it("invokes preventDefault on drop", function () {
handlers.drop(testEvent);
expect(testEvent.preventDefault).toHaveBeenCalled();
});
it("clears highlights when drag leaves", function () { it("clears highlights when drag leaves", function () {
mockSwimlane.highlight.andReturn(true); mockSwimlane.highlight.andReturn(true);
handlers.dragleave(); handlers.dragleave();

View File

@ -123,6 +123,7 @@ define(
// destination domain object's composition, and persist // destination domain object's composition, and persist
// the change. // the change.
if (id) { if (id) {
e.preventDefault();
$q.when(action && action.perform()).then(function (result) { $q.when(action && action.perform()).then(function (result) {
//Don't go into edit mode for folders //Don't go into edit mode for folders
if (domainObjectType!=='folder') { if (domainObjectType!=='folder') {

View File

@ -194,6 +194,11 @@ define(
); );
}); });
it("invokes preventDefault on drop", function () {
callbacks.drop(mockEvent);
expect(mockEvent.preventDefault).toHaveBeenCalled();
});
}); });
} }
); );