From 4411bb0a2d2c0d3c7e7ffed488a7586220d373ac Mon Sep 17 00:00:00 2001
From: Charles Hacskaylo <charlesh88@gmail.com>
Date: Tue, 30 Jun 2020 16:12:28 -0700
Subject: [PATCH] UI fixes for NIRVSS #170 (#3141)

* UI fixes for NIRVSS client #170
---
 src/styles/_legacy-plots.scss   | 39 +++++++++++++++++----------------
 src/styles/_legacy.scss         |  2 +-
 src/ui/inspector/inspector.scss |  2 +-
 3 files changed, 22 insertions(+), 21 deletions(-)

diff --git a/src/styles/_legacy-plots.scss b/src/styles/_legacy-plots.scss
index ba4a5c21d6..a7969d0ea9 100644
--- a/src/styles/_legacy-plots.scss
+++ b/src/styles/_legacy-plots.scss
@@ -114,25 +114,6 @@ mct-plot {
     .plot-wrapper-axis-and-display-area {
         position: relative;
         flex: 1 1 auto;
-
-        .l-state-indicators {
-            color: $colorPausedBg;
-            position: absolute;
-            display: block;
-            font-size: 1.5em;
-            pointer-events: none;
-            top: $interiorMarginSm;
-            left: $interiorMarginSm;
-            z-index: 2;
-
-            > * + * {
-                margin-left: $interiorMarginSm;
-            }
-
-            .t-alert-unsynced {
-                display: none;
-            }
-        }
     }
 
     .gl-plot-wrapper-display-area-and-x-axis {
@@ -294,6 +275,25 @@ mct-plot {
             right: $m;
         }
     }
+
+    .l-state-indicators {
+        color: $colorPausedBg;
+        position: absolute;
+        display: block;
+        font-size: 1.5em;
+        pointer-events: none;
+        top: $interiorMarginSm;
+        left: $interiorMarginSm;
+        z-index: 2;
+
+        > * + * {
+            margin-left: $interiorMarginSm;
+        }
+
+        .t-alert-unsynced {
+            display: none;
+        }
+    }
 }
 
 .gl-plot-display-area,
@@ -432,6 +432,7 @@ mct-plot {
     &__wrapper {
         // Holds view-control and both collapsed and expanded legends
         flex: 1 1 auto;
+        overflow: auto; // Prevents collapsed legend from forcing scrollbars on higher parent containers
     }
 
     &__view-control {
diff --git a/src/styles/_legacy.scss b/src/styles/_legacy.scss
index 229f84adc5..d34497a6fe 100644
--- a/src/styles/_legacy.scss
+++ b/src/styles/_legacy.scss
@@ -893,7 +893,7 @@ body.desktop {
 .grid-row {
     .grid-cell {
         padding: 3px $interiorMarginLg 3px 0;
-        &[title] {
+        &[title]:not([title=""]) {
             // When a cell has a title, assume it's helpful text
             cursor: help;
         }
diff --git a/src/ui/inspector/inspector.scss b/src/ui/inspector/inspector.scss
index a29a4b7617..cd5b56107a 100644
--- a/src/ui/inspector/inspector.scss
+++ b/src/ui/inspector/inspector.scss
@@ -143,7 +143,7 @@
     &__label {
         color: $colorInspectorPropName;
 
-        &[title] {
+        &[title]:not([title=""]) {
             // When a cell has a title, assume it's helpful text
             cursor: help;
         }