Update test specs to use Jasmine 3 (#2089)

* Updated Karma and Jasmine versions

* Added DOMObserver class. Supports promise-based testing of DOM changes

Update asynchronous test specs to use promises or done() instead of waitsFor/runs

* Modified ActionCapability to duplicate context object properties as own properties for better object equality comparisons

* Global find + replace to fix syntax issues

* Fixed various issues caused by non-deterministic runtime order of tests in Jasmine 3. Fixed issues caused by changes to determination of object equality

* Addressed review comments

* Resolved merge conflicts with master

* Fixed style errors

* Use spy.calls.count() instead of manually tracking
This commit is contained in:
Andrew Henry
2018-06-29 17:32:59 -07:00
committed by Pete Richards
parent 013eba744d
commit 433dee0314
305 changed files with 2866 additions and 3324 deletions

View File

@ -33,7 +33,7 @@ define(
controller;
function fireWatch(expr, value) {
mockScope.$watch.calls.forEach(function (call) {
mockScope.$watch.calls.all().forEach(function (call) {
if (call.args[0] === expr) {
call.args[1](value);
}
@ -50,15 +50,15 @@ define(
'format'
]);
mockFormatService.getFormat.andReturn(mockFormat);
mockFormatService.getFormat.and.returnValue(mockFormat);
mockFormat.validate.andCallFake(function (text) {
mockFormat.validate.and.callFake(function (text) {
return moment.utc(text, TEST_FORMAT).isValid();
});
mockFormat.parse.andCallFake(function (text) {
mockFormat.parse.and.callFake(function (text) {
return moment.utc(text, TEST_FORMAT).valueOf();
});
mockFormat.format.andCallFake(function (value) {
mockFormat.format.and.callFake(function (value) {
return moment.utc(value).format(TEST_FORMAT);
});
@ -159,8 +159,8 @@ define(
var newText = "2015-3-3 01:02:04",
oldValue = mockScope.ngModel.testField;
mockFormat.validate.andReturn(true);
mockFormat.parse.andReturn(42);
mockFormat.validate.and.returnValue(true);
mockFormat.parse.and.returnValue(42);
mockScope.textValue = newText;
fireWatch("textValue", newText);
@ -176,7 +176,7 @@ define(
});
it("throws an error for unknown formats", function () {
mockFormatService.getFormat.andReturn(undefined);
mockFormatService.getFormat.and.returnValue(undefined);
expect(function () {
fireWatch("structure.format", "some-format");
}).toThrow();
@ -187,9 +187,9 @@ define(
testText = "some text";
beforeEach(function () {
mockFormat.validate.andReturn(true);
mockFormat.parse.andReturn(testValue);
mockFormat.format.andReturn(testText);
mockFormat.validate.and.returnValue(true);
mockFormat.parse.and.returnValue(testValue);
mockFormat.format.and.returnValue(testText);
});
it("parses user input", function () {