ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2024-12-29 17:38:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Persistence] Reject promises for failed updates

Browse Source 
Reject promises for failed update attempts, WTD-1033.
This commit is contained in:
Victor Woeltjen 2015-03-20 13:40:53 -07:00
parent e5c5caf26e
commit 42e7862174
1 changed files with 27 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
platform/persistence/elastic/src/ElasticPersistenceProvider.js
View File

@ -9,7 +9,8 @@ define(
// so hide them here.
var SRC = "_source",
REV = "_version",
ID = "_id";
ID = "_id",
CONFLICT = 409;
/**
* The ElasticPersistenceProvider reads and writes JSON documents
@ -69,15 +70,31 @@ define(
}
}
// Handle an update error
function handleError(response, key) {
var error = new Error("Persistence error.");
if ((response || {}).status === CONFLICT) {
error.key = "revision";
// Load the updated model, then reject the promise
return get(key).then(function (model) {
error.model = model;
throw error;
});
}
// Reject the promise
throw error;
}
// Check the response to a create/update/delete request;
// track the rev if it's valid, otherwise return false to
// indicate that the request failed.
function checkResponse(response) {
if (response && response.ok) {
revs[response.id] = response.rev;
return response.ok;
function checkResponse(response, key) {
var error;
if (response && !response.error) {
revs[ID] = response[REV];
return response;
} else {
return false;
return handleError(response, key);
}
}
@ -139,8 +156,11 @@ define(
* operation
*/
updateObject: function (space, key, value) {
function checkUpdate(response) {
return checkResponse(response, key);
}
return put(key, value, { version: revs[key] })
.then(checkResponse);
.then(checkUpdate);
},
/**
* Delete an object in the specified persistence space.